From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FCA71C36; Mon, 23 Dec 2024 14:14:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734963270; cv=none; b=MOiYegCkO/XIDNjFqjlw9JGH3egmVeMyzUbV1t6NwxUq0RZ243hjPMun8fq63EEOUcfFfwgncXm2Wg261Vhz8Psz6WaOSQPwbIZKspGiBpTaogu3cQhjMCilRDVG2Di59zjALupx526Uyor/XtRVfx9PtbVVoXdiptxd9Z9gxB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734963270; c=relaxed/simple; bh=BekGjEOJvWHigzaoH92UE5IcDlvCW88ZoU7sUnFMFfc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HxrmLPhmm0IlY7uAL/6Nsk0LnEn5I6oQpsVQYFdj/dNAIthqGg8zhAA/JwL2gs/SccxxrbIKjY4zZUvJ7Tu6RQ8YLZB2tWHdh66YrzFrMd6VXZfKIHbaqC/yU0aALVmiEgXyuSKsSx4TyRW2ajnSXkE5m4YMRsa791pjO1kx/jY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a3k6MN3D; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a3k6MN3D" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E37E7C4CED3; Mon, 23 Dec 2024 14:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734963269; bh=BekGjEOJvWHigzaoH92UE5IcDlvCW88ZoU7sUnFMFfc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=a3k6MN3DC/m+ft3dZHPOksQKs0Bx0z4NMfGniYKSJYqkrMazX6HMGr2C/hXzUIaX5 0tWC3ur9FXEgXDb2kj5MWOzpzuki+uKWyl+vGSdlx/G35GQpu3sF5nBZVtAG3jtnKU XTello1+91PsF/VQKntTBU6J3OLwOGabnp88T4ih+qLFIz1whiNORaIO2ikIGNq/sg BFF0X8nLM7oKHhHxmpjA4Rao/y1M9oEoLE4EHLikGwFcx5kiOb1j0Bh4BriJGcGAC4 /YZAB2y+g2vLvY6q84OXD0xuBH+QdM4GMbk+RDUjFP3kAzN/q1xxWgrOlCbRG6FVGu ShSgEAsa6MkwQ== Message-ID: Date: Mon, 23 Dec 2024 15:14:24 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: arm: google: add gs101-raven and generic gs101-pixel To: =?UTF-8?Q?Andr=C3=A9_Draszik?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , Tudor Ambarus , Alim Akhtar Cc: Will McVicker , kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20241220-gs101-simplefb-v2-0-c10a8f9e490b@linaro.org> <20241220-gs101-simplefb-v2-1-c10a8f9e490b@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 23/12/2024 08:45, André Draszik wrote: > Hi Krzysztof, > > On Sun, 2024-12-22 at 12:38 +0100, Krzysztof Kozlowski wrote: >> On 20/12/2024 12:27, André Draszik wrote: >>> Raven is Google's code name for Pixel 6 Pro. Since there are >>> differences compared to Pixel 6 (Oriole), we need to add a separate >>> compatible for it. >>> >>> We also want to support a generic DT, which can work on any type of >> >> There are no such generic DT devices upstream, so we cannot add bindings >> for them. > > Do you have a better suggestion for the wording? > How about 'gs101-based Pixel base board'? It's not exactly about the wording but the concept. We don't have generic devices, thus no generic DT (DTS). Period. Thus you cannot have such schema. > >>> gs101-based Pixel device, e.g. Pixel 6, or Pixel 6 Pro, or Pixel 6a (as >>> a future addition). Such a DT will have certain nodes disabled / not >>> added. To facilitate such a generic gs101-based Pixel device, also add >>> a more generic gs101-pixel compatible. We can not just use the existing >>> google,gs101 for that, as it refers to the SoC, not a board. >>> >>> Signed-off-by: André Draszik >>> --- >>>  Documentation/devicetree/bindings/arm/google.yaml | 18 ++++++++++++++---- >>>  1 file changed, 14 insertions(+), 4 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/google.yaml b/Documentation/devicetree/bindings/arm/google.yaml >>> index e20b5c9b16bc..a8faf2256242 100644 >>> --- a/Documentation/devicetree/bindings/arm/google.yaml >>> +++ b/Documentation/devicetree/bindings/arm/google.yaml >>> @@ -34,11 +34,21 @@ properties: >>>      const: '/' >>>    compatible: >>>      oneOf: >>> -      - description: Google Pixel 6 / Oriole >>> +      - description: Google GS101 Pixel devices, as generic Pixel, or Pixel 6 >>> +          (Oriole), or 6 Pro (Raven) >>> +        minItems: 2 >>> +        maxItems: 3 >>>          items: >>> -          - enum: >>> -              - google,gs101-oriole >>> -          - const: google,gs101 >>> +          enum: >>> +            - google,gs101-oriole >>> +            - google,gs101-raven >>> +            - google,gs101-pixel >>> +            - google,gs101 >> >> SoC cannot be a board in the same time. > > Can you please expand? google,gs101 is the SoC, the other ones are boards. > Is the commit message unclear? You now say that these are valid boards: compatible = "google,gs101", "google,gs101"; (although compatibles compatible = "google,gs101", "google,gs101-pixel"; Both are wrong. SoC should not be before the board and SoC cannot be used alone. Your schema allows that and that's not good. I did not get what you want to achieve here, so tricky to advice. Best regards, Krzysztof