From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B9DEC43461 for ; Tue, 15 Sep 2020 11:40:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DDEC208E4 for ; Tue, 15 Sep 2020 11:40:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="EzAn19iR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726253AbgIOLkO (ORCPT ); Tue, 15 Sep 2020 07:40:14 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:44418 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726381AbgIOLhI (ORCPT ); Tue, 15 Sep 2020 07:37:08 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08FBaopM006882; Tue, 15 Sep 2020 06:36:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1600169810; bh=eV7ThKdF75EChfgLQxXghwryE8FBjegkKu0o1htOZpA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=EzAn19iR3dGyse6Ep7KMTjHUpS3k5hXl6FYcaRxKdnrvCHHdFWQsr1HryNoZfrtTZ 7dvk2GV0dhK7sDpKSYgs9/Wnwf3KEAVabq1hX970PCskZWLfdhn0rtNsUEQTyTqKCK Wdhre7gc4dYJ+cKaY09FGDuMKCxQs7tysk1307WU= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08FBaop1012803; Tue, 15 Sep 2020 06:36:50 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 15 Sep 2020 06:36:42 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 15 Sep 2020 06:36:43 -0500 Received: from [10.250.235.166] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08FBadk9040132; Tue, 15 Sep 2020 06:36:40 -0500 Subject: Re: [PATCH v4 4/5] arm64: dts: ti: Add support for J7200 SoC To: Nishanth Menon CC: Lokesh Vutla , Tero Kristo , Rob Herring , Device Tree Mailing List , Grygorii Strashko , Sekhar Nori , Kishon Vijay Abraham I , Linux ARM Mailing List References: <20200914162231.2535-1-lokeshvutla@ti.com> <20200914162231.2535-5-lokeshvutla@ti.com> <20200915113431.672dtedc4bq6qtye@akan> From: Vignesh Raghavendra Message-ID: Date: Tue, 15 Sep 2020 17:06:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200915113431.672dtedc4bq6qtye@akan> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 9/15/20 5:04 PM, Nishanth Menon wrote: > On 10:39-20200915, Vignesh Raghavendra wrote: >> [...] >> >> On 9/14/20 9:52 PM, Lokesh Vutla wrote: >>> + >>> + cbass_main: bus@100000 { >>> + compatible = "simple-bus"; >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + ranges = <0x00 0x00100000 0x00 0x00100000 0x00 0x00020000>, /* ctrl mmr */ >>> + <0x00 0x00600000 0x00 0x00600000 0x00 0x00031100>, /* GPIO */ >>> + <0x00 0x00a40000 0x00 0x00a40000 0x00 0x00000800>, /* timesync router */ >>> + <0x00 0x01000000 0x00 0x01000000 0x00 0x0d000000>, /* Most peripherals */ >>> + <0x00 0x30000000 0x00 0x30000000 0x00 0x0c400000>, /* MAIN NAVSS */ >>> + <0x00 0x70000000 0x00 0x70000000 0x00 0x00800000>, /* MSMC RAM */ >>> + <0x00 0x18000000 0x00 0x18000000 0x00 0x08000000>, /* PCIe1 DAT0 */ >>> + <0x41 0x00000000 0x41 0x00000000 0x01 0x00000000>, /* PCIe1 DAT1 */ >>> + >>> + /* MCUSS_WKUP Range */ >>> + <0x00 0x28380000 0x00 0x28380000 0x00 0x03880000>, >>> + <0x00 0x40200000 0x00 0x40200000 0x00 0x00998400>, >>> + <0x00 0x40f00000 0x00 0x40f00000 0x00 0x00020000>, >>> + <0x00 0x41000000 0x00 0x41000000 0x00 0x00020000>, >>> + <0x00 0x41400000 0x00 0x41400000 0x00 0x00020000>, >>> + <0x00 0x41c00000 0x00 0x41c00000 0x00 0x00100000>, >>> + <0x00 0x42040000 0x00 0x42040000 0x00 0x03ac2400>, >>> + <0x00 0x45100000 0x00 0x45100000 0x00 0x00c24000>, >>> + <0x00 0x46000000 0x00 0x46000000 0x00 0x00200000>, >>> + <0x00 0x47000000 0x00 0x47000000 0x00 0x00068400>, >>> + <0x00 0x50000000 0x00 0x50000000 0x00 0x10000000>, >>> + <0x05 0x00000000 0x05 0x00000000 0x01 0x00000000>, >>> + <0x07 0x00000000 0x07 0x00000000 0x01 0x00000000>; >>> + >>> + cbass_mcu_wakeup: bus@28380000 { >>> + compatible = "simple-bus"; >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + ranges = <0x00 0x28380000 0x00 0x28380000 0x00 0x03880000>, /* MCU NAVSS*/ >>> + <0x00 0x40200000 0x00 0x40200000 0x00 0x00998400>, /* First peripheral window */ >>> + <0x00 0x40f00000 0x00 0x40f00000 0x00 0x00020000>, /* CTRL_MMR0 */ >>> + <0x00 0x41000000 0x00 0x41000000 0x00 0x00020000>, /* MCU R5F Core0 */ >>> + <0x00 0x41400000 0x00 0x41400000 0x00 0x00020000>, /* MCU R5F Core1 */ >>> + <0x00 0x41c00000 0x00 0x41c00000 0x00 0x00100000>, /* MCU SRAM */ >>> + <0x00 0x42040000 0x00 0x42040000 0x00 0x03ac2400>, /* WKUP peripheral window */ >>> + <0x00 0x45100000 0x00 0x45100000 0x00 0x00c24000>, /* MMRs, remaining NAVSS */ >>> + <0x00 0x46000000 0x00 0x46000000 0x00 0x00200000>, /* CPSW */ >>> + <0x00 0x47000000 0x00 0x47000000 0x00 0x00068400>, /* OSPI register space */ >>> + <0x00 0x50000000 0x00 0x50000000 0x00 0x10000000>, /* FSS OSPI0/1 data region 0 */ >>> + <0x05 0x00000000 0x05 0x00000000 0x01 0x00000000>, /* FSS OSPI0 data region 3 */ >>> + <0x07 0x00000000 0x07 0x00000000 0x01 0x00000000>; /* FSS OSPI1 data region 3 */ >>> + }; >>> + }; >>> +}; >> >> OSPI ranges look good to me... Thanks for adding them! >> >> [...] > > Is that a reviewed-by ? if so, please add tag? > For OSPI bits: Reviewed-by: Vignesh Raghavendra