From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D82C433F5 for ; Mon, 10 Oct 2022 10:29:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231817AbiJJK3L (ORCPT ); Mon, 10 Oct 2022 06:29:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231806AbiJJK3J (ORCPT ); Mon, 10 Oct 2022 06:29:09 -0400 Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 156D41B9E4 for ; Mon, 10 Oct 2022 03:29:05 -0700 (PDT) Received: by mail-qv1-xf2a.google.com with SMTP id i12so6878746qvs.2 for ; Mon, 10 Oct 2022 03:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+Ty/SQ7ZQb5ub5WO9P8Lo7LRFzcBze++LmcsjSK0IUs=; b=SbUTQwNXF6cpHzOUKB1Eotm+CoeI6DGaiOBfiJR4e3h/fAZDpIg7aILfdKMDA7cuZ2 lVgKfsv1H2ABJopnsyON6w/78z9cAG6qCBDxeb+xv+qsH5Ae5hM9/zYYhjDmZXtVvHmT cjwJ1yl/iiaIam9sgblVmhCopRSn343SeiRhqXlevol+G4H7qZxKe5/P27SoylDLb7TY uSbwxOcqb1DQdZHWDar/g+e0SMWVS8pBHiWlYMyzpysuKRekYoo+JYTMHbYOWD0VGtFV ws85HrSHx8Chltg2HsfdtngDRSJi71AD3GraHpDqJ/kp62kGFUZKNFpUHuYeNsAomiI3 5O1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+Ty/SQ7ZQb5ub5WO9P8Lo7LRFzcBze++LmcsjSK0IUs=; b=C1wnt5sebZt6tyWTc7Tvs7vgZnWIHHqcEma22wxqITmx3onWsCCCeMH6t+B3Ohlv75 +qp8pvX3ojl+BAUckkQZSsZZ50vTbFE9Pm/kti/lH/JPLsvYNiz6sAi19um4mQ5PXUuQ 0m4ALycmopS0xKvMm49pQ0EG5/o8pchDN2sQ9zvuAOIfU4HJbMKXOZuSQTYUl89BS3k4 orHMRGgwNRIdmPN8MCwfDkWbTqolzlYKNySCP/GjnsqeTAct3Tn86pNMk9n4Az6NN/zb Q/suRMRgQhtZFP17ZjTqS2oXXjWlZfcQi+x/XaNWYZOLxwcnJMY1LbAlUtCp4/cRaWRa wOJg== X-Gm-Message-State: ACrzQf3+dRLUNCMLs0AJRbPs4iS3qiLI1KqcWhTDq2fRwdwGeRMJ3ecC Ect39LwFSqp91S3zuFDKSHoCiA== X-Google-Smtp-Source: AMsMyM4UpI8bhDJqFqWEygDw1Ur2ePekgUCEnUAFdHhbnnGN696lz2RnVs4cGmw1vQYo2W2/TttGqw== X-Received: by 2002:a05:6214:2b05:b0:4b1:d595:3a24 with SMTP id jx5-20020a0562142b0500b004b1d5953a24mr14514640qvb.71.1665397744246; Mon, 10 Oct 2022 03:29:04 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id h3-20020a05620a244300b006d94c499d8fsm9930615qkn.50.2022.10.10.03.29.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 03:29:03 -0700 (PDT) Message-ID: Date: Mon, 10 Oct 2022 06:26:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 34/40] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema Content-Language: en-US To: Marijn Suijten Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> <20220912061746.6311-35-krzysztof.kozlowski@linaro.org> <20221009174621.ecamh76faoibuykv@SoMainline.org> From: Krzysztof Kozlowski In-Reply-To: <20221009174621.ecamh76faoibuykv@SoMainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/10/2022 13:46, Marijn Suijten wrote: >> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi >> index 8c582a9e4ada..1fe3fa3ad877 100644 >> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi >> @@ -387,19 +387,19 @@ tlmm: pinctrl@500000 { >> #interrupt-cells = <2>; >> >> sdc2_off_state: sdc2-off-state { >> - clk { >> + clk-pins { >> pins = "sdc2_clk"; >> drive-strength = <2>; >> bias-disable; >> }; >> >> - cmd { >> + cmd-pins { >> pins = "sdc2_cmd"; >> drive-strength = <2>; >> bias-pull-up; >> }; >> >> - data { >> + data-pins { >> pins = "sdc2_data"; >> drive-strength = <2>; >> bias-pull-up; >> @@ -413,13 +413,13 @@ clk { >> bias-disable; >> }; >> >> - cmd { >> + cmd-pins-pins { > > Is this double -pins-pins suffix intended? > No, thanks for noticing it. Best regards, Krzysztof