* [PATCHv2] ARM: dts: am5748: keep usb4_tm disabled
@ 2022-08-23 7:27 Romain Naour
2022-08-25 7:08 ` Roger Quadros
0 siblings, 1 reply; 3+ messages in thread
From: Romain Naour @ 2022-08-23 7:27 UTC (permalink / raw)
To: linux-omap
Cc: devicetree, bcousson, tony, Romain Naour, Romain Naour,
Roger Quadros
From: Romain Naour <romain.naour@skf.com>
Commit bcbb63b80284 ("ARM: dts: dra7: Separate AM57 dtsi files")
disabled usb4_tm for am5748 devices since USB4 IP is not present
in this SoC.
The commit log explained the difference between AM5 and DRA7 families:
AM5 and DRA7 SoC families have different set of modules in them so the
SoC sepecific dtsi files need to be separated.
e.g. Some of the major differences between AM576 and DRA76
DRA76x AM576x
USB3 x
USB4 x
ATL x
VCP x
MLB x
ISS x
PRU-ICSS1 x
PRU-ICSS2 x
Then commit 176f26bcd41a ("ARM: dts: Add support for dra762 abz
package") removed usb4_tm part from am5748.dtsi and introcuded new
ti-sysc errors in dmesg:
ti-sysc 48940000.target-module: clock get error for fck: -2
ti-sysc: probe of 48940000.target-module failed with error -2
Fixes: 176f26bcd41a ("ARM: dts: Add support for dra762 abz package")
Signed-off-by: Romain Naour <romain.naour@skf.com>
Signed-off-by: Romain Naour <romain.naour@smile.fr>
Cc: Roger Quadros <rogerq@kernel.org>
---
Issue reproduced on a AM5749 CPU using a 5.10 kernel from ti-linux-kernel:
https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?h=linux-5.10.y
v2: improved commit log to ease patch backport
---
arch/arm/boot/dts/am5748.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/am5748.dtsi b/arch/arm/boot/dts/am5748.dtsi
index c260aa1a85bd..a1f029e9d1f3 100644
--- a/arch/arm/boot/dts/am5748.dtsi
+++ b/arch/arm/boot/dts/am5748.dtsi
@@ -25,6 +25,10 @@ &usb3_tm {
status = "disabled";
};
+&usb4_tm {
+ status = "disabled";
+};
+
&atl_tm {
status = "disabled";
};
--
2.34.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCHv2] ARM: dts: am5748: keep usb4_tm disabled
2022-08-23 7:27 [PATCHv2] ARM: dts: am5748: keep usb4_tm disabled Romain Naour
@ 2022-08-25 7:08 ` Roger Quadros
2022-09-06 7:06 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Roger Quadros @ 2022-08-25 7:08 UTC (permalink / raw)
To: Romain Naour, linux-omap; +Cc: devicetree, bcousson, tony, Romain Naour
On 23/08/2022 10:27, Romain Naour wrote:
> From: Romain Naour <romain.naour@skf.com>
>
> Commit bcbb63b80284 ("ARM: dts: dra7: Separate AM57 dtsi files")
> disabled usb4_tm for am5748 devices since USB4 IP is not present
> in this SoC.
>
> The commit log explained the difference between AM5 and DRA7 families:
>
> AM5 and DRA7 SoC families have different set of modules in them so the
> SoC sepecific dtsi files need to be separated.
>
> e.g. Some of the major differences between AM576 and DRA76
>
> DRA76x AM576x
>
> USB3 x
> USB4 x
> ATL x
> VCP x
> MLB x
> ISS x
> PRU-ICSS1 x
> PRU-ICSS2 x
>
> Then commit 176f26bcd41a ("ARM: dts: Add support for dra762 abz
> package") removed usb4_tm part from am5748.dtsi and introcuded new
> ti-sysc errors in dmesg:
>
> ti-sysc 48940000.target-module: clock get error for fck: -2
> ti-sysc: probe of 48940000.target-module failed with error -2
>
> Fixes: 176f26bcd41a ("ARM: dts: Add support for dra762 abz package")
>
> Signed-off-by: Romain Naour <romain.naour@skf.com>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> Cc: Roger Quadros <rogerq@kernel.org>
> ---
> Issue reproduced on a AM5749 CPU using a 5.10 kernel from ti-linux-kernel:
> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?h=linux-5.10.y
>
> v2: improved commit log to ease patch backport
> ---
> arch/arm/boot/dts/am5748.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Roger Quadros <rogerq@kernel.org>
cheers,
-roger
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2] ARM: dts: am5748: keep usb4_tm disabled
2022-08-25 7:08 ` Roger Quadros
@ 2022-09-06 7:06 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2022-09-06 7:06 UTC (permalink / raw)
To: Roger Quadros
Cc: Romain Naour, linux-omap, devicetree, bcousson, Romain Naour
* Roger Quadros <rogerq@kernel.org> [220825 07:01]:
> On 23/08/2022 10:27, Romain Naour wrote:
> > From: Romain Naour <romain.naour@skf.com>
> >
> > Commit bcbb63b80284 ("ARM: dts: dra7: Separate AM57 dtsi files")
> > disabled usb4_tm for am5748 devices since USB4 IP is not present
> > in this SoC.
> >
> > The commit log explained the difference between AM5 and DRA7 families:
> >
> > AM5 and DRA7 SoC families have different set of modules in them so the
> > SoC sepecific dtsi files need to be separated.
> >
> > e.g. Some of the major differences between AM576 and DRA76
> >
> > DRA76x AM576x
> >
> > USB3 x
> > USB4 x
> > ATL x
> > VCP x
> > MLB x
> > ISS x
> > PRU-ICSS1 x
> > PRU-ICSS2 x
> >
> > Then commit 176f26bcd41a ("ARM: dts: Add support for dra762 abz
> > package") removed usb4_tm part from am5748.dtsi and introcuded new
> > ti-sysc errors in dmesg:
> >
> > ti-sysc 48940000.target-module: clock get error for fck: -2
> > ti-sysc: probe of 48940000.target-module failed with error -2
> >
> > Fixes: 176f26bcd41a ("ARM: dts: Add support for dra762 abz package")
> >
> > Signed-off-by: Romain Naour <romain.naour@skf.com>
> > Signed-off-by: Romain Naour <romain.naour@smile.fr>
> > Cc: Roger Quadros <rogerq@kernel.org>
> > ---
> > Issue reproduced on a AM5749 CPU using a 5.10 kernel from ti-linux-kernel:
> > https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?h=linux-5.10.y
> >
> > v2: improved commit log to ease patch backport
> > ---
> > arch/arm/boot/dts/am5748.dtsi | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
Applying into fixes thanks.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-06 7:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-23 7:27 [PATCHv2] ARM: dts: am5748: keep usb4_tm disabled Romain Naour
2022-08-25 7:08 ` Roger Quadros
2022-09-06 7:06 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).