From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sherry Sun <sherry.sun@nxp.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com, shenwei.wang@nxp.com,
gregkh@linuxfoundation.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com
Subject: Re: [PATCH 4/4] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string
Date: Sun, 25 Jun 2023 12:17:33 +0200 [thread overview]
Message-ID: <d990a281-b4a3-1e26-1fdf-dfd35ab9cd24@linaro.org> (raw)
In-Reply-To: <20230625094857.29644-5-sherry.sun@nxp.com>
On 25/06/2023 11:48, Sherry Sun wrote:
> LPUART driver adds a new compatible string for imx8ulp, and imx93 is
What driver adds or not, is not really correct argument for
compatibility. There are plenty of compatible devices which have both
device ID entries in the driver. Why would you drop their compatibility
between each other? It does not work like that... Provide clear
rationale for this.
> much more compatible with imx8ulp than imx7ulp, so correct the
> dt-binding here.
>
"Much more compatible" is too vague.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-25 10:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 9:48 [PATCH 0/4] correct the lpuart compatible for imx8dxl/imx8ulp/imx93 Sherry Sun
2023-06-25 9:48 ` [PATCH 1/4] arm64: dts: imx8dxl: remove "fsl,imx7ulp-lpuart" compatible for imx8dxl Sherry Sun
2023-06-25 9:48 ` [PATCH 2/4] arm64: dts: imx8ulp: remove "fsl,imx7ulp-lpuart" compatible for i.MX8ULP Sherry Sun
2023-06-25 10:13 ` Krzysztof Kozlowski
2023-06-25 9:48 ` [PATCH 3/4] arm64: dts: imx93: use "fsl,imx8ulp-lpuart" compatible for imx93 Sherry Sun
2023-06-25 9:48 ` [PATCH 4/4] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string Sherry Sun
2023-06-25 10:17 ` Krzysztof Kozlowski [this message]
2023-06-25 13:12 ` Sherry Sun
2023-06-25 15:40 ` Krzysztof Kozlowski
2023-06-26 2:02 ` Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d990a281-b4a3-1e26-1fdf-dfd35ab9cd24@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).