From: Dragan Simic <dsimic@manjaro.org>
To: Conor Dooley <conor@kernel.org>
Cc: Tim Lunn <tim@feathertop.org>,
linux-rockchip@lists.infradead.org, Andy Yan <andyshrk@163.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Chris Morgan <macromorgan@hotmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
David Heidelberg <david@ixit.cz>,
Heiko Stuebner <heiko@sntech.de>, Jagan Teki <jagan@edgeble.ai>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Ondrej Jirman <megi@xff.cz>, Rob Herring <robh+dt@kernel.org>,
Tianling Shen <cnsztl@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Fix vendor strings on Rockchip boards
Date: Wed, 14 Feb 2024 19:30:44 +0100 [thread overview]
Message-ID: <d9a17e535f8e414f91fe06b2b71849f9@manjaro.org> (raw)
In-Reply-To: <20240214-moocher-womanless-21201b67b76d@spud>
Hello Conor,
On 2024-02-14 19:12, Conor Dooley wrote:
> On Wed, Feb 14, 2024 at 03:27:08PM +1100, Tim Lunn wrote:
>> On 2/14/24 15:14, Dragan Simic wrote:
>> > On 2024-02-14 05:07, Tim Lunn wrote:
>> > > A couple of rockchip boards incorrectly list their vendor as Rockchip
>> > > when they are in fact not manufactured by Rockchip.
>> > >
>> > > Fix the vendor strings to correctly list the manufacturer
>> >
>> > Just checking, have you verified that the old, incorrect "compatible"
>> > strings from the board dts files aren't used anywhere in the kernel code,
>> > such as in some drivers?
>> >
>> Yes I checked that, there are no remaining references to the
>> old/incorrect
>> compatible strings in kernel code
>
> What about other code? Like a BSD or a bootloader? If nothing is using
> them
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
I just quickly checked U-Boot and it's fine.
> Fixes tags I think wouldn't go amiss, but I'm not expecting a resend
> with them.
next prev parent reply other threads:[~2024-02-14 18:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 4:07 [PATCH 0/4] Fix vendor strings on Rockchip boards Tim Lunn
2024-02-14 4:07 ` [PATCH 1/4] dt-bindings: arm: rockchip: Correct vendor for Orange Pi RK3399 board Tim Lunn
2024-02-14 23:45 ` Tim Lunn
2024-02-15 15:09 ` Rob Herring
2024-02-14 4:07 ` [PATCH 2/4] dt-bindings: arm: rockchip: Correct vendor for Banana Pi R2 Pro Tim Lunn
2024-02-14 23:37 ` Tim Lunn
2024-02-15 15:10 ` Rob Herring
2024-02-14 4:07 ` [PATCH 3/4] arm64: dts: rockchip: adjust vendor on Banana Pi R2 Pro board Tim Lunn
2024-02-14 4:07 ` [PATCH 4/4] arm64: dts: rockchip: adjust vendor on orangepi rk3399 board Tim Lunn
2024-02-14 4:14 ` [PATCH 0/4] Fix vendor strings on Rockchip boards Dragan Simic
2024-02-14 4:27 ` Tim Lunn
2024-02-14 18:12 ` Conor Dooley
2024-02-14 18:30 ` Dragan Simic [this message]
2024-02-15 0:28 ` Tim Lunn
2024-02-27 23:13 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9a17e535f8e414f91fe06b2b71849f9@manjaro.org \
--to=dsimic@manjaro.org \
--cc=andyshrk@163.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=cnsztl@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@edgeble.ai \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=megi@xff.cz \
--cc=robh+dt@kernel.org \
--cc=tim@feathertop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).