From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dinh Nguyen <dinguyen@kernel.org>,
Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] arm64: dts: agilex5: add support for debug daughter card
Date: Wed, 13 May 2026 20:09:32 +0200 [thread overview]
Message-ID: <d9a1e0ec-fa4a-478a-957e-47a1559380db@kernel.org> (raw)
In-Reply-To: <ec0633a6-30f6-4db6-875d-69a4f0f140ca@kernel.org>
On 09/05/2026 14:05, Dinh Nguyen wrote:
>
>
> On 5/8/26 05:57, Adrian Ng Ho Yin wrote:
>> The Agilex5 SoCDK supports an optional debug daughter card that requires
>> a dedicated device tree variant due to differences in peripheral
>> connectivity compared to the standard SoCDK configuration.
>>
>> When the debug daughter card is fitted:
>> - gpio0 and gmac2 are disabled
>> - gmac0 is enabled with RGMII PHY connectivity
>> - spi0 is enabled with a <device> peripheral at chip select 0
>> - The HPS LED is rewired from gpio0/porta to gpio1/portb
>>
>> The new DTS inherits from socfpga_agilex5_socdk.dts and overrides only
>> the nodes that differ, keeping the delta minimal.
>>
>> Adrian Ng Ho Yin (2):
>> dt-bindings: altera: add compatible for agilex5 socdk debug daughter
>> card
>> arm64: dts: agilex5: add support for debug daughter card
>>
>
> Applied!
No, really. This is really unreviewed poor DTS containing fake nodes.
Please drop the patch.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-05-13 18:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 10:57 [PATCH 0/2] arm64: dts: agilex5: add support for debug daughter card Adrian Ng Ho Yin
2026-05-08 10:57 ` [PATCH 1/2] dt-bindings: altera: add compatible for agilex5 socdk " Adrian Ng Ho Yin
2026-05-08 15:01 ` Conor Dooley
2026-05-08 10:57 ` [PATCH 2/2] arm64: dts: agilex5: add support for " Adrian Ng Ho Yin
2026-05-08 20:42 ` sashiko-bot
2026-05-13 18:09 ` Krzysztof Kozlowski
2026-05-13 18:09 ` Krzysztof Kozlowski
2026-05-09 12:05 ` [PATCH 0/2] " Dinh Nguyen
2026-05-13 18:09 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9a1e0ec-fa4a-478a-957e-47a1559380db@kernel.org \
--to=krzk@kernel.org \
--cc=adrian.ho.yin.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox