From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B344358362; Thu, 19 Mar 2026 08:04:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773907451; cv=none; b=UGZTOSIEdhlVx/+OWfiR4NsN0cpJrMNlR3zscaZ8HwlE5cXT3wcVF3QaM7+iHkda+B0ST+D7qac6WLQPygY9YXq5sNTPEncFy2/IxYWzh+feDLIQDENb0EjkMXPYq063EzYWI1T9+n/v9O79xZxyd54FM7vXXLUspkmAc+eeNeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773907451; c=relaxed/simple; bh=oddScRKYzaeDQ9pGWNCQ6oWoxk9xdprHLqYG2eBVmlQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dYDOshDJt3CCTY2OBLQeEOuF/7QnRMXMXEmg/PaXe3BXiL3fh40n4dlzwbSUGni6ya5lHVnA1TSmexDwwCMti7LIZz7RjH2P/auaBhJ9RPkdkeYgUchJm9j8gp4wL+5p0gAFypVMXbyrHy9YaWAXs3hwAeXlUDw15Lr/1kedjPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=a8OcSNGB; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="a8OcSNGB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1773907448; bh=oddScRKYzaeDQ9pGWNCQ6oWoxk9xdprHLqYG2eBVmlQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=a8OcSNGBcqdOsgpeikZ6TXswpBrTS9I3QHnKk4mNa0ibBWD068edwm47HjayT4h9W kxWXUEBdKKC3YD7ccz827IEJHKzS+rNgyqGqeYACcKdFDPNLbot5QEmfSaYqxiNZef Z7Me4f46esE/NOqrpk5CnbXQb6wR7RTn8E0qZq7mq9DoIfsAk01VzTJo2FSBq8ZZGc LsHtwOI8bBu5RjlzRVl7IoJAvLTZ2O4HTJyXlwwqo8OT6fexWio6egKG2laLdeJ0RM cfmnbWJPA03dE3djLFFy3BHb+pBsujxk8g5X/ZGCXG90x3S3PipBHzGxjnmySWmJEG PGL7qpyblQgng== Received: from [10.40.0.100] (185-67-175-126.lampert.tv [185.67.175.126]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mriesch) by bali.collaboradmins.com (Postfix) with ESMTPSA id 79FE417E0EB4; Thu, 19 Mar 2026 09:04:07 +0100 (CET) Message-ID: Date: Thu, 19 Mar 2026 09:04:06 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/9] media: dt-bindings: add rockchip rk3588 vicap To: Conor Dooley Cc: Mehdi Djait , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Jagan Teki , =?UTF-8?B?0JrRg9C30L3QtdGG0L7QsiDQnNC40YXQsNC40Ls=?= , Sebastian Reichel , Nicolas Dufresne , Collabora Kernel Team , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250430-rk3588-vicap-v2-0-77de5ee9048e@collabora.com> <20250430-rk3588-vicap-v2-2-77de5ee9048e@collabora.com> <20260318-mumbo-lumber-b550932a5423@spud> Content-Language: en-US From: Michael Riesch In-Reply-To: <20260318-mumbo-lumber-b550932a5423@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Conor, On 3/18/26 18:52, Conor Dooley wrote: > [...] >> >> resets: >> - items: >> - - description: ARST >> - - description: HRST >> - - description: DRST >> - - description: PRST >> - - description: IRST >> + minItems: 5 >> + maxItems: 9 >> >> reset-names: >> - items: >> - - const: arst >> - - const: hrst >> - - const: drst >> - - const: prst >> - - const: irst >> + minItems: 5 >> + maxItems: 9 > >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: rockchip,rk3568-vicap >> + then: >> + properties: >> + clocks: >> + minItems: 4 >> + maxItems: 4 > > Anything here that repeats the outermost constraint should be dropped, > so no minItems here.. I already took a look at similar VICAPs (e.g., R3576) that will have more clocks. This is way I left this one in here. But I guess I will remove it and add it again when e.g. RK3576 VICAP support is added. >> [...] > >> + >> + reset-names: >> + items: >> + - const: arst >> + - const: hrst >> + - const: drst >> + - const: irst0 > > Were you willing to reuse "irst" for the 0th irst, all the repetition > wouldn't be needed. I assume it represents the reset for the port at > address 0, so it wouldn't even be a different meaning on each device. Not quite I think. "{a,h,d}rst" are the same on all variants, then there is "prst" and "irst" on RK3568 and "irst{0-5}" on RK3588. So I thought that writing it out explicitly for each variant is more readable (even though it may need a few characters more). OK? I'll try to send out a new version later today. Best regards, Michael > >> + - const: irst1 >> + - const: irst2 >> + - const: irst3 >> + - const: irst4 >> + - const: irst5 >> + >> additionalProperties: false >> >> examples: >> >> -- >> 2.39.5 >> >>