From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC7222DF15E for ; Thu, 4 Sep 2025 09:05:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756976727; cv=none; b=emaUbm2ywXgpvIFmm/+c8zsZTCf4b/L2w4ZqwZl92/T/DwEegaDe2Pa0goUXBiK4eGBBd4PaeD3fpws3VtHCtxk9K07Y5lBuH8XTpX/Pyjlcd6X4Qgbx++pyMy1UfIqFfjfjGZaXyh5OsWPdADCDMZ0Oc+zbnQn1B9l85V+2Nn4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756976727; c=relaxed/simple; bh=plmPEpfQMO3YEjTyCXmuGh54NXSVgSjwnmBAsPAbVyU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BSJ5P4cVO5XvWM7XwpONYvOVn5bTBV7kzfUKajW8Y7mSnW9H90gl5Cl8eMFvAo3p7bPUfF8yTxXEeOhieDRuJAOLhrO+PkEPQval4sgkYlxObkZiaAUBgMYj4XO2ub/sFqkofWsvwQjx534Ha6fxencLwsk7UiFBOENH4POhFLQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=J8CdGFlp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="J8CdGFlp" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5840lrgD005012 for ; Thu, 4 Sep 2025 09:05:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y3354bZOtkc6dotBrNo46+kgtyiv6WAidh4XlD2eQB0=; b=J8CdGFlpYm23cM3o qA9PNlfuOuT/8H21G4e1agtfqjPU0sHk741L/txViUEOWwz8iCNFjhv9muUZ0wbx gaDTd7JeDpC0gqgImekJ4YiDCvqRj5eBmBlwnte8tCMHTWv2SNZ7SynLJdCLulPw N4uHT+qhQQJGl5cupih1yGy/TVqCpGUI1LpIXkNBeIPDgbpyx4qAV+ONX+SNn1IW KvEG2ZB7fh4HHi2Qj8E56l+YdrKbt9h3GtDbK0UtHQOv4U5/vBQ5omax5XVtS43I kF6l6bo9Tb4kbIbCGd5vaZhQxGdtrLfutgcTogjUoB2kUGnPi8pTc+t0vyTM6347 oOUQHg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48ur8s6xyu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 04 Sep 2025 09:05:24 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4b3ca5e94d3so1757491cf.3 for ; Thu, 04 Sep 2025 02:05:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756976723; x=1757581523; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y3354bZOtkc6dotBrNo46+kgtyiv6WAidh4XlD2eQB0=; b=jqjL2wgPuMK5pqTkH+8+47RELUbILoFzFvdfFH3kXnHU80qUog3Zpdz4sdPbxjPa+q Sl6J8DoKDDixmm/rGU+z5Ykv6IJn+ih9QLlx8nYl6rfL9eaxHsIrDuUUGNwDDtQyRykf Ts+Q7pZl5G5FrbAShf8z5RcNpzgXFdmPz2Zw/Fc5dFjTz4qYlvCalNQ4juW/8ZhsJxCr NmVCFPX9cg86uY7CSnVOeLsP+KheSIC8i63qgHrZSP+9UxvE35wQizr1r4WviVx3aQ3O ZyK5WGeAg4SVOunj9PyvS7wh4TmAOex7mFwUI1Ce2VIBZDaZLn4oVchIXPeTS7jsoLQD qCPQ== X-Forwarded-Encrypted: i=1; AJvYcCUwJ8bLWgOTOY8wfQWGVAzoiRmNlKoEt+bcAWNY+LazpwpNxl3qO61p0wxwSZo+bgeLCbghihUKtCK3@vger.kernel.org X-Gm-Message-State: AOJu0YxpnUrAE3uVVlvbAMNOCTcWu2GPoTN7uBOVFz9sxlJd4zdBOSfs +VLzik1bB0wG8PFCoa8XG8aucX0dgM8BTdQRnXZS2Gxhi3lQZZTTVuJtp2+HeizExwTJ9WTBHF7 V1qRhd9F2uMHO/Pp8rEedG6KEk0rPMwljyYz8xDdUfqUX5BK5S9DJHAwtsC5piUoQ X-Gm-Gg: ASbGncsl690xjyF/fH/l9FyT5lzYcKYJPPpW9LLRwlZWXF4X4xJH8iSYNzuMbmyiEi/ B5rRt6T/neJ2Os2JX1+fl4eHybGi80hCgv3SqLumSIBqf/9l8DJ5QKg/FEToSABCCSQMp/GCDpF DuqAPYjB2TGzzgBql6xjLz00IPc/td8vIWQrEFhZMWp09jtKhEncFrRfx68RUXkOcxY1Pi64Fz3 mcO7k7P9oD8YR9Ph1YPTqHlQ7ZG62qtaWzG0jRzxyPrsgCrdhdwnXUlNzHzqgXLnqPHPUL968dY PbK+Rze+6Bxnm4BcdZHVr9WiYcCOXU8UBYe6Gazmrla+ZKAnBeBlcT77e8XU3y6biAi2Brr5FQ2 BXTm7rGWchHMV8OXTua1g/A== X-Received: by 2002:ac8:5d12:0:b0:472:1d00:1fc3 with SMTP id d75a77b69052e-4b313f0e6e7mr174872821cf.8.1756976722799; Thu, 04 Sep 2025 02:05:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKp0JIOqe7KcHRuwNbMy/T1sz594GUnF25np1+U7x9aNCZ0OMz0fmzvg55AOLuXRjrIcc7gQ== X-Received: by 2002:ac8:5d12:0:b0:472:1d00:1fc3 with SMTP id d75a77b69052e-4b313f0e6e7mr174872511cf.8.1756976722305; Thu, 04 Sep 2025 02:05:22 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b041f6fb232sm1089893966b.87.2025.09.04.02.05.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Sep 2025 02:05:21 -0700 (PDT) Message-ID: Date: Thu, 4 Sep 2025 11:05:19 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] pinctrl: qcom: Add SDM660 LPASS LPI TLMM To: Richard Acayan , Nickolay Goppen Cc: Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, Nickolay Goppen References: <20250903-sdm660-lpass-lpi-v5-0-fe171098b6a1@mainlining.org> <20250903-sdm660-lpass-lpi-v5-3-fe171098b6a1@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAxOSBTYWx0ZWRfX4SCAnzhDr0tK jUe84Ei7TBjyMdGo5wbeNxDuXuX2F0zIMpd+UWBoQhP3pmcw92DXNKDaHGdXyWHsMAiFAQFat5J WRfjPbRT/HkR+tZ+dxR2VhX3/oJ42TWGhAEgmV6vLMrDD0NJT5+l/VxOsSgmi+uOJYoPcVLHrLW FcyP+uXJXO35JTM5fDMxr5y7Ak6USpZDbdzCLlXQHe6rcZD2R6Y+3s9mbnxmE3xFsa0YyKNkqMl RtPWKRNPt/lsNUX30C2KyqCIpcehXOc48LfHhweHr2OIhu4nuZFB3ANF/m01zlu/AlMm6JnT8KW q1YF0RrBu3nGY+ms7LHzJPp1eFv7weFIEZDoBishAu3Zc1PAgOUt2JihRVxqypBS5w5Z/ML4DuR 6eArbWL9 X-Proofpoint-GUID: 5J0yEOjIklMrDYfOBezlp1Q-ydMJTMmK X-Proofpoint-ORIG-GUID: 5J0yEOjIklMrDYfOBezlp1Q-ydMJTMmK X-Authority-Analysis: v=2.4 cv=PNkP+eqC c=1 sm=1 tr=0 ts=68b95654 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=qC_FGOx9AAAA:8 a=pGLkceISAAAA:8 a=OuZLqq7tAAAA:8 a=EUspDBNiAAAA:8 a=cKVQg8D8wNGJnLBI7BwA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=fsdK_YakeE02zTmptMdW:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-04_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300019 On 9/3/25 11:23 PM, Richard Acayan wrote: > On Wed, Sep 03, 2025 at 04:39:03PM +0300, Nickolay Goppen wrote: >> From: Richard Acayan >> >> The Snapdragon 660 has a Low-Power Island (LPI) TLMM for configuring >> pins related to audio. Add the driver for this. >> Also, this driver uses predefined pin_offsets for each pin taken from >> downstream driver, which does not follow the usual 0x1000 distance >> between pins and uses an array with predefined offsets that do not >> follow any regular pattern [1]. >> >> [1] https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/LA.UM.7.2.c27-07400-sdm660.0/drivers/pinctrl/qcom/pinctrl-lpi.c#L107 >> >> Signed-off-by: Richard Acayan >> Co-developed-by: Nickolay Goppen >> Signed-off-by: Nickolay Goppen >> --- > > (snip) > >> +const struct lpi_pingroup sdm660_lpi_pinctrl_groups[] = { >> + LPI_PINGROUP_OFFSET(0, LPI_NO_SLEW, _, _, _, _, 0x0000), >> + LPI_PINGROUP_OFFSET(1, LPI_NO_SLEW, _, _, _, _, 0x1000), >> + LPI_PINGROUP_OFFSET(2, LPI_NO_SLEW, _, _, _, _, 0x2000), >> + LPI_PINGROUP_OFFSET(3, LPI_NO_SLEW, _, _, _, _, 0x2010), >> + LPI_PINGROUP_OFFSET(4, LPI_NO_SLEW, _, _, _, _, 0x3000), >> + LPI_PINGROUP_OFFSET(5, LPI_NO_SLEW, _, _, _, _, 0x3010), >> + LPI_PINGROUP_OFFSET(6, LPI_NO_SLEW, _, _, _, _, 0x4000), >> + LPI_PINGROUP_OFFSET(7, LPI_NO_SLEW, _, _, _, _, 0x4010), >> + LPI_PINGROUP_OFFSET(8, LPI_NO_SLEW, _, _, _, _, 0x5000), >> + LPI_PINGROUP_OFFSET(9, LPI_NO_SLEW, _, _, _, _, 0x5010), >> + LPI_PINGROUP_OFFSET(10, LPI_NO_SLEW, _, _, _, _, 0x5020), >> + LPI_PINGROUP_OFFSET(11, LPI_NO_SLEW, _, _, _, _, 0x5030), >> + LPI_PINGROUP_OFFSET(12, LPI_NO_SLEW, _, _, _, _, 0x6000), >> + LPI_PINGROUP_OFFSET(13, LPI_NO_SLEW, _, _, _, _, 0x6010), >> + LPI_PINGROUP_OFFSET(14, LPI_NO_SLEW, _, _, _, _, 0x7000), >> + LPI_PINGROUP_OFFSET(15, LPI_NO_SLEW, _, _, _, _, 0x7010), >> + LPI_PINGROUP_OFFSET(16, LPI_NO_SLEW, _, _, _, _, 0x5040), >> + LPI_PINGROUP_OFFSET(17, LPI_NO_SLEW, _, _, _, _, 0x5050), >> + >> + /* The function names of the PDM GPIOs are derived from SDM670 */ > > Not anymore, the names now match the other LPI drivers closer. > This can be removed. With the comment removed: Reviewed-by: Konrad Dybcio Konrad