Re: Re: Re: [PATCH 2/3] backlight/arcxcnn fix vendor prefix

[Daniel Thompson <daniel.thompson@linaro.org>]

On 21/06/2019 14:46, Daniel Thompson wrote:
> [Sorry to those receiving this twice... had to dig this out from the 
> archives and sent it to the lists from the wrong mailer]
> 
> On 27/11/2018 00:44, Brian Dodge wrote:
>> Thank you Pavel, that is a good point.
>>
>> The chip vendor has indicated that there is no reason to maintain the 
>> old/improper prefix and wishes to go forward (only) with the "arctic" 
>> prefix and any existing dts files are or will be updated.
> 
> Looks like this patch series has fallen into the cracks a little.
> 
> I think I assumed this info would end in the description of patch v2 1/3 
> (in order to answer Rob's feedback) and I sat and waited for a respin. 
> On the other hand... I didn't actually say that explicitly anywhere! 
> So... I'd recommend a respin perhaps with a small bit of text explaining 
> how the vendor can state that any existing dts files will be updated. 
> This is a peripheral device so these strings are probably embedded into 
> OEM devicetrees rather than exclusively under the control of the vendor.

In fact there's a publicly available example using this binding:
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/factory-gru-8652.B-chromeos-4.4/arch/arm64/boot/dts/rockchip/rk3399-gru-gru.dtsi

I'm not sure it could be changed without maintaining support for old names.


Daniel.


> 
> 
> Daniel.
> 
> 
>>
>> On 11/11/18 6:30 AM, Pavel Machek wrote:
>>> Hi!
>>>
>>>> The vendor-prefixes.txt file properly refers to ArcticSand
>>>> as arctic but the driver improperly abbreviated the prefix
>>>> to arc. This was a mistake in the original patch
>>>>
>>>> Signed-off-by: Brian Dodge <bdodge09@gmail.com>
>>>> ---
>>>>   drivers/video/backlight/arcxcnn_bl.c | 22 +++++++++++-----------
>>>>   1 file changed, 11 insertions(+), 11 deletions(-)
>>>>
>>>>    *
>>>> - * Copyright 2016 ArcticSand, Inc.
>>>> - * Author : Brian Dodge <bdodge@arcticsand.com>
>>>> + * Copyright 2018 pSemi, Inc.
>>>> + * Author : Brian Dodge <bdodge@psemi.com>
>>> Ummm. Copyright 2016-2018?
>>>
>>>> @@ -202,27 +202,27 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp)
>>>>       if (ret == 0)
>>>>           lp->pdata->initial_brightness = prog_val;
>>>>
>>>> -    ret = of_property_read_u32(node, "arc,led-config-0", &prog_val);
>>>> +    ret = of_property_read_u32(node, "arctic,led-config-0", 
>>>> &prog_val);
>>>>       if (ret == 0)
>>>>           lp->pdata->led_config_0 = (u8)prog_val;
>>>>
>>> If there's a dts using this, you want to update it at the same
>>> time. You may want to support both names going forward.
>>>                                     Pavel
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel