From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF119C4BA24 for ; Wed, 26 Feb 2020 20:29:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B358A24670 for ; Wed, 26 Feb 2020 20:29:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727470AbgBZU3w (ORCPT ); Wed, 26 Feb 2020 15:29:52 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:56902 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727357AbgBZU3w (ORCPT ); Wed, 26 Feb 2020 15:29:52 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 0912129576D Message-ID: Subject: Re: [PATCH v9 3/4] soc: mediatek: Move mt8173 MMSYS to platform driver From: Ezequiel Garcia To: Randy Dunlap , Enric Balletbo i Serra , robh+dt@kernel.org, mark.rutland@arm.com, ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, mturquette@baylibre.com, sboyd@kernel.org, ulrich.hecht+renesas@gmail.com, laurent.pinchart@ideasonboard.com Cc: Mauro Carvalho Chehab , dri-devel@lists.freedesktop.org, Weiyi Lu , Seiya Wang , linux-clk@vger.kernel.org, Collabora Kernel ML , mtk01761 , Allison Randal , Thomas Gleixner , wens@csie.org, Kate Stewart , Greg Kroah-Hartman , Houlong Wei , Matthias Brugger , linux-media@vger.kernel.org, devicetree@vger.kernel.org, sean.wang@mediatek.com, frank-w@public-files.de, Minghsiu Tsai , Andrew-CT Chen , linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Richard Fontana , linux-kernel@vger.kernel.org, matthias.bgg@kernel.org, Daniel Vetter Date: Wed, 26 Feb 2020 17:29:35 -0300 In-Reply-To: <54b3cfed-92f3-54c8-05a1-90ef4c057e4c@infradead.org> References: <20200226105419.632771-1-enric.balletbo@collabora.com> <20200226105419.632771-4-enric.balletbo@collabora.com> <54b3cfed-92f3-54c8-05a1-90ef4c057e4c@infradead.org> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 2020-02-26 at 07:40 -0800, Randy Dunlap wrote: > On 2/26/20 2:54 AM, Enric Balletbo i Serra wrote: > > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > > index 2114b563478c..dcd6481a14d0 100644 > > --- a/drivers/soc/mediatek/Kconfig > > +++ b/drivers/soc/mediatek/Kconfig > > @@ -44,4 +44,11 @@ config MTK_SCPSYS > > Say yes here to add support for the MediaTek SCPSYS power domain > > driver. > > > > +config MT8173_MMSYS > > + bool "MediaTek MT8173 MMSYS Support" > > Hi, > Can this be tristate instead of bool? > Wouldn't that conflict with the driver being a builtin_platform_driver, or am I just confusing things badly? Thanks, Ezequiel > + depends on COMMON_CLK_MT8173 > > + help > > + Say yes here to add support for the MediaTek MT8173 Multimedia > > + Subsystem (MMSYS). > > + > > endmenu > > thanks. > -- > ~Randy > >