From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44497C433E0 for ; Mon, 13 Jul 2020 05:22:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15F402068F for ; Mon, 13 Jul 2020 05:22:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725830AbgGMFWz (ORCPT ); Mon, 13 Jul 2020 01:22:55 -0400 Received: from smtprelay0082.hostedemail.com ([216.40.44.82]:47762 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725767AbgGMFWz (ORCPT ); Mon, 13 Jul 2020 01:22:55 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id B4B0B182240AB; Mon, 13 Jul 2020 05:22:53 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: scene76_1e0bdf926ee5 X-Filterd-Recvd-Size: 4087 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA; Mon, 13 Jul 2020 05:22:51 +0000 (UTC) Message-ID: Subject: Re: [PATCH 3/3] MAINTAINERS: Add Bruno Thomsen as reviewer of Kamstrup DTS From: Joe Perches To: Shawn Guo , Bruno Thomsen , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Rob Herring , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , bth@kamstrup.com, Mauro Carvalho Chehab Date: Sun, 12 Jul 2020 22:22:50 -0700 In-Reply-To: <20200713025559.GZ21277@dragon> References: <20200629114927.17379-1-bruno.thomsen@gmail.com> <20200629114927.17379-3-bruno.thomsen@gmail.com> <20200713025559.GZ21277@dragon> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 2020-07-13 at 10:56 +0800, Shawn Guo wrote: > On Mon, Jun 29, 2020 at 01:49:27PM +0200, Bruno Thomsen wrote: > > Add myself as reviewer of device trees for Kamstrup > > Concentrators. > > > > Signed-off-by: Bruno Thomsen > > --- > > MAINTAINERS | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 496fd4eafb68..97fc112309af 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -9282,6 +9282,11 @@ S: Maintained > > F: Documentation/hwmon/k8temp.rst > > F: drivers/hwmon/k8temp.c > > > > +KAMSTRUP CONCENTRATORS > > +R: Bruno Thomsen > > +S: Maintained > > +F: arch/arm/boot/dts/imx7d-flex-concentrator*.dts > > + > > I guess get_maintainer.pl should list you for patches touching the > files, so it's not really required? I'm worried about that MAINTAINERS > file will get bloated quickly if we patch it for every single DTS > file. Right now, a little less than half of the .dts* files have an author or other email address in them. $ git ls-files arch/arm/boot/dts/*.dts* | wc -l 2105 $ git grep -P --name-only '<\S+@\S+>' arch/arm/boot/dts/*.dts* | wc -l 997 Some have multiple email addresses: $ git grep -P '<\S+@\S+>' arch/arm/boot/dts/*.dts* | wc -l 1240 (and there are a few false positives in that regex) I suppose that get_maintainer could handle .dts* files the same way .yaml files are handled so any email address in the file is added to patches that touch the file. This is the commit that added the .yaml file handling: commit 0c78c013762142bfe8fce34e7e968f83f0a4b891 Author: Joe Perches Date: Thu Jun 4 16:50:01 2020 -0700 get_maintainer: add email addresses from .yaml files .yaml files can contain maintainer/author addresses and it seems unlikely or unnecessary that individual MAINTAINER file section entries for each .yaml file will be created. So add the email addresses found in .yaml files to the default get_maintainer output. The email addresses are marked with "(in file)" when using the "--roles" or "--rolestats" options. So something like: --- scripts/get_maintainer.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 484d2fbf5921..4c3c69d7bed0 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -436,7 +436,7 @@ sub maintainers_in_file { return if ($file =~ m@\bMAINTAINERS$@); - if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) { + if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) { open(my $f, '<', $file) or die "$P: Can't open $file: $!\n"; my $text = do { local($/) ; <$f> };