From: <mike.looijmans@topic.nl>
To: Marek Vasut <marex@denx.de>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Richard Leitner <richard.leitner@linux.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32
Date: Mon, 15 May 2023 15:17:53 +0200 [thread overview]
Message-ID: <da66656e-ddd6-99cf-41ee-d6b2d318bdff@topic.nl> (raw)
In-Reply-To: <9b62a0db-1374-2c89-5ea3-286467bd1e4e@denx.de>
See below...
Met vriendelijke groet / kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands
T: +31 (0) 499 33 69 69
E: mike.looijmans@topicproducts.com
W: www.topic.nl
Please consider the environment before printing this e-mail
On 15-05-2023 14:55, Marek Vasut wrote:
> On 5/15/23 12:33, Krzysztof Kozlowski wrote: diff --git
> a/Documentation/devicetree/bindings/usb/usb251xb.yaml
> b/Documentation/devicetree/bindings/usb/usb251xb.yaml
>> index 4d1530816817..ac5b99710332 100644
>> --- a/Documentation/devicetree/bindings/usb/usb251xb.yaml
>> +++ b/Documentation/devicetree/bindings/usb/usb251xb.yaml
>> @@ -231,7 +231,7 @@ properties:
>> power-on sequence to a port until the port has adequate power.
>> swap-dx-lanes:
>> - $ref: /schemas/types.yaml#/definitions/uint8-array
>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>> description: |
>> Specifies the ports which will swap the differential-pair
>> (D+/D-),
>> default is not-swapped.
>
> Would it make more sense to update the driver instead ? I doubt you
> could have more than 256 ports on this device after all.
I guess there's a bunch of devicetrees already out there using the
(misdocumented) 32-bit array binding, they'd break in a bad way...
--
Mike Looijmans
next prev parent reply other threads:[~2023-05-15 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 10:33 [PATCH] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32 Krzysztof Kozlowski
2023-05-15 12:55 ` Marek Vasut
2023-05-15 13:17 ` mike.looijmans [this message]
2023-05-15 13:47 ` Marek Vasut
2023-05-16 8:19 ` Krzysztof Kozlowski
2023-05-16 8:21 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da66656e-ddd6-99cf-41ee-d6b2d318bdff@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marex@denx.de \
--cc=richard.leitner@linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox