From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0242C388F7 for ; Tue, 3 Nov 2020 12:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55C5C2224E for ; Tue, 3 Nov 2020 12:31:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iXLvMN+X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726211AbgKCMbd (ORCPT ); Tue, 3 Nov 2020 07:31:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbgKCMbd (ORCPT ); Tue, 3 Nov 2020 07:31:33 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F507C0613D1 for ; Tue, 3 Nov 2020 04:31:33 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id w1so18399009wrm.4 for ; Tue, 03 Nov 2020 04:31:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=E4q0UVRWHDw6iml+4AQxHUz2AjltU3NCXpBdYF0ga1k=; b=iXLvMN+XhQHAMsuAXuGCRdjjvoIuaaf1quA0mO+SCktQa3VzZIwYhBGiEhUfIbP1Q3 mmTixznUa42MmG+ZO/uU5/onQ3JZNEW/zS0hoyMY/YGm7rPRLvxNwjB5yFChPpPut2Os 9MKiYQ0N/ABae2iLkt01R6FnSqz7GBKF4HpaF6Kg/lX2ZUnLCbi0UosL/E8x1NnJ+0jt p4lRKsZitZXJTGUfMkTcExJyTGKdCNL0SWqeuqHKxovSvFyp2bf3topBR9ep1SPtajEW z29dYz1i+YeY/TpWuDSmrehaUkhQPFGAsitqiT6TxBa76I0QeFTY8aVUP5VioCyhNldM pQ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E4q0UVRWHDw6iml+4AQxHUz2AjltU3NCXpBdYF0ga1k=; b=nfN9ZW0qHt1+K9a9RBY3K+Zc1wkEho3fCTgG+InwxF/4Hrn8kNQcvj1xlU5zTgOY3i i48yl10+0aKLXNWMVIQZv39JikK9s+yJ+NWvH5MvDS2OE6WdoeOAClqLFGmI1C4bAco7 n1MmfdC5re3ow+QqlVHYfWfaDCk4Pqhu6WEjqhREytpVjprfNC7Of5zmu86/aUtrJopL d94AqFawVNlc2cJSRadkV0sBR2Wp3UcofOLq6AfM8SyJyUDMp1+JLSMNLTuKesqwikbv W2mypobyBVG2iYR59hmu8nBGJgrkuAcf9I1wwxhw+z+IEyCsJRt1LSD87TPiP/41k4re uvBg== X-Gm-Message-State: AOAM530+b6QRZ74FD1wbkE70n7Q7jqKAD7Nm/mq9B9Qh0AteiWyENM9H lDCK9sTeEfYKIKwNRNpTL03i1gBaWeF3Aufk X-Google-Smtp-Source: ABdhPJzSPSDGa9kUi5UYxDLAC5pDt5KhWo2oU1jT26ssFfWZvBuXgFCXhFfMDz2Aox0CzBUWSkVFSw== X-Received: by 2002:a5d:5548:: with SMTP id g8mr25866831wrw.364.1604406691783; Tue, 03 Nov 2020 04:31:31 -0800 (PST) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id z5sm26202673wrw.87.2020.11.03.04.31.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Nov 2020 04:31:31 -0800 (PST) Subject: Re: [PATCH v2 5/6] ASoC: codecs: lpass-va-macro: Add support to VA Macro To: Pierre-Louis Bossart , broonie@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org References: <20201029110829.16425-1-srinivas.kandagatla@linaro.org> <20201029110829.16425-6-srinivas.kandagatla@linaro.org> <8f33aac3-7a41-1482-ae8b-e24d13ba8f13@linux.intel.com> From: Srinivas Kandagatla Message-ID: Date: Tue, 3 Nov 2020 12:31:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <8f33aac3-7a41-1482-ae8b-e24d13ba8f13@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Thanks Pierre for review, On 29/10/2020 15:56, Pierre-Louis Bossart wrote: > >> diff --git a/sound/soc/codecs/lpass-va-macro.c >> b/sound/soc/codecs/lpass-va-macro.c >> new file mode 100644 >> index 000000000000..8cb23c32631d >> --- /dev/null >> +++ b/sound/soc/codecs/lpass-va-macro.c >> @@ -0,0 +1,882 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> + > > Missing copyright information? > I will recheck this on all files and fix it before sending next version! --srini > [...] > >> +module_platform_driver(va_macro_driver); >> +MODULE_DESCRIPTION("VA macro driver"); >> +MODULE_LICENSE("GPL v2"); > > "GPL" ? The v2 adds no information. > > https://www.kernel.org/doc/html/latest/process/license-rules.html > > “GPL”    Module is licensed under GPL version 2. This does not express > any distinction between GPL-2.0-only or GPL-2.0-or-later. The exact > license information can only be determined via the license information > in the corresponding source files. > > “GPL v2”    Same as “GPL”. It exists for historic reasons.