Devicetree
 help / color / mirror / Atom feed
From: Jie Gan <jie.gan@oss.qualcomm.com>
To: monish.chunara@oss.qualcomm.com, andersson@kernel.org,
	konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	ulf.hansson@linaro.org, nitin.rawat@oss.qualcomm.com,
	pradeep.pragallapati@oss.qualcomm.com,
	komal.bajaj@oss.qualcomm.com, jsodhapa@qti.qualcomm.com
Subject: Re: [PATCH] arm64: dts: qcom: talos-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
Date: Tue, 9 Jun 2026 16:31:13 +0800	[thread overview]
Message-ID: <daa47ea3-1a80-4f95-adf4-f41eaf2bb1ab@oss.qualcomm.com> (raw)
In-Reply-To: <20260609073509.2453273-1-mchunara@oss.qualcomm.com>



On 6/9/2026 3:35 PM, monish.chunara@oss.qualcomm.com wrote:
> From: Monish Chunara <monish.chunara@oss.qualcomm.com>
> 
> SD card is detected as SDHS instead of UHS-I because sdhc_2 was
> configured with vreg_s4a as vqmmc-supply, which cannot switch
> between 1.8V and 3.3V.
> 
> Switch vqmmc-supply to vreg_l2a and update its voltage range to
> 1800000-2960000 uV to enable proper UHS-I signaling.
> 

Please add Fixes tag for a fix patch.

> Signed-off-by: Jaypal Sodhaparmar <jsodhapa@qti.qualcomm.com>

why is there a signed-off-by tag? Does it belong to the original 
author's tag? If yes, why you are the author of the posted patch.

Thanks,
Jie

> Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
> ---
>   arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 4 ++--
>   arch/arm64/boot/dts/qcom/talos-evk.dts      | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> index 294354c034c3..f70823b31391 100644
> --- a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> @@ -195,8 +195,8 @@ vreg_l1a: ldo1 {
>   
>   		vreg_l2a: ldo2 {
>   			regulator-name = "vreg_l2a";
> -			regulator-min-microvolt = <1650000>;
> -			regulator-max-microvolt = <3100000>;
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <2960000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
>   			regulator-allow-set-load;
>   			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> diff --git a/arch/arm64/boot/dts/qcom/talos-evk.dts b/arch/arm64/boot/dts/qcom/talos-evk.dts
> index b7f514fbc7b2..9ed48765ae6e 100644
> --- a/arch/arm64/boot/dts/qcom/talos-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/talos-evk.dts
> @@ -189,7 +189,7 @@ &sdhc_2 {
>   	cd-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>;
>   
>   	vmmc-supply = <&vreg_l10a>;
> -	vqmmc-supply = <&vreg_s4a>;
> +	vqmmc-supply = <&vreg_l2a>;
>   
>   	status = "okay";
>   };


  reply	other threads:[~2026-06-09  8:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09  7:35 [PATCH] arm64: dts: qcom: talos-evk: fix sdhc_2 vqmmc-supply for UHS-I mode monish.chunara
2026-06-09  8:31 ` Jie Gan [this message]
2026-06-16 12:01 ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daa47ea3-1a80-4f95-adf4-f41eaf2bb1ab@oss.qualcomm.com \
    --to=jie.gan@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jsodhapa@qti.qualcomm.com \
    --cc=komal.bajaj@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=monish.chunara@oss.qualcomm.com \
    --cc=nitin.rawat@oss.qualcomm.com \
    --cc=pradeep.pragallapati@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox