From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 3/4] hwmon: Add support for Amphenol ChipCap 2
Date: Thu, 9 Nov 2023 17:18:24 +0100 [thread overview]
Message-ID: <daae2f05-66ea-4f21-a47d-6e384bd35dee@linaro.org> (raw)
In-Reply-To: <d5692ab7-6d11-41f3-89ec-246a2fc045a8@roeck-us.net>
On 09/11/2023 15:55, Guenter Roeck wrote:
>>> + if (IS_ERR(data->hwmon)) {
>>> + ret = PTR_ERR(data->hwmon);
>>> + goto cleanup;
>>> + }
>>> +
>>> + return 0;
>>> +
>>> +cleanup:
>>> + if (cc2_disable(data))
>>> + dev_dbg(dev, "Failed to disable device");
>>> +
>>> + return dev_err_probe(dev, ret,
>>> + "Unable to register hwmon device\n");
>>
>> Drop or move to each error path.
>>
> This actually follows Documentation/process/coding-style.rst, chapter 7
> (Centralized exiting of functions).
The point is that centralized message of error is useless. Probe failure
is already handled by core, thus another message doing the same is
redundant. What is needed to explain the true reason of failure, thus
the error message should be next to each type of failure. Missing
regulator? Say it. Missing clock? Say something else.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-09 16:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 15:37 [PATCH v2 0/4] hwmon: Add support for Amphenol ChipCap 2 Javier Carrasco
2023-11-08 15:37 ` [PATCH v2 1/4] dt-bindings: vendor-prefixes: add Amphenol Javier Carrasco
2023-11-09 8:53 ` Krzysztof Kozlowski
2023-11-08 15:37 ` [PATCH v2 2/4] hwmon: (core) Add support for humidity min/max alarm Javier Carrasco
2023-11-09 0:02 ` Guenter Roeck
2023-11-09 6:24 ` Javier Carrasco
2023-11-15 13:25 ` Guenter Roeck
2023-11-15 13:56 ` Javier Carrasco
2023-11-08 15:37 ` [PATCH v2 3/4] hwmon: Add support for Amphenol ChipCap 2 Javier Carrasco
2023-11-09 8:52 ` Krzysztof Kozlowski
2023-11-09 14:55 ` Guenter Roeck
2023-11-09 15:36 ` Javier Carrasco
2023-11-09 16:18 ` Krzysztof Kozlowski [this message]
2023-11-09 16:25 ` Guenter Roeck
2023-11-08 15:37 ` [PATCH v2 4/4] dt-bindings: hwmon: Add " Javier Carrasco
2023-11-09 8:53 ` Krzysztof Kozlowski
2023-11-09 9:02 ` Javier Carrasco
2023-11-09 9:20 ` Krzysztof Kozlowski
2023-11-09 9:25 ` Javier Carrasco
2023-11-09 17:28 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daae2f05-66ea-4f21-a47d-6e384bd35dee@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).