From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05FC5C3F6B0 for ; Wed, 3 Aug 2022 07:48:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235849AbiHCHsZ (ORCPT ); Wed, 3 Aug 2022 03:48:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234370AbiHCHsY (ORCPT ); Wed, 3 Aug 2022 03:48:24 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEB7F1A07A for ; Wed, 3 Aug 2022 00:48:22 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id f20so18018932lfc.10 for ; Wed, 03 Aug 2022 00:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=naQWXtnatP1uIx9793tQXrMdRUdYtFxkHdnpkeiVoxk=; b=L/DGiGxJ0daSgKwBdyF3RxzXNufOyCdsVFi6qGXOELIBlS5cJIws0RKxA8JmAWXkro xLJ3aMvzHay9C4yhQDJEpRt77XSqkCf5PbUJzQqr9Abxlu6X865XdReOKXbnhikxDG0i eeZp9vJOf127Wt6dWmrNZZlo2oFKIIYJQ995eZ1kDR9Y4dKwz0oVXM/6IF4Nt+vhwViz Eo1kSuKGGYdjWwB8qATV6MYYAzxlhwaWFQ4Yko72wDkxeQ38GJdrejJ3lZBibflxZOf5 LFquxzorZrfiIIyPEHFPExDVnaRQFtqkSSnEfmh0Ko2gHq13Dlhd2hpwcbvycnoyP3eS +2nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=naQWXtnatP1uIx9793tQXrMdRUdYtFxkHdnpkeiVoxk=; b=ZKHUfQ8e9BZ5BBxWFVUhMKblpJEuxE8eL4gC3qMYa7mZ1pNmJ2N7xA3CKtHUhpVvtW HYCPOIfwvxm+a3o8dqyAfrPr9Yra9wfNWIfmkavXRmoicrE4HDwG2LF6S3XIlsDeE6Nb mFePwBLfEV/5WfpJZqxfIh0v4uuFac0bAdUnGl4+A/KZ4/FjsTGIBB6WOZEUgUKABtMi x0FPUJs7eBEjkAAFdFAeIaMkle2xy2Rd389p/g/HQrIcdXdqNGOOkEWTDG+BupesVCAn pjKJuJOGyjMb64cktUa9uezYWLkp5w6RzrQFN4ak9RLY2sAfpJSe6s8EhKcB1m5WNRct Y4Pw== X-Gm-Message-State: AJIora90yP8Ul8MdhiOxm5NXHbrat/7QTPX8AF+zCnSH34oeT+yBUkku 2SUVyJBGVkri6UaOArgkpZGfrA== X-Google-Smtp-Source: AGRyM1t/ppcl0v01ORP/WV9e1oXDN1ERgXE1IHJZkeBiD+mqElAfO61Ag9deMVZ1tOqFI7ZVWb7eug== X-Received: by 2002:a19:e007:0:b0:481:c74:37b7 with SMTP id x7-20020a19e007000000b004810c7437b7mr8607075lfg.439.1659512901288; Wed, 03 Aug 2022 00:48:21 -0700 (PDT) Received: from [192.168.1.6] ([77.222.167.48]) by smtp.gmail.com with ESMTPSA id y17-20020a2e3211000000b0025e4e7c016dsm1026745ljy.16.2022.08.03.00.48.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Aug 2022 00:48:20 -0700 (PDT) Message-ID: Date: Wed, 3 Aug 2022 09:48:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/2] spi: dt-binding: add Microchip CoreQSPI compatible Content-Language: en-US To: naga sureshkumar Cc: Mark Brown , Naga Sureshkumar Relli , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor.dooley@microchip.com, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220801094255.664548-1-nagasuresh.relli@microchip.com> <20220801094255.664548-2-nagasuresh.relli@microchip.com> <6d36b192-9e63-ec13-5583-22b81c99c18b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/08/2022 08:59, naga sureshkumar wrote: > Hi Krzysztof, > > On Wed, Aug 3, 2022 at 11:42 AM Krzysztof Kozlowski > wrote: >> >> On 02/08/2022 15:13, Mark Brown wrote: >>> On Tue, Aug 02, 2022 at 10:52:25AM +0200, Krzysztof Kozlowski wrote: >>>> On 01/08/2022 11:42, Naga Sureshkumar Relli wrote: >>> >>>>> - enum: >>>>> - - microchip,mpfs-spi >>>>> - - microchip,mpfs-qspi >>>>> + oneOf: >>>>> + - description: Microchip's Polarfire SoC SPI controller. >>>>> + const: microchip,mpfs-spi >>>>> + - description: Microchip's Polarfire SoC QSPI controller. >>> >>>> Useless descriptions - they repeat compatible. Just keep it as enum and >>>> skip descriptions. What value do they bring? >>> >>> Someone not familiar with the full Microchip product line might not be >>> aware of the expansion of mpfs, it's not blindingly obvious. >> >> Then it should be explained in title/description of the binding, not in >> compatible. This is the usual way of providing some text description, >> not for each compatible by repeating the compatible text. > Ok. In the next version I will update the bindings like below > > -title: Microchip MPFS {Q,}SPI Controller Device Tree Bindings > +title: Microchip FPGA {Q,}SPI Controllers > + > +description: > + SPI and QSPI controllers on the Microchip PolarFire SoC and they are based > + on the "soft" fabric IP cores. > oneOf: > - items: > + - const: microchip,mpfs-qspi > + - const: microchip,coreqspi-rtl-v2 This piece should have its own explanation and preferably in its own commit. As I mentioned before, you change existing compatible so it should be explained. Best regards, Krzysztof