From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Xu Yang <xu.yang_2@nxp.com>,
Peng Fan <peng.fan@nxp.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com>,
s32@nxp.com, linaro-s32@linaro.org,
Larisa Grigore <larisa.grigore@nxp.com>,
Ionut Vicovan <Ionut.Vicovan@nxp.com>
Subject: Re: [PATCH 1/4] dt-bindings: usb: Add compatible strings for s32g2/s32g3
Date: Thu, 29 May 2025 11:32:04 +0200 [thread overview]
Message-ID: <dad12b2d-3c5d-4106-bec6-1aeaec72288a@kernel.org> (raw)
In-Reply-To: <2a4317353557e4fac2a7bfa4261a75886eebe41b.1748453565.git.dan.carpenter@linaro.org>
On 28/05/2025 21:57, Dan Carpenter wrote:
> From: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com>
>
> Add the compatible strings for the NXP s32g2 and s32g3.
Why these are not compatible? Explain the hardware in the commit msg.
Your driver, although you did not Cc me on it, suggests they are
compatible. Anyway you have entire commit msg to explain unusual things.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-05-29 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 19:57 [PATCH 0/4] usb: chipidea: Add support for s32g2 and s32g3 Dan Carpenter
2025-05-28 19:57 ` [PATCH 1/4] dt-bindings: usb: Add compatible strings for s32g2/s32g3 Dan Carpenter
2025-05-28 21:22 ` Frank Li
2025-06-02 5:49 ` Dan Carpenter
2025-05-29 9:32 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dad12b2d-3c5d-4106-bec6-1aeaec72288a@kernel.org \
--to=krzk@kernel.org \
--cc=Ionut.Vicovan@nxp.com \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ghennadi.procopciuc@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=larisa.grigore@nxp.com \
--cc=linaro-s32@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).