From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus. Date: Sat, 2 Sep 2017 09:25:33 -0700 Message-ID: References: <20170831185416.8181-1-eric@anholt.net> <3a947d06-53cc-bb28-86de-0ddb5c6b853c@broadcom.com> <2e66788a-228a-b32d-eb31-24fab776ee21@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Scott Branden , Florian Fainelli Cc: Mark Rutland , Ray Jui , Rob Herring , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stefan Wahren , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Eric Anholt , Jon Mason , Scott Branden , linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org On 09/02/2017 08:48 AM, Scott Branden wrote: > Looks good > > On Sep 1, 2017 7:10 PM, "Florian Fainelli" > wrote: > > > > On 08/31/2017 01:16 PM, Scott Branden wrote: > > Hi Eric, > > > > mode is correct, location in file needs to be moved. > > > > > > On 17-08-31 11:54 AM, Eric Anholt wrote: > >> This doesn't yet enable it on any particular platform, as we still > >> need a panel driver for bcm911360_entphn. > >> > >> Signed-off-by: Eric Anholt > > >> --- > >> > >> These bits are just carving off a little bit of my 911360_entphn > panel > >> series, to reduce conflicts when rebasing (which I just did for > >> testing pl111 changes for cygnus regressions). I'm waiting to get my > >> current RPi panel driver in before working on the 911360 panel again. > >> > >> arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi > >> b/arch/arm/boot/dts/bcm-cygnus.dtsi > >> index 7c957ea06c66..74f73ff24aec 100644 > >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi > >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi > >> @@ -575,6 +575,16 @@ > >> status = "disabled"; > >> }; > >> + clcd: clcd@180a0000 { > > please place in correct address ordered location in file > > I moved it right above the v3d node to keep the nodes ordered by unit > address, please check the result here: > > https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75 > > > > With Moved location > Acked-by: Scott Branden > Pushed in place with your tag added, thanks! -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html