From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7C6E15667B for ; Mon, 15 Apr 2024 19:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713210758; cv=none; b=Tx1nV4mT8CRqVxZJt6NkQoLV+WKjLcFmHsoQ/yP4mpvLr0iRCHDHxmNuBdX+lA4azQk3/RgcjbN5o03xmwdbidJdx8m8ZcWIpb1cIaXA+KoJh8Jxhp6gUNNnjvcAV+JJA4NqGDL5RtJtK3C0BGu/DeLDtvgn5xwKGw3Vf17xEx8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713210758; c=relaxed/simple; bh=J7nXo825g2LLNHOTbM+8C1BAkdGVZo0J2e5tsXt1TPc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KcIOqFyHUj0tdZJ7TqyaGNI3kWlyehSThJd+PGX2W8ObvGxOQMgvgxcvo9Lx7Rp+8fGGecYtzP7JawCQ16dkBqPXX2Uzd7xUex+/YN2vY0mYsHcQ13RgDHBlGIee+df/vTZWdpHCIUvYehR+UG3AGj5blCirFgZ2escB0xKGIsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Rse/ptI2; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Rse/ptI2" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-516d3776334so4706107e87.1 for ; Mon, 15 Apr 2024 12:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713210754; x=1713815554; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YEXHGjxAhZs0bYA15G3//QkZWLtdxl3JXDF1n5TYCXc=; b=Rse/ptI2iG5kSiBOBjsvbH+IiHbN8uzilAGB9aGfs/g2t2M1hVa2jm+4AchE+VS24O 7saRVuIKM4gxiJNhZlhiNVAd/kcwk4/KuYtfpm7ll6sRtLmebQncyA+dCYo90vX5l6J1 mmqTv2OS0bBRkMWiuBfAd5IxRNwZ7dpICBxrP+0Qse6ChEuhNlu7ceUGl3iTKqMV2LkD 4EaZnTqX9nkiCT8e64IQkfajcdL858jSsTQSqA6CwQAfZdPv1dw85QRDKaDSj6KHMPTK 28eJBIzjGUIOTYFD6//Be0VDNpcHYT4AvXHNv+FNacIolEoqzrETrZVfsaFhL4KjxwWX 7M+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713210754; x=1713815554; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YEXHGjxAhZs0bYA15G3//QkZWLtdxl3JXDF1n5TYCXc=; b=cAML3DVa+NxIS3xXbm0G31dM4C7pNyWcmDF6V4vDydkToYC9aZRgqq8G3NikhDwtg3 3ZG22l476W7RLonkcEZeLqolpC2wPi6w4jUBLpFlS6jeRDscr73Su+BXSwzY5+vNRmcV i70b+bO63xXXMstOjkWa2c0fCryrLDAWEU4UEen2UXHzolZAwjEn2pHdNUz3ckIL7phm xsAxxCfqW3zE17h+akhAVZyKnYmprZAqktywcV8jn+hpi+B9dyc1q6d1ttH/6IlMhN6z Wqk08x+lPOyNYITr38I7Y5khnYfUJa80rkIn10YtZ+WzBgbpaCLKaH8mjzbPPCfa2+d6 3xIQ== X-Forwarded-Encrypted: i=1; AJvYcCUXjAPRw17cqFYd6Z0yTlHAsVg2ddXkwU3CM/7nZmutf9YpWyY2uXQiLcAt5mqoqR3uEo4MPIcH282shdPlx6ZLsY3S/ch+mwc0YA== X-Gm-Message-State: AOJu0YxblVCh/qUNDYbru2Jm+UOHSTOUVFMVgIn10MvknSsjO9R+u1RO LD5MOcsZXYyjgJcO/dkWdr51vDe8fItIwo2hEGmNY33C7Yz2VNlz22q9H/cYXqI= X-Google-Smtp-Source: AGHT+IEal04PxHzEYGFi8jHEhHfii3wvIFaJa5SsgptPYcD/6a7aBein+xl+JbCkDBh8KNrg33Rtug== X-Received: by 2002:a05:6512:b92:b0:518:872f:e4d with SMTP id b18-20020a0565120b9200b00518872f0e4dmr9145171lfv.15.1713210753936; Mon, 15 Apr 2024 12:52:33 -0700 (PDT) Received: from [172.30.205.18] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id j5-20020ac25505000000b00517374e92ecsm1339725lfk.93.2024.04.15.12.52.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 12:52:33 -0700 (PDT) Message-ID: Date: Mon, 15 Apr 2024 21:52:32 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 4/4] input: pm8xxx-vibrator: add new SPMI vibrator support To: quic_fenglinw@quicinc.com, kernel@quicinc.com, Andy Gross , Bjorn Andersson , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20240412-pm8xxx-vibrator-new-design-v10-0-0ec0ad133866@quicinc.com> <20240412-pm8xxx-vibrator-new-design-v10-4-0ec0ad133866@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240412-pm8xxx-vibrator-new-design-v10-4-0ec0ad133866@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/12/24 14:36, Fenglin Wu via B4 Relay wrote: > From: Fenglin Wu > > Add support for a new SPMI vibrator module which is very similar > to the vibrator module inside PM8916 but has a finer drive voltage > step and different output voltage range, its drive level control > is expanded across 2 registers. The vibrator module can be found > in following Qualcomm PMICs: PMI632, PM7250B, PM7325B, PM7550BA. > > Signed-off-by: Fenglin Wu > --- [...] > > + if (regs->drv2_mask) { > + if (on) > + val = (vib->level << regs->drv2_shift) & regs->drv2_mask; The point of regmap_foo_bits is that you no longer need to mask the value here. > + else > + val = 0; > + You can also save some LoC without compromising on legibility: if (regs->drv2_mask) { val = vib->level << regs->drv2_shift; rc = regmap_write_bits(vib->regmap, vib->drv2_addr, regs->drv2_mask, on ? val : 0) if (rc < 0) return rc; } Konrad