From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57FA6135414 for ; Tue, 23 Apr 2024 13:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713878450; cv=none; b=MNEkr3S0BkhOlqdPnZLmw1vovyVFNyC5Gk+2xGTBH+zE1AGAtuTQFg9oBmbxUwXgtQGUv1nQWWtEJp5ENJnYANtm6bWYG4/Pfi1aQjOKLx2BrA4K4bOrcWZnspng8MTf2FmNbNM8ykffUcK1Q4eH3mQw/gOR4rlf3C8GQDwR23Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713878450; c=relaxed/simple; bh=PyHVWu/QKobiB7YcY+QCE35Yaf73xdFPKB4nRj1oqY0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L6FCYqurqaVTEItn4JuBHdrPxpmjc0+GXdtDadU9xDsjcwCErow2cyp+ePEz3bWrqhS1Fi2rAUTXL1CxVYZ7R6zSxOczf4/01ylc7xg/qROFs19WHMzNHvGxfZwpejF1Qq23RA4R0MxB/PMmhZNkQu7vrwF3MhWZ7BFLDL5V3aM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gt5fwD7M; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gt5fwD7M" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-51aa6a8e49aso6177649e87.3 for ; Tue, 23 Apr 2024 06:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713878446; x=1714483246; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DED8QC5Anhet7tIP2I7t7ZJzQkPh1lym+QGOcE4oVis=; b=gt5fwD7Mlq1+zrSVgUkng27451HLB37gSj24JpXjE50zj80BhlZYM+Xk+SaZVFH2/u nSRAfGjNFUYo+I0AlrbC3ie88Rk49JCPUC4qMoSa8WkPGVEnOIjR5R6A+fVNX4RLeQEh g+rTAKxJac1cUCxfUXRMfTkHOyP7jq9DUjlsd+2sHNRogjjhVnfWfVVuYoVQW9hgyED4 oeBBU6io+ITYilF0kuzl7GW1AebTQHqAFYM/1SB3Qj4qXe/bhy8285pCvKwJBnjEi7l0 cCeo0j2FI4n4DgXf7ijZpDiWcLbHHjHKexX7GHgGalcQ70SFlLjn510JJqzPSUtFMKWt G8Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713878446; x=1714483246; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DED8QC5Anhet7tIP2I7t7ZJzQkPh1lym+QGOcE4oVis=; b=AG1POlRbp2fm65/zgMWhq9hZZ2Wb9kna5Glrh7fp5WkeXUQH3QZvEI6GRSPdNA5k9e Zumd4NwBHMBYuXT0C2uqdmiQMeRTUV67n6WOUwWGOjcwqReb4Wy2n9vxWN8b/gPQO3Xg pEplu47XlqZZ0M/SzCDMbruEoyWgW3OMIfU3WMXHsc4Nb1WMgFRoR+V8A8hKIRwNvX8J KT3xWhFgxw/Z0eVzXm+0Y92afFD6Q7Pd7mVjFmcN0ZK+QRwjvP3cmjACSQfnVIk6EAE8 xbqV6LpVdGSl1WCWC9TeqA51rl1qXFbSgnHkejiAHLvIWul0bxzzRwBD2nXhM5TWy1bM unGg== X-Forwarded-Encrypted: i=1; AJvYcCURtklw8UacCa74/ZcidDgePmnm11r63k6oGoRe5j6bvh5epMWnuxaZqze7Y+1HVx3Dsum+KUQgK0vXIZE2QFeYxDgiCwCIRt2xKA== X-Gm-Message-State: AOJu0YxCNYw63qHdHGJqeQTzePvLWNAq9GIl4ZlLbW9Y57GIqoEWXYJG m4n6DqKyx4EAp97aXpZKx7YJ0LvQOgvyhez98y+lo/lW8SlZ0S8mbWVO4vWsVeI= X-Google-Smtp-Source: AGHT+IG6cO+5w21y5KWS+7cigDuEMe7L7tENMjk6qzTUeOwWkVVsMZ63pHbVyU4/AorYlwfX5JUOfg== X-Received: by 2002:a05:6512:48c9:b0:519:7585:9f66 with SMTP id er9-20020a05651248c900b0051975859f66mr8028391lfb.50.1713878446012; Tue, 23 Apr 2024 06:20:46 -0700 (PDT) Received: from [172.30.205.0] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id u12-20020a05651206cc00b00516c5954d61sm2012461lff.246.2024.04.23.06.20.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 06:20:45 -0700 (PDT) Message-ID: Date: Tue, 23 Apr 2024 15:20:44 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: Add initial support for rb5gen2 board To: Wasim Nazir , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: <20240313071238.3290-1-quic_wasimn@quicinc.com> <20240313071238.3290-4-quic_wasimn@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240313071238.3290-4-quic_wasimn@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/13/24 08:12, Wasim Nazir wrote: > RB5gen2 is based on QCS8550-Rb5gen2 SOM for IOT solutions. > This initial version describes VPH_PWR, UART & USB3.1(HS). > > On-board PMICs: > - PMR735D > - PM8010 > > Signed-off-by: Wasim Nazir > Where's the "---"? :thinking: [...] > +&apps_rsc { > + regulators-0 { This does not scale. Use &label references instead > + vdd-bob1-supply = <&vph_pwr>; > + vdd-bob2-supply = <&vph_pwr>; > + }; > + > + regulators-2 { > + vdd-s4-supply = <&vph_pwr>; > + vdd-s5-supply = <&vph_pwr>; > + }; > + > + regulators-3 { > + vdd-s1-supply = <&vph_pwr>; > + vdd-s3-supply = <&vph_pwr>; > + vdd-s4-supply = <&vph_pwr>; > + vdd-s5-supply = <&vph_pwr>; > + vdd-s6-supply = <&vph_pwr>; > + }; > + > + regulators-4 { > + vdd-s1-supply = <&vph_pwr>; > + vdd-s3-supply = <&vph_pwr>; > + vdd-s4-supply = <&vph_pwr>; > + vdd-s5-supply = <&vph_pwr>; > + vdd-s7-supply = <&vph_pwr>; > + }; > + > + regulators-5 { > + vdd-s1-supply = <&vph_pwr>; > + vdd-s2-supply = <&vph_pwr>; > + vdd-s3-supply = <&vph_pwr>; > + vdd-s4-supply = <&vph_pwr>; > + vdd-s5-supply = <&vph_pwr>; > + vdd-s6-supply = <&vph_pwr>; > + }; > +}; > + > +&pm8550b_eusb2_repeater { > + vdd18-supply = <&vreg_l15b_1p8>; > + vdd3-supply = <&vreg_l5b_3p1>; > +}; Would that not be SoM-common too? Konrad