Re: [PATCH v15 0/3] Add support for the Purism Librem5 devkit

[Angus Ainslie <angus@akkea.ca>]

On 2019-06-05 03:03, Shawn Guo wrote:
> On Tue, May 28, 2019 at 05:57:44AM -0700, Angus Ainslie (Purism) wrote:
>> The Librem5 devkit is based on the imx8mq from NXP. This is a default
>> devicetree to boot the board to a command prompt.
>> 
>> Changes since v14:
>> 
>> Add regulator-always-on for the SNVS regulators.
>> Added pgc nodes.
>> Fixed charger pre-current.
> 
> Since Pavel was reviewing your patches, you should copy him on the new
> version.  Has this version addressed all his review comments?
> 

Sorry I had meant to include him in the CC.

I believe so but don't want to speak for him so we should see if he has 
anymore.

Angus

> Shawn
> 
>> 
>> Changes since v13:
>> 
>> Moved haptic motor from pwm-led to gpio-vibrator.
>> Cleaned up regulator node naming.
>> Whitescpace cleanup.
>> Re-indent pinmux stanzas.
>> Drop pwm2 node.
>> Drop MAINTAINERS patch.
>> 
>> Changes since v12:
>> 
>> Updated patch to vendor-prefixes.yaml.
>> Dropped always on from regulators.
>> 
>> Changes since v11:
>> 
>> Added reviewed-by tags.
>> Fixed subject typo.
>> 
>> Changes since v10:
>> 
>> Moved MAINTAINERS entry to "ARM/FREESCALE IMX" section
>> 
>> Changes since v9:
>> 
>> Added a MAINTAINERS entry for arm64 imx devicetree files.
>> 
>> Changes since v8:
>> 
>> Fixed license comment.
>> Changed regulators to all lower case.
>> Changed clock frequency for NXP errata e7805.
>> Dropped blank line.
>> 
>> Changes since v7:
>> 
>> More regulators always on for USB.
>> Add vbus regulator.
>> Drop vbat regulator.
>> Replace legacy "gpio-key,wakeup" with "wakeup-source".
>> Add vbus-supply to get rid of warning
>> imx8mq-usb-phy 382f0040.usb-phy: 382f0040.usb-phy supply vbus not 
>> found,
>> using dummy regulator
>> 
>> Changes since v6:
>> 
>> Dropped unused regulators.
>> Fix regulator phandles case.
>> Dropped extra whitespace.
>> 
>> Changes since v5:
>> 
>> Added reviewed-by tags.
>> Moved USB port links to USB controller node.
>> 
>> Changes since v4:
>> 
>> Compiled against linux-next next-20190415.
>> Added imx8mq to the arm yaml file.
>> Re-arrange regulator nodes to drop undefined supplies.
>> Additional ordering for aesthetics.
>> Split some long lines.
>> Added lots of blank lines.
>> Moved pinctl muxes to where they are used.
>> Cleaned out reg defintions from regulator nodes.
>> 
>> Changes since v3:
>> 
>> Freshly sorted and pressed nodes.
>> Change the backlight to an interpolated scale.
>> Dropped i2c2.
>> Dropped devkit version number to match debian MR.
>> 
>> Changes since v2:
>> 
>> Fixed incorrect phy-supply for the fsl-fec.
>> Dropped unused regulator property.
>> Fixup Makefile for linux-next.
>> 
>> Changes since v1:
>> 
>> Dropped config file.
>> Updated the board compatible label.
>> Changed node names to follow naming conventions.
>> Added a more complete regulator hierachy.
>> Removed unused nodes.
>> Removed unknown devices.
>> Fixed comment style.
>> Dropped undocumented properties.
>> 
>> Angus Ainslie (Purism) (3):
>>   arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit
>>   dt-bindings: Add an entry for Purism SPC
>>   dt-bindings: arm: fsl: Add the imx8mq boards
>> 
>>  .../devicetree/bindings/arm/fsl.yaml          |   7 +
>>  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>>  .../dts/freescale/imx8mq-librem5-devkit.dts   | 806 
>> ++++++++++++++++++
>>  4 files changed, 816 insertions(+)
>>  create mode 100644 
>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>> 
>> --
>> 2.17.1
>>