devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artur Rojek <contact@artur-rojek.eu>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org,
	robh+dt@kernel.org, dmitry.torokhov@gmail.com,
	maccraft123mc@gmail.com, Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: adc-joystick: bindings for adc-joystick-polled
Date: Wed, 01 Jun 2022 21:44:43 +0200	[thread overview]
Message-ID: <db2795c639cc092e54980de6f3af3b01@artur-rojek.eu> (raw)
In-Reply-To: <20220601191730.29721-2-macroalpha82@gmail.com>

On 2022-06-01 21:17, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>

Hi Chris,

> 
> Add devicetree bindings for adc-joystick-polled.
> 
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  Documentation/devicetree/bindings/input/adc-joystick.yaml | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml
> b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> index 2ee04e03bc22..a9d2ac157322 100644
> --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
> +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> @@ -12,11 +12,15 @@ maintainers:
> 
>  description: >
>    Bindings for joystick devices connected to ADC controllers 
> supporting
> -  the Industrial I/O subsystem.
> +  the Industrial I/O subsystem. Supports both polled devices where no
> +  iio trigger is available and non-polled devices which are triggered
> +  by iio.
> 
>  properties:
>    compatible:
> -    const: adc-joystick
> +    enum:
> +      - adc-joystick
> +      - adc-joystick-polled

There is no need to create a new compatible for your functionality. 
Instead, just add a new (optional) property.

cheers,
Artur

> 
>    io-channels:
>      minItems: 1

  reply	other threads:[~2022-06-01 20:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01 19:17 [PATCH 0/3] adc-joystick: Add polled support Chris Morgan
2022-06-01 19:17 ` [PATCH 1/3] dt-bindings: adc-joystick: bindings for adc-joystick-polled Chris Morgan
2022-06-01 19:44   ` Artur Rojek [this message]
2022-06-05 22:36     ` Rob Herring
2022-06-01 19:17 ` [PATCH 2/3] Input: adc-joystick - Add polled input device support Chris Morgan
2022-06-01 19:57   ` Artur Rojek
2022-06-01 19:17 ` [PATCH 3/3] arm64: dts: rockchip: Update joystick to polled for Odroid-Go2 Chris Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db2795c639cc092e54980de6f3af3b01@artur-rojek.eu \
    --to=contact@artur-rojek.eu \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=heiko@sntech.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=maccraft123mc@gmail.com \
    --cc=macroalpha82@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).