From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F05C2D0E2 for ; Tue, 22 Sep 2020 22:56:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B631D221EB for ; Tue, 22 Sep 2020 22:56:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="FoFkQylU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbgIVW4N (ORCPT ); Tue, 22 Sep 2020 18:56:13 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:48984 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbgIVW4N (ORCPT ); Tue, 22 Sep 2020 18:56:13 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08MMuAGw122085; Tue, 22 Sep 2020 17:56:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1600815370; bh=DwUK73G8fRoTDbjxGcRj64g70ISqbTcwXOgh0vcYjc0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=FoFkQylUX/EEbpzJ/jXF2GKdIog1cxtopal3bkBP2EmkrnXW8eEhQl16uIckRUW8E Rh4qw3hRWgQCOXU0XZm3Z4rLyQIOpNIthBS2+a57OWefu0RbLGrz+8mrDwPP9ofIdS Ra82ZB2HS8qUpjkTo1gs4PHDQZTa93kmEouj1vB8= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08MMuAW0069255 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 22 Sep 2020 17:56:10 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 22 Sep 2020 17:56:10 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 22 Sep 2020 17:56:10 -0500 Received: from [10.250.32.225] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08MMuA9L070124; Tue, 22 Sep 2020 17:56:10 -0500 Subject: Re: [EXTERNAL] Re: [PATCH v3 1/2] dt-bindings: power: Add the bq256xx dt bindings To: Rob Herring CC: , , , , References: <20200910164534.16987-1-r-rivera-matos@ti.com> <20200910164534.16987-2-r-rivera-matos@ti.com> <20200922222203.GA3360459@bogus> From: Ricardo Rivera-Matos Message-ID: Date: Tue, 22 Sep 2020 17:56:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200922222203.GA3360459@bogus> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Rob On 9/22/20 5:22 PM, Rob Herring wrote: > On Thu, Sep 10, 2020 at 11:45:33AM -0500, Ricardo Rivera-Matos wrote: >> Add the bindings for the bq256xx series of battery charging ICs. >> >> Datasheets: >> - https://www.ti.com/lit/ds/symlink/bq25600.pdf >> - https://www.ti.com/lit/ds/symlink/bq25601.pdf >> - https://www.ti.com/lit/ds/symlink/bq25600d.pdf >> - https://www.ti.com/lit/ds/symlink/bq25601d.pdf >> - https://www.ti.com/lit/ds/symlink/bq25611d.pdf >> - https://www.ti.com/lit/ds/symlink/bq25618.pdf >> - https://www.ti.com/lit/ds/symlink/bq25619.pdf >> >> Signed-off-by: Ricardo Rivera-Matos >> --- >> .../bindings/power/supply/bq256xx.yaml | 97 +++++++++++++++++++ >> 1 file changed, 97 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/supply/bq256xx.yaml >> >> diff --git a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml >> new file mode 100644 >> index 000000000000..8cc2242f7df0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml >> @@ -0,0 +1,97 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >> +# Copyright (C) 2020 Texas Instruments Incorporated >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/power/supply/bq256xx.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: TI bq256xx Switch Mode Buck Charger >> + >> +maintainers: >> + - Ricardo Rivera-Matos >> + >> +description: | >> + The bq256xx devices are a family of highly-integrated battery charge >> + management and system power management ICs for single cell Li-ion and Li- >> + polymer batteries. >> + >> + Datasheets: >> + - https://www.ti.com/lit/ds/symlink/bq25600.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25601.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25600d.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25601d.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25611d.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25618.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25619.pdf >> + >> +properties: >> + compatible: >> + enum: >> + - ti,bq25600 >> + - ti,bq25601 >> + - ti,bq25600d >> + - ti,bq25601d >> + - ti,bq25611d >> + - ti,bq25618 >> + - ti,bq25619 >> + >> + reg: >> + maxItems: 1 >> + >> + ti,watchdog-timer: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: | >> + Watchdog timer in ms. 0 (default) disables the watchdog >> + minimum: 0 >> + maximum: 160000 >> + enum: [ 0, 40000, 80000, 160000] >> + >> + input-voltage-limit-microvolt: >> + description: | >> + Minimum input voltage limit in µV with a 100000 µV step >> + minimum: 3900000 >> + maximum: 5400000 >> + >> + input-current-limit-microamp: >> + description: | >> + Maximum input current limit in µA with a 100000 µA step >> + minimum: 100000 >> + maximum: 3200000 >> + >> +required: >> + - compatible >> + - reg >> + - monitored-battery > additionalProperties: false > > And then fix what breaks in the example. ACK. I will document the monitored-battery and interrupts properties and fix the example. Is ti,watchdog-timer okay as it is currently documented? > >> + >> +examples: >> + - | >> + bat: battery { >> + compatible = "simple-battery"; >> + constant-charge-current-max-microamp = <2040000>; >> + constant-charge-voltage-max-microvolt = <4352000>; >> + precharge-current-microamp = <180000>; >> + charge-term-current-microamp = <180000>; >> + }; >> + #include >> + #include >> + i2c { >> + >> + clock-frequency = <400000>; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + charger@6b { >> + compatible = "ti,bq25601"; >> + reg = <0x6b>; >> + monitored-battery = <&bat>; >> + >> + interrupt-parent = <&gpio1>; >> + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; >> + watchdog-timer = <40000>; >> + >> + input-voltage-limit-microvolt = <4500000>; >> + input-current-limit-microamp = <2400000>; >> + }; >> + }; >> +... >> -- >> 2.28.0 >> Ricardo