From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Satya Priya <quic_c_skakit@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@somainline.org>,
Stephen Boyd <swboyd@chromium.org>,
Taniya Das <tdas@codeaurora.org>,
mka@chromium.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Taniya Das <quic_tdas@quicinc.com>
Subject: Re: [PATCH V2] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets
Date: Tue, 12 Jul 2022 23:02:46 +0200 [thread overview]
Message-ID: <db31ded1-d240-e5a0-c4ec-03ad7aef6af8@linaro.org> (raw)
In-Reply-To: <1657181739-32052-1-git-send-email-quic_c_skakit@quicinc.com>
On 07/07/2022 10:15, Satya Priya wrote:
> From: Taniya Das <quic_tdas@quicinc.com>
>
> The lpass audio supports TX/RX/WSA block resets. Disable the LPASS PIL
> clock by default, boards can enable it if needed.
You made here few different changes at once but I fail to see why. The
most important message in commit msg is "why?". Why are you disabling
LPASS PIL by default?
>
> Also to keep consistency update lpasscore to lpass_core.
This definitely should not be backported to stable.
>
> Fixes: 9499240d15f2 ("arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers")
This does not look right or I did not understand where the bug is.
Please describe what is the error/issue/bug being fixed (which would
explain the need of backporting).
More over, the patch alone brings regression - disables the LPASS PIL
while before it was enabled. For sure it should not be backported.
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> ---
> Changes since V1:
> - Updated the phandle reference in lpass_aon node.
> - As per Matthias' comment updated the commit text.
>
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Best regards,
Krzysztof
prev parent reply other threads:[~2022-07-12 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 8:15 [PATCH V2] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets Satya Priya
2022-07-12 21:02 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db31ded1-d240-e5a0-c4ec-03ad7aef6af8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_c_skakit@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).