From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA1E333436F for ; Tue, 18 Nov 2025 10:16:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763460993; cv=none; b=uIYaO6gCiCOl2yIYCpjV00d6j+e6CH8XvddWiFQ9PP937o3UO2sqhtO+75578m+RKA9b8UPg2N6fcd2QHjKRmHdJlxXXeYE+hcm0goYS9lJSwONSd4v7jAiOvdOlGe2I+2H1o8kGNkDob+EXXwaia6LB9momI2tO0/DJKVOZhOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763460993; c=relaxed/simple; bh=E00n/v+h0Xh+w/Iu/WlHYR5e1efkTZXllPx+KiMyUvI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FgOiqHgtUKcCXiO7OF/Ct2LKEXBFJ+tFNT3unmToCE0H+j3+lyuSt7Rk9Uw+hd5gkPwrpo5QYPsv7UzrgInPMuo7w9Lrms1h1W4sBx+JcrUf96ALZuD00ef/lpCoxwbcqOrmGcz/Y5i8yd/FPzZDBaatYcMZuS74LEDcqMJrAvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HS83WNDs; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HS83WNDs" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-298039e00c2so67457725ad.3 for ; Tue, 18 Nov 2025 02:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763460987; x=1764065787; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zdI4xNDb+qTUth8t1rfCsM2zzQp9c++Fo8uBCDAFxXI=; b=HS83WNDsGHocddW1FWv7pJR8HkiKO0MYkhyPKZevMy7WNuJVMP1Sf40nw6WMpvRm14 Eu5SZEtx7BjuXXDxZJChnpmvENg8jZy0LeUdAV2/8BnGaOlR9Fwtek3sPk03SdLUwA72 8fXj3ofpemkDEGG5/ZlOgkNZSjfVDbem22xhHtOfB4rM2LXx0fHX1Yu81CJMscPpxwVh FUTjX5A9IcZ1z82M7mIRxsEv7wlnq9Xmi5xxHRAC4DhQ5enskf7lj0S6shiePSczDY0E UuDcy/uXTLlptS4k7d4Jzgcrw9UGhN/HaDKBluXdGfc6/vNyQlTTjb42VpYa31vdVn/C ZZCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763460987; x=1764065787; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zdI4xNDb+qTUth8t1rfCsM2zzQp9c++Fo8uBCDAFxXI=; b=E7n0loNxFFwPFSmG6XKbqwAycm2AsbjREHuw/PdZxzxPkrIRmw9EGkGhNAq9I2VyQZ ZG41cn2pUB1TMvdmTE50sJC336ScxaT99nzNGfjm2DNCcwz0ZgEp3ZVO20f2GuKEFY/n Ukr+12THdJcIfo79aTPZAyCWr8wApPYjRgYfOErAv70hYpxfnm1dn4/+utrxDIGNgjwG mo5uQBAIKDYt/FKpsh7f5jgdU2Dn4wsUSfDCpQD+GMcdM4OaZtj37NKhauvZ2gxnXE++ eaNNkXfIzaNAT7W9JrEZBQLG0R38I5weN+Z9BAe7L5A7x3siv1tP7GbSW6Re8C3TurH0 w9fg== X-Forwarded-Encrypted: i=1; AJvYcCVZ2gQTYHDIWR22IaD/UfRogK3BzkG4yGA5kVcFrRi/OpoaaC4vIapF46kedqiQnhDlDRYzW4wIzcLR@vger.kernel.org X-Gm-Message-State: AOJu0Yy5D1JBsBytWuHuelzF2Sa9HWk5m+PS9T9AGtVE6YQuBsx5PVA/ lPNiiyLtyLS1xJ159jh3sxiyW05m8g7fEFLH2RZOXXbkQtsPhqQkFVfm X-Gm-Gg: ASbGncsk3YoYX96X68pQQbpSLjTFAKCnr6rSUvqcjZa2P86TPlF0HiUDUzVy7Pbjy8g EJ51cE+YbbXTfC12HzavWsyj2Q4BWO99ywvepY/SIeUccQ4txUnrYoOV8i4rq7tho1qYY5RRW/O u1R25fj0bQr0+wVes+RIRndcxMk49If653N70R38oMVY68HQf1gitof3Ee7ZoNJVt7dMkggiGTI ji22ZEdg+wupzuQ7AzA63tiwVqNj8amiujlHyGnWivllGO5LOiZ0PSDJqSXwU9Fe1+XHnWNzukR M3egNopi40UWuwBKVFj/aupW5ne1QnytZNjG8P96z/yEXTb4Z8dnVncamNv5nQtbYVvti6bgeji p6p6H5RR6Vc0NM9NEYoaE7igJcnkPlmZcwyLcKGdVkx+eieprTlQTWq9dK7g2c74n3JTtSwMAVE 6sdLnRahAQxHork0IZVrgo3Ka263oLzCVsyVQ04bZuYFk= X-Google-Smtp-Source: AGHT+IE41b3Sl3rbfcyXiZWcoVlhth/4OLSZhMP4xO2QStJyHe624xmVVemaTnDEQ6TOsZXL4Mlg5w== X-Received: by 2002:a17:903:3b8e:b0:295:32ea:4ce5 with SMTP id d9443c01a7336-2986a6bd29emr190500505ad.6.1763460986760; Tue, 18 Nov 2025 02:16:26 -0800 (PST) Received: from [172.16.20.12] ([136.226.245.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b924be37fbsm16225302b3a.1.2025.11.18.02.16.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 02:16:26 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 15:46:57 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board To: Dmitry Baryshkov Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251107105735.1491273-1-tessolveupstream@gmail.com> <20251107105735.1491273-3-tessolveupstream@gmail.com> Content-Language: en-US From: tessolveupstream@gmail.com In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14-11-2025 01:38, Dmitry Baryshkov wrote: > On Fri, Nov 07, 2025 at 04:27:35PM +0530, Sudarshan Shetty wrote: >> Introduce the device tree support for the QCS615-based talos-evk > > You can't introduce DT _support_. It's either introducing a DT or > supporting. Understood, will take care in v7 patch. > >> platform, which follows the SMARC (Smart Mobility ARChitecture) >> standard. The platform is composed of two main hardware >> components: the talos-evk-som and the talos-evk-cb. > > are those the actual names? I'd say, the platform is composed of the SoM > (following some standard or not) and a Carrier Board. Okay, will update. > >> The Talos EVK platform supports multiple display configurations >> HDMI and LVDS that share a common carrier board design. > > Other way, the Carrier Board supports several (not multiple) display > configurations. Okay, will update in v7 patch. > >> Both configurations use the same base carrier board hardware, >> while the display output is selected through hardware configuration >> options (DIP switch selection). > > drop the "hardware configuration options". DIP-switch is enough. Okay. > >> >> To avoid duplication, introduce a new include file, > > s/introduce/use/ Okay. > >> talos-evk-cb.dtsi, which defines interfaces and peripherals that are >> common to both display variants. > > ... and two DTs, cb-hdmi and cb-lvds, describing the selected > configuration. Okay, will take care in v7 patch. > >> >> The initial device tree includes basic support for: > > Can any of them be non-basic? No. > >> - CPU and memory >> - UART >> - GPIOs >> - Regulators >> - PMIC >> - Early console >> - AT24MAC602 EEPROM >> - MCP2515 SPI to CAN >> - ADV7535 DSI-to-HDMI bridge >> - DisplayPort > > What else is present as a part of the platform? Are we missing > something? Ethernet, Wi-Fi/BT is still in development phase. Will update in upcoming patches. > >> >> Signed-off-by: Sudarshan Shetty >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi | 56 +++ >> arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 443 ++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/talos-evk.dts | 89 ++++ >> 4 files changed, 589 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index 5b52f9e4e5f3..282d744acd73 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -305,6 +305,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-mtp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb >> x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo >> dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb >> x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtbo >> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi >> new file mode 100644 >> index 000000000000..81d15ee4f366 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi >> @@ -0,0 +1,55 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> +/dts-v1/; >> + >> +#include "talos-evk-som.dtsi" >> + >> +/ { >> + model = "Qualcomm QCS615 IQ 615 EVK"; >> + compatible = "qcom,talos-evk", "qcom,qcs615", "qcom,sm6150"; >> + chassis-type = "embedded"; >> + >> + aliases { >> + mmc1 = &sdhc_2; >> + }; >> + >> + dp-connector { >> + compatible = "dp-connector"; >> + label = "DP0"; >> + type = "full-size"; >> + >> + hpd-gpios = <&tlmm 104 GPIO_ACTIVE_HIGH>; >> + >> + port { >> + dp0_connector_in: endpoint { >> + remote-endpoint = <&mdss_dp0_out>; >> + }; >> + }; >> + }; >> +}; >> + >> +&pon_pwrkey { >> + status = "okay"; >> +}; >> + >> +&pon_resin { >> + linux,code = ; >> + >> + status = "okay"; >> +}; >> + >> +&sdhc_2 { >> + pinctrl-0 = <&sdc2_state_on>; >> + pinctrl-1 = <&sdc2_state_off>; >> + pinctrl-names = "default", "sleep"; >> + >> + bus-width = <4>; >> + cd-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>; >> + >> + vmmc-supply = <&vreg_l10a>; >> + vqmmc-supply = <&vreg_s4a>; >> + >> + status = "okay"; >> +}; >> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi >> new file mode 100644 >> index 000000000000..9e6198892c11 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi >> @@ -0,0 +1,443 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> +/dts-v1/; >> + >> +#include >> +#include >> +#include "sm6150.dtsi" >> +#include "pm8150.dtsi" >> +/ { >> + aliases { >> + mmc0 = &sdhc_1; >> + serial0 = &uart0; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> + >> + clocks { >> + sleep_clk: sleep-clk { >> + compatible = "fixed-clock"; >> + clock-frequency = <32764>; >> + #clock-cells = <0>; >> + }; >> + >> + xo_board_clk: xo-board-clk { >> + compatible = "fixed-clock"; >> + clock-frequency = <38400000>; >> + #clock-cells = <0>; >> + }; >> + }; >> + >> + regulator-usb2-vbus { >> + compatible = "regulator-fixed"; >> + regulator-name = "USB2_VBUS"; >> + gpio = <&pm8150_gpios 10 GPIO_ACTIVE_HIGH>; >> + pinctrl-0 = <&usb2_en>; >> + pinctrl-names = "default"; >> + enable-active-high; >> + regulator-always-on; >> + }; >> + >> + vreg_v3p3_can: regulator-v3p3-can { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg-v3p3-can"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> + vreg_v5p0_can: regulator-v5p0-can { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg-v5p0-can"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> +}; >> + >> +&apps_rsc { >> + regulators-0 { >> + compatible = "qcom,pm8150-rpmh-regulators"; >> + qcom,pmic-id = "a"; >> + >> + vreg_s3a: smps3 { >> + regulator-name = "vreg_s3a"; >> + regulator-min-microvolt = <600000>; >> + regulator-max-microvolt = <650000>; >> + regulator-initial-mode = ; >> + }; >> + >> + vreg_s4a: smps4 { >> + regulator-name = "vreg_s4a"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1829000>; >> + regulator-initial-mode = ; >> + }; >> + >> + vreg_s5a: smps5 { >> + regulator-name = "vreg_s5a"; >> + regulator-min-microvolt = <1896000>; >> + regulator-max-microvolt = <2040000>; >> + regulator-initial-mode = ; >> + }; >> + >> + vreg_s6a: smps6 { >> + regulator-name = "vreg_s6a"; >> + regulator-min-microvolt = <1304000>; >> + regulator-max-microvolt = <1404000>; >> + regulator-initial-mode = ; >> + }; >> + >> + vreg_l1a: ldo1 { >> + regulator-name = "vreg_l1a"; >> + regulator-min-microvolt = <488000>; >> + regulator-max-microvolt = <852000>; >> + regulator-initial-mode = ; >> + regulator-allow-set-load; >> + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; >> + }; >> + >> + vreg_l2a: ldo2 { >> + regulator-name = "vreg_l2a"; >> + regulator-min-microvolt = <1650000>; >> + regulator-max-microvolt = <3100000>; >> + regulator-initial-mode = ; >> + regulator-allow-set-load; >> + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; >> + }; >> + >> + vreg_l3a: ldo3 { >> + regulator-name = "vreg_l3a"; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1248000>; >> + regulator-initial-mode = ; >> + regulator-allow-set-load; >> + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; >> + }; >> + >> + vreg_l5a: ldo5 { >> + regulator-name = "vreg_l5a"; >> + regulator-min-microvolt = <875000>; >> + regulator-max-microvolt = <975000>; >> + regulator-initial-mode = ; >> + regulator-allow-set-load; >> + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; >> + }; >> + >> + vreg_l7a: ldo7 { >> + regulator-name = "vreg_l7a"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1900000>; >> + regulator-initial-mode = ; >> + regulator-allow-set-load; >> + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; >> + }; >> + >> + vreg_l8a: ldo8 { >> + regulator-name = "vreg_l8a"; >> + regulator-min-microvolt = <1150000>; >> + regulator-max-microvolt = <1350000>; >> + regulator-initial-mode = ; >> + regulator-allow-set-load; >> + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; >> + }; >> + >> + vreg_l10a: ldo10 { >> + regulator-name = "vreg_l10a"; >> + regulator-min-microvolt = <2950000>; >> + regulator-max-microvolt = <3312000>; >> + regulator-initial-mode = ; >> + regulator-allow-set-load; >> + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; >> + }; >> + >> + vreg_l11a: ldo11 { >> + regulator-name = "vreg_l11a"; >> + regulator-min-microvolt = <1232000>; >> + regulator-max-microvolt = <1260000>; >> + regulator-initial-mode = ; >> + regulator-allow-set-load; >> + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; >> + }; >> + >> + vreg_l12a: ldo12 { >> + regulator-name = "vreg_l12a"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1890000>; >> + regulator-initial-mode = ; >> + }; >> + >> + vreg_l13a: ldo13 { >> + regulator-name = "vreg_l13a"; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3230000>; >> + regulator-initial-mode = ; >> + regulator-allow-set-load; >> + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; >> + }; >> + >> + vreg_l15a: ldo15 { >> + regulator-name = "vreg_l15a"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1904000>; >> + regulator-initial-mode = ; >> + regulator-allow-set-load; >> + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; >> + }; >> + >> + vreg_l16a: ldo16 { >> + regulator-name = "vreg_l16a"; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3312000>; >> + regulator-initial-mode = ; >> + regulator-allow-set-load; >> + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; >> + }; >> + >> + vreg_l17a: ldo17 { >> + regulator-name = "vreg_l17a"; >> + regulator-min-microvolt = <2950000>; >> + regulator-max-microvolt = <3312000>; >> + regulator-initial-mode = ; >> + }; >> + }; >> +}; >> + >> +&i2c5 { >> + status = "okay"; > > No clock-frequency? Why not add one, disabling the warning? Understood, We will update in v7 patch. > >> + >> + eeprom@57 { >> + compatible = "atmel,24c02"; >> + reg = <0x57>; >> + pagesize = <16>; >> + }; >> + >> + eeprom@5f { >> + compatible = "atmel,24mac602"; >> + reg = <0x5f>; >> + pagesize = <16>; >> + }; >> +}; >> + >> +&mdss { >> + status = "okay"; >> +}; >> + >> +&mdss_dp0 { >> + status = "okay"; >> +}; >> + >> +&mdss_dp0_out { >> + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>; >> + remote-endpoint = <&dp0_connector_in>; >> +}; >> + >> +&mdss_dp_phy { >> + vdda-phy-supply = <&vreg_l11a>; >> + vdda-pll-supply = <&vreg_l5a>; >> + >> + status = "okay"; >> +}; >> + >> +&mdss_dsi0 { >> + vdda-supply = <&vreg_l11a>; >> + >> + status = "okay"; >> +}; >> + >> +&mdss_dsi0_out { >> + remote-endpoint = <&adv7535_in>; > > If ADV7535 isn't a part of the SoM, why is this property here? Okay, will move to talos-evk.dts file. > >> + data-lanes = <0 1 2 3>; >> +}; >> + >> +&mdss_dsi0_phy { >> + vdds-supply = <&vreg_l5a>; >> + >> + status = "okay"; >> +}; >> + >> +&pcie { >> + perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>; >> + wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>; >> + >> + pinctrl-0 = <&pcie_default_state>; >> + pinctrl-names = "default"; >> + >> + status = "okay"; >> +}; >> + >> +&pcie_phy { >> + vdda-phy-supply = <&vreg_l5a>; >> + vdda-pll-supply = <&vreg_l12a>; >> + >> + status = "okay"; >> +}; >> + >> +&pm8150_gpios { >> + usb2_en: usb2-en-state { >> + pins = "gpio10"; >> + function = "normal"; >> + output-enable; >> + power-source = <0>; >> + }; >> +}; >> + >> +&qupv3_id_0 { >> + status = "okay"; >> +}; > > Is there a need to also enable GPI_DMA? Yes, will enable gpi_dma0 & gpi_dma1 in v7 patch. > >> + >> +&qupv3_id_1 { >> + status = "okay"; >> +}; >> + >> +&remoteproc_adsp { >> + firmware-name = "qcom/qcs615/adsp.mbn"; >> + >> + status = "okay"; >> +}; >> + >> +&remoteproc_cdsp { >> + firmware-name = "qcom/qcs615/cdsp.mbn"; >> + >> + status = "okay"; >> +}; >> + >> +&sdhc_1 { >> + pinctrl-0 = <&sdc1_state_on>; >> + pinctrl-1 = <&sdc1_state_off>; >> + pinctrl-names = "default", "sleep"; >> + >> + bus-width = <8>; >> + mmc-ddr-1_8v; >> + mmc-hs200-1_8v; >> + mmc-hs400-1_8v; >> + mmc-hs400-enhanced-strobe; >> + vmmc-supply = <&vreg_l17a>; >> + vqmmc-supply = <&vreg_s4a>; >> + >> + non-removable; >> + no-sd; >> + no-sdio; >> + >> + status = "okay"; >> +}; >> + >> +&spi6 { >> + status = "okay"; >> + >> + can@0 { >> + compatible = "microchip,mcp2515"; > > > >> + reg = <0>; >> + clock-frequency = <20000000>; >> + interrupts-extended = <&tlmm 87 IRQ_TYPE_LEVEL_LOW>; >> + spi-max-frequency = <10000000>; >> + vdd-supply = <&vreg_v3p3_can>; >> + xceiver-supply = <&vreg_v5p0_can>; >> + }; >> +}; >> + >> +&tlmm { >> + pcie_default_state: pcie-default-state { >> + clkreq-pins { >> + pins = "gpio90"; >> + function = "pcie_clk_req"; >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> + >> + perst-pins { >> + pins = "gpio101"; >> + function = "gpio"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> + >> + wake-pins { >> + pins = "gpio100"; >> + function = "gpio"; >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> + }; >> +}; >> + >> +&uart0 { >> + status = "okay"; >> +}; >> + >> +&usb_1_hsphy { >> + vdd-supply = <&vreg_l5a>; >> + vdda-pll-supply = <&vreg_l12a>; >> + vdda-phy-dpdm-supply = <&vreg_l13a>; >> + >> + status = "okay"; >> +}; >> + >> +&usb_qmpphy { >> + vdda-phy-supply = <&vreg_l5a>; >> + vdda-pll-supply = <&vreg_l12a>; >> + >> + status = "okay"; >> +}; >> + >> +&usb_1 { >> + status = "okay"; >> +}; >> + >> +&usb_1_dwc3 { >> + dr_mode = "host"; >> +}; >> + >> +&usb_hsphy_2 { > > So, the labels are usb_1_hsphy, but usb_hsphy_2? That's not logical, > please fix one of them. Then please fix the order of nodes here. The node names come directly from the included talos.dtsi, where they are defined as usb_1_hsphy & usb_hsphy_2. To avoid breaking inherited definitions, we kept the same labels in our board DTS. However, I will reorder the nodes so they appear in a logical and consistent sequence. > >> + vdd-supply = <&vreg_l5a>; >> + vdda-pll-supply = <&vreg_l12a>; >> + vdda-phy-dpdm-supply = <&vreg_l13a>; >> + >> + status = "okay"; >> +}; >> + >> +&usb_2 { >> + status = "okay"; >> +}; >> + >> +&usb_2_dwc3 { >> + dr_mode = "host"; >> +}; >> + >> +&ufs_mem_hc { >> + reset-gpios = <&tlmm 123 GPIO_ACTIVE_LOW>; >> + vcc-supply = <&vreg_l17a>; >> + vcc-max-microamp = <600000>; >> + vccq2-supply = <&vreg_s4a>; >> + vccq2-max-microamp = <600000>; >> + >> + status = "okay"; >> +}; >> + >> +&ufs_mem_phy { >> + vdda-phy-supply = <&vreg_l5a>; >> + vdda-pll-supply = <&vreg_l12a>; >> + >> + status = "okay"; >> +}; >> + >> +&venus { >> + status = "okay"; >> +}; >> diff --git a/arch/arm64/boot/dts/qcom/talos-evk.dts b/arch/arm64/boot/dts/qcom/talos-evk.dts >> new file mode 100644 >> index 000000000000..b694dda422a8 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/talos-evk.dts >> @@ -0,0 +1,89 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> +/dts-v1/; >> + >> +#include "talos-evk-cb.dtsi" >> + >> +/ { >> + hdmi-out { >> + compatible = "hdmi-connector"; >> + type = "d"; >> + >> + port { >> + hdmi_con_out: endpoint { >> + remote-endpoint = <&adv7535_out>; >> + }; >> + }; >> + }; >> + >> + vreg_v5p0_out: regulator-v5p0-out { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg-v5p0-out"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + regulator-boot-on; >> + regulator-always-on; >> + /* Powered by system 20V rail (USBC_VBUS_IN) */ >> + }; >> + >> + vreg_v3p3_out: regulator-v3p3-out { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg-v3p3-out"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + vin-supply = <&vreg_v5p0_out>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> + vreg_v1p8_out: regulator-v1p8-out { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg-v1p8-out"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + vin-supply = <&vreg_v5p0_out>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> +}; >> + >> +&i2c1 { >> + clock-frequency = <400000>; >> + >> + status = "okay"; >> + >> + bridge: bridge@3d { >> + compatible = "adi,adv7535"; >> + reg = <0x3d>; >> + avdd-supply = <&vreg_v1p8_out>; >> + dvdd-supply = <&vreg_v1p8_out>; >> + pvdd-supply = <&vreg_v1p8_out>; >> + a2vdd-supply = <&vreg_v1p8_out>; >> + v3p3-supply = <&vreg_v3p3_out>; >> + interrupts-extended = <&tlmm 26 IRQ_TYPE_LEVEL_LOW>; >> + adi,dsi-lanes = <4>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + >> + adv7535_in: endpoint { >> + remote-endpoint = <&mdss_dsi0_out>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + adv7535_out: endpoint { >> + remote-endpoint = <&hdmi_con_out>; >> + }; >> + }; >> + }; >> + }; >> +}; >> -- >> 2.34.1 >> >