Re: [PATCH 3/4] arm64: dts: qcom: sc8280xp: gaokun3: add front camera sensor node

Pengyu Luo
2026-04-29T06:37:13Z

On Mon, Apr 27, 2026 at 9:00 PM Konrad Dybcio
<konrad.dybcio@oss.qualcomm.com> wrote:
>
> On 4/25/26 12:52 PM, Pengyu Luo wrote:
> > Hi846 is found on my Gaokun3, descripting it.
> >
> > Note that it seems that only Goakun3(3.0GHz) version is equipped with
> > Hi846. Goakun3(2.69GHz) version is equipped with S5K4H7.
>
> Are there any other noticeable hw differences between the two variants,
> that could warrant the DT to be split?
>

Except for the cameras and cpu, I think no.(But I couldn't tell all
3.0 variants are equipped with hi846) Before camera support, this DT
worked for both of them.

> [...]
>
> > + orientation = <0>; /* Front facing */
>
> Please either drop the comment or s/tab/space
>

I see.

Best wishes,
Pengyu

> Konrad