From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E982346A02 for ; Wed, 12 Nov 2025 17:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762968304; cv=none; b=KyEmk6NgV7DA4yKsvuy2tyO+iU7gJibZEcpxlmX7JFh8/lbgcswB64h3ew3XrHQM67wqPEo/xn95kXFiZCmQFwT25jW1buwmFwAn+uR/X4p6A9XKl5F4UO7t9qBCMEeGr4Dg6fq41H21+R/ME18nHUQGvItT1zB0H9fVKY8ZzuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762968304; c=relaxed/simple; bh=igQk7IJ58jSde1RxsW+nclhIn6i3+FsoP+UNSE9F6p0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MyuCbD/Q6f9kFY10lFwzf88s8mre1BMYOd7cbMo07FewFltJimaS/dvFw+BXSjVTTB+X8Bo+HMTR3lDRmYYWC5GtiBPULBN4vKCoH+HKPekF3Jtt4U4+Bqx3ikQcvzYWG4v3cCdgNbLd8Xz+jp7SFiaYNXK9AfxUOtIajbsWSTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IrducnoR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fMCytAZF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IrducnoR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fMCytAZF" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ACDsTjl1314491 for ; Wed, 12 Nov 2025 17:25:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /Km83Z8dJrIrAX1ZOXyhzLK/42gxeDh501oYlNSXd5M=; b=IrducnoRl/XHdZ1m nPOFuvT6IUNwXU6pESjJu8QQtWRqvRMmy0aLhekGsQX0SHH5xUQ7uK/tZ+0pmDGk AoRSC6L/KseWHCh7O9bbna7iVmY33VsE+SaZyzsEbWeQLE136pn0/U+V9mmsz3VE pBeknlq85Jipuznsr2thcQ17IQOX8FTLfp96fsgvyHkZkSqIf9d3JPxxmLTPUdmB DZGvaqwmWODxgJBAQh5pwWfskJ/0hd5dxkUnCDTT1IzV0LaSzAkmc4OIc0nErCxZ 8+KGdc3KoPSTDbKXnwyGe0CLfSPf56Exkn4OiJuw+Deu35xs+miY+xSCoEY+7qWX DL6SNw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4acuhg0r6n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Nov 2025 17:25:01 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4e88c912928so28456451cf.0 for ; Wed, 12 Nov 2025 09:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762968300; x=1763573100; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/Km83Z8dJrIrAX1ZOXyhzLK/42gxeDh501oYlNSXd5M=; b=fMCytAZFygBwHEujR4VNE2Y07fzTcBUnlDPwT0ZHZz5wgPPtJ6smpo+NBAWUsV4m8t MmjlVt4FznyeW4AGPK+zsQ3q+y+Pcvwftsjc4X0svMyaUiyflN4dr5LFhUGV4fAx/rVn kbsaWimeedSAOpJm38v51+ZbtpBe3HhG378So1ig+qd/orA/kA4JiAKIW0rXm57fdHcO JZm34/ZPA8c6J4CuCRzQ4/NRFvZIQDMOMJm2PcuuUv5sohBVyGW7bbZEHy8R9dmc0nZ4 yvKSG/rF1eMtXhCMngbe/YSG2SY1kW8/baJYD6Bbn6TP2mFXAPbB1qtXsgpeH5gfDD6G tdLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762968300; x=1763573100; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/Km83Z8dJrIrAX1ZOXyhzLK/42gxeDh501oYlNSXd5M=; b=xQjZkLEQxd3k/mKA1ZcUk0TEzMR9EvVPpp0gTY1mgZZ3vHfpYyWvV2/dUxrLLB1RNf qf4JydEGxChPXZsu1a0B3N6n1enD5qJ3R6eIWfxz+H+3u73tC9m+0Fg/FOrE9EuR3qQ2 DkyrDGnAJjAZb3I+gHUS13piyrpuVJwFfmEZ1gPOSWplCiB2FL2xD3abSqyZFAjs+r9q xeaadYguqtiRJvxHBQDooDVmb9HXo+H0cfnrnsMtBOD2N4xZ5MZQeiIUmuBtuVmvWXgM RbItROje0dGSaqGQMv469SLJ3wPnC3fhJr59ryNUF0a7ol5S8U0uuvdAbcXpnjyhe65y 3AgA== X-Forwarded-Encrypted: i=1; AJvYcCVBGcvVnoz1cADHFbz/0f79Qe/6e9Fx+W0fY9ko4Rv3nc7XyTqPnYfXYhImrcSfIzcAlgmVzk9Qr3t1@vger.kernel.org X-Gm-Message-State: AOJu0Yyc42BdZ4TMF96anRlnYZKaZg/SlhiXDE6NNgnFFCt3cEZLIVn5 aM4w0PrfZWEw2TM+iS77C0LRLPNhcr0NVsQClMBoXwh6eiH2VDIMUMGUpXc11M65o2j1/3Ekwz4 8PnwiYr8Cw475UDYw4Vq+blmkbPKqUKSDq6cq3lHzNucX161tBqqAHKJMeKqT+QBl X-Gm-Gg: ASbGncvm6s8C1HX2wdY0TK2K3xZ482jBm0Uj1kMwUjmoQ/0AgwheMuf6Hq0wHmRSf/9 lIyRd9Ll6UNEEGypoWV17cHwKE3b3cv7LntJx+95UFEFatp5c5thuuLjcqrwpwCTVrii3+BsmR+ I1dj/jz7S+txXxyNYdTamScS6uWGOURFvxYtwc1YYkmpFrq0o0OxmMr10nFJ8596bg4StN8hU+D QOEE/P2GKJADYj3wI4/2wRNbVGy8+YtH/AV4rQXPIK2FB2mkRfHQqewE7utATqLkGZQ9vXlARYy uvmZY0qQAYwMZbCuDyYtMpGVK7zq2TSHXKQpqMGViGOtqjO2JAf+8OAjaUOSRReDblR5gISs0Lg Tnpaa4ApWi0xiYsiFqphRDFGoKA== X-Received: by 2002:a05:622a:28a:b0:4ed:213c:1582 with SMTP id d75a77b69052e-4eddbc4df56mr45383531cf.7.1762968300164; Wed, 12 Nov 2025 09:25:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/HxFt1aiBzX4O5TfxsQW2cuwzf8525wYzeQqUTuGj+dwhgfdPm+309s2XwH34HG9G30yWJA== X-Received: by 2002:a05:622a:28a:b0:4ed:213c:1582 with SMTP id d75a77b69052e-4eddbc4df56mr45383201cf.7.1762968299645; Wed, 12 Nov 2025 09:24:59 -0800 (PST) Received: from [192.168.68.121] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4778bcfa2e9sm798635e9.12.2025.11.12.09.24.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Nov 2025 09:24:59 -0800 (PST) Message-ID: Date: Wed, 12 Nov 2025 17:24:57 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/12] ASoC: codecs: add wsa881x-i2c amplifier codec driver To: Alexey Klimov , Srinivas Kandagatla , Mark Brown , linux-sound@vger.kernel.org Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Dmitry Baryshkov , Konrad Dybcio , Konrad Dybcio , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20250522-rb2_audio_v3-v3-0-9eeb08cab9dc@linaro.org> <20250522-rb2_audio_v3-v3-6-9eeb08cab9dc@linaro.org> <1c7d62f5-1816-4ecf-9376-2751ec06830b@gmail.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=NbnrFmD4 c=1 sm=1 tr=0 ts=6914c2ed cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8-6JEL_qhUNu0U2AKIkA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: enP5bWYttCQxO4IUCB234zkWmkWOpXjr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTEyMDE0MCBTYWx0ZWRfXy8kYge4plS0B qUCLT/+dOlgspkdDksVlsUqdF6FmZVQ08igc0UUBjNwIa4yo5R9KL/f2lOgdHyeqWzu+94gedFU oVYdlrqBdBxqiRYVgRDoOsiKUsNMHyKXip19B0eHnjKOyqbC0xkg//j/h+7aNXa7m//9BQrZDU/ 0MF3vY8FLjymsX+DiWNAHgFtHLVtYJpm4SjZJK+5y3KJQzqtxmM+enUUfZlgFhgY+aDhgsYXhnX iGHsfMWsbYIvvetl8OsbPi+UDrN1ld/aGlDuTvODK06kc2jUawHJipWF0iXi2+jqQ9arBWaL1Oc a6BcPf9GyXlXPHWDwgoi5PyptuC8mLrDmFhgYSgfgjXOWXY9i5O7XTmalFFbIu+rtqjHGxRiSnH Sun9JXb9qwyivjpp3giTADP+snfcJQ== X-Proofpoint-ORIG-GUID: enP5bWYttCQxO4IUCB234zkWmkWOpXjr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-12_05,2025-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511120140 On 11/12/25 5:16 PM, Alexey Klimov wrote: > Hello Srini, > > On Thu May 29, 2025 at 11:05 AM BST, Srinivas Kandagatla wrote: >> >> On 5/22/25 6:40 PM, Alexey Klimov wrote: >>> Add support to analog mode of WSA8810/WSA8815 Class-D Smart Speaker >>> family of amplifiers. Such amplifiers are primarily interfaced with >>> SoundWire but they also support analog mode which is configurable by >>> setting one of the pins to high/low. In such case the WSA881X amplifier >>> is configurable only using i2c. >>> >>> To have stereo two WSA881X amplifiers are required but mono >>> configurations are also possible. > > [...] > >>> --- /dev/null >>> +++ b/sound/soc/codecs/wsa881x-i2c.c > > [..] > >>> +struct reg_default wsa881x_ana_reg_defaults[] = { >> >> This does not make sense. >> >> All the regmaps should be same, it should not change with the change in >> interface from SWD to I2C. >> >> Could you calrify this before we start reviewing rest of the driver. > > It was sent initially in nov 2024 I guess and that one was v3. v2 was > sent in December 2024. > > I am currently reimplementing this. I obviously agree that registers > are the same but why we should be 100% sure that regs defaults > should be the same if the mode is different? > Am not sure why the hw reset codec register defaults would be different for each interface. There might be some additional interface block registers which could be missing in the original list, but the codec registers should be same. > Or do you suggest/expect that, for instance, analog defaults should be > kinds applied on top of common (swd) default values? Codec + interface specific is what i was thinking of. --srini > > > [....] > (The rest of original email was sent and quoted but I did not > see any comments there, so I removed it but if I missed smth there > please let me know) > > Thanks, > Alexey >