From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH v4 16/16] ACPI / DSD: Document references, ports and endpoints Date: Tue, 14 Mar 2017 23:16:54 +0200 Message-ID: References: <1488809970-25568-1-git-send-email-sakari.ailus@linux.intel.com> <1488809970-25568-17-git-send-email-sakari.ailus@linux.intel.com> <1629581.fh46rNHz4U@aspire.rjw.lan> <3df6ac2a-29cc-52b1-cc0c-4c1bc4198c83@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , ACPI Devel Maling List , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Sudeep Holla , Lorenzo Pieralisi , Mika Westerberg , Mark Rutland , Mark Brown , Rob Herring , Al Stone List-Id: devicetree@vger.kernel.org Rafael J. Wysocki wrote: > On Tue, Mar 14, 2017 at 6:54 PM, Sakari Ailus > wrote: >> Hi Rafael, >> >> Rafael J. Wysocki wrote: >>> >>> On Tue, Mar 14, 2017 at 9:09 AM, Sakari Ailus >>> wrote: >>>> >>>> On 03/14/17 10:08, Sakari Ailus wrote: >>>>> >>>>> How about this instead: >>>>> >>>>> All port nodes are located under the device's "_DSD" node in the >>>>> hierarchical data extension tree. The property extension related to >>>>> each port node must contain the key "port" and an integer value which >>>>> is the number of the port. >>>> >>>> >>>> So with matching strings instead of indices, this will change, too... >>> >>> >>> It doesn't have to AFAICS, but the number is just redundant IMO. You >>> only need a boolean property saying "this is a port", so you know that >>> you should expect a list of endpoints in that object. >> >> >> No, it's not redundant. It's the number of the physical port in the device >> --- this is how the driver gets to know where the connection has been made. > > OK, but what exactly do you mean by "physical port"? The device (or an IP block) has physical interfaces to the world outside. There could be just one, but there may be more. For an ISP, there could be e.g. four CSI-2 receivers to each of which you could connect a camera sensor. So for an ISP device, that number tells which of the receivers a given sensor is connected to. The mapping between this number and what the hardware datasheet refers to needs to be documented per device. -- Regards, Sakari Ailus sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html