Re: [PATCH 5/5] ARM: dts: qcom: Add support for MBG TM for pm8775 on SA8775P

[Krzysztof Kozlowski <krzk@kernel.org>]

On 12/07/2024 14:43, Satya Priya Kakitapalli wrote:
> Add support for MBG TM peripheral for pm8775 sail pmics on SA8775P.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> ---
>  arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 120 ++++++++++++++++++++++++++++
>  1 file changed, 120 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> index bd4f5f51e094..69910306885e 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> @@ -89,6 +89,62 @@ trip1 {
>  				};
>  			};
>  		};
> +
> +		pmm8654au_0_mbg_tm: pmm8654au_0_mbg_tz {

This wasn't ever tested and cannot work.

Please read your internal guideline before posting any more work. That
guideline you have is pretty detailed and offloads community from
pointing silly issues like - never testing.

> +			polling-delay-passive = <100>;
> +			polling-delay = <0>;
> +			thermal-sensors = <&pmm8654au_0_tz>;
> +

...

>  	pmm8654au_3: pmic@6 {
>  		compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
>  		reg = <0x6 SPMI_USID>;
> @@ -317,4 +421,20 @@ pmm8654au_3_gpios: gpio@8800 {
>  			#interrupt-cells = <2>;
>  		};
>  	};
> +
> +	pmm8654au_sail_3: pmic@7 {
> +		compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
> +		reg = <0x7 SPMI_USID>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		pmm8654au_3_tz: qcom,mbg-tm@d700 {

Again: do you see anywhere node called "qcom,foo-bar"?



Best regards,
Krzysztof