From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A65252248BB for ; Wed, 16 Apr 2025 19:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744831466; cv=none; b=GHLo1fgFfZmqAkgqCTe8rPzBq9nI227DF3yzKhTY6UPxsE2wpv8lwd2e9mXFX6rh2a2n7GWY4LLrrUx0sjbUM/e6jWqeSKAfzee35Fse7qBPXf9pgYYQ68SPdbO7+q2GUU4Immr9JrXdaC32luCFuezOsJsJovU5EF9sr1bX9Nk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744831466; c=relaxed/simple; bh=L1QpL+dJg+mvC89uNW9F0Wau2KS/B5UiT7wTtGlO8ks=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NjKw0JNHj8I5YLZrw6WYiFTXUzHzlKPCNydikYffnPRVUF0kUiQl8USPcpjaw5ygyK6fMg73PPax5WPui5xQHRKkfDf6ol8C9Am5dM9irYWmwGU5xdxzJrYB2OLSWjHm+GeNCeuQsh1Nl3ekBIdLDAAhtu0h8rNIkH9M87wxl5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=nhYGLM6g; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="nhYGLM6g" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3fbaa18b810so1899723b6e.2 for ; Wed, 16 Apr 2025 12:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1744831463; x=1745436263; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OVWtjKl7iqOi18r6l4CQzpfIdcd44V0fOP6BaJjZNMU=; b=nhYGLM6gcJcCl+oQB7bN27zSlNCtr/ulhx77MXw+Cfl5JQuZr5qX+gprtsDvobHw1y KHbxm7Lt0zl0fVl6/iZ4WC5PmqZBKZmDCwKNR2SGsLqyJ37SqcqPFxwLx7+UlhvdFMhZ nRBF3f8SHdTnYtM0IGAjx8+qghmJ5LdJuOzKj9tZXs31rm4/WLE/RR3Lkejd0QdGBBu9 vGw52Q4evc/RCUtq+7Fa3qvXSO1S7ajeEmLRWJwNAfjno8IHA4WvsMzwRxKaEtutSy2E C8pkWQssm0VoGUj5VntrM8QLtR788neZASlnYzwgQsB2YYzNaoL0lLriJd0dTzxP6/q4 7jUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744831463; x=1745436263; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OVWtjKl7iqOi18r6l4CQzpfIdcd44V0fOP6BaJjZNMU=; b=ViyXjBh7jFrJcc0ULDe/nIw2C46i6zqBohsYnG7E1Ys6EUdX3EpgOqJDjloYDS4rzg BKa7fZyJmijPXEUbYcXmZLGv5A51RbvcgFTnDeVQRaSIeAXFaj6WxujvY3E/DCBbpiy/ 15+hQvV49OvNEweKrJ71aL3a2K1T7JiiIeTRLx9+DTk7FBRs4DNx4Mp5cD7gqSfjX4JC v3JDb8kWVzkGWRv+BrhW9I6IWulSCNWZF5LvSrIN71eQYuPQMWQEQyy9amXV3Q6K8kaO sT2ufFM32D9Wv/S7iEXVSliVKKIO5NDd1mWoZNnQACphVQ+/WfED35vjXowJQ27lxdtZ MT1w== X-Forwarded-Encrypted: i=1; AJvYcCXCdG30gR+XhYQi6GdhjNuwwe1RoyrUB2baCoBMfILbmaNulgoQqrYxyQnXfSpF9OdBocI9sPvFDrTa@vger.kernel.org X-Gm-Message-State: AOJu0YxTdY+kwpCM10b52FrsO030iQy2Bcn2z2T4hEw24ls7hS0K6xJ4 2/3x65wk6ivNxsFlucwKJ3jrfkfjCGa6qFVLZA9X2Ed92MiwsO6s6K3hVUX2ayE= X-Gm-Gg: ASbGncsesTYq6A5tBV0XvRvlk6Cj1bCQrOy2e2M8rKmRBdOcK4KCDVg4rHVYI2nDqjA A0p5yhojV6435hlkUU+9uIRwT/xe1mCmEyfjC7SEOfZTR7wYuQqV6HfjuxbXXZc1xIHlsmX6EP3 3XLhbariwSrE1hXI6vm48+CtJUPgkRlvtJkecQd6psX+1e60cw4AoylXgSKqemIQcyV3puvS518 oj/+xYdWMqa+ocvFldWQUCTBCIK8ywGn5ZhdvPxV+nQHE4BlUAckGMCT+hoLePz52Dw3t/eZhkT guOggMeN17CbnLge/uL2YpyCGwNm5pkprQsBHNGkrMzXcbQQFMmWn9OYten/RtreIAWlyZYeoDE 0MAjQVR3kHjdDcZkDfTUG1GWf5JDO X-Google-Smtp-Source: AGHT+IF0mpnDIyAnn6ZeAXKJmpAUqrHnVA/Xnwlkcpkjjq8eHzK67t5vDdKrA4mdat/Ij0oR7736Lw== X-Received: by 2002:a05:6808:3094:b0:3f6:7cd2:8187 with SMTP id 5614622812f47-400b01e17e9mr2050247b6e.20.1744831463701; Wed, 16 Apr 2025 12:24:23 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:58f0:670c:6b15:7fd3? ([2600:8803:e7e4:1d00:58f0:670c:6b15:7fd3]) by smtp.gmail.com with ESMTPSA id 5614622812f47-400763bab7bsm2809388b6e.45.2025.04.16.12.24.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Apr 2025 12:24:23 -0700 (PDT) Message-ID: Date: Wed, 16 Apr 2025 14:24:22 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/3] Add driver for AD3530R and AD3531R DACs To: Kim Seer Paller , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Nuno_S=C3=A1?= Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski References: <20250412-togreg-v4-0-cb9e5309b99d@analog.com> From: David Lechner Content-Language: en-US In-Reply-To: <20250412-togreg-v4-0-cb9e5309b99d@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/12/25 12:57 AM, Kim Seer Paller wrote: > The AD3530/AD3530R (8-channel) and AD3531/AD3531R (4-channel) are > low-power, 16-bit, buffered voltage output DACs with software- > programmable gain controls, providing full-scale output spans of 2.5V or > 5V for reference voltages of 2.5V. These devices operate from a single > 2.7V to 5.5V supply and are guaranteed monotonic by design. The "R" > variants include a 2.5V, 5ppm/°C internal reference, which is disabled > by default. > > Signed-off-by: Kim Seer Paller > --- I made a few comments on the driver, but still good enough for: Reviewed-by: David Lechner