From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B385D1C2A0 for ; Thu, 2 Nov 2023 18:41:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ulnjtFJn" Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEF41137 for ; Thu, 2 Nov 2023 11:41:01 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2c50305c5c4so18014101fa.1 for ; Thu, 02 Nov 2023 11:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698950460; x=1699555260; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IEpZhe0N2sN6GVcRg3szCztdEpMXAkzbYdbkv3mYVKg=; b=ulnjtFJnhHlwKCyC1/AZ1zSE6jmTjNnGl+1gPQ9y5WwhoY2j3Zz9bYXPidm0rIx7QQ nW8jd00MIhV0SCLK5tPh33JCTPsPEgqkXjhZ/k+iAKRGweTzwac/BhJhrLKrXLcJnXqB AMekWuvy9ntZniv+v6b/i1k8kcwUQYbR6ri1CCeiqeTVlLoQWTJDVasEWqot/hEZVKzp Eh0OdoOqIm3YkU5E6efCiE2W5FNKctZZEiE/0nFPrBDUoiAhShEwLIZGubrQ2Ab7WVXX +Hd7GS+j688NSzCG6Quf2788tdHucq+L1mofbLXSx/z//aDwpgPTmKMzwj5iBWNMHI6E HiTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698950460; x=1699555260; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IEpZhe0N2sN6GVcRg3szCztdEpMXAkzbYdbkv3mYVKg=; b=UNfSVBOTJuHjprRWxicGae4v4D4SVKd1zd8bomWH3ApiNQ7vlmsf64/psOzQKOvrmg FOwlbGbwneFEz21dfoNo1z/cifcWn0SrNirtmsL0pX19X4ERXnMKX1QOJalWUpYDLD4o klqaA5GdWGG3C5YfYxkVkGm+Qs3se4X/xlKE2xnwddgTJZcQJTENj/0abibfvhqU3kaj WVQnSfsZyjTwKoUEojuBcrRhwxPfg/jYSa7kDVezolg9D6q3kt9R5B1tILYHYbamiY7V q4yvSJeEWIKvNZjiTYsDepHqBDHwh1w1Mzjy29oFHsrlLCl0HFH3QbD+Th+XQOvU00uM 1NYQ== X-Gm-Message-State: AOJu0Ywj2Jromea1nnyrHLXNVDR1VU5Tm9rPf97A0dtMF9lMMxksgLnm SiyFwjGLabvO/56szJY6x7Un+A== X-Google-Smtp-Source: AGHT+IHOG6JY6QHe6uEhX0t0A0QtG2EyhAEZkQBZ47BXTPo2Tx8sm8ASqdDLXlJVbPtHx31RMFUn0w== X-Received: by 2002:a05:651c:336:b0:2c5:15dc:ba99 with SMTP id b22-20020a05651c033600b002c515dcba99mr12946673ljp.51.1698950460025; Thu, 02 Nov 2023 11:41:00 -0700 (PDT) Received: from [192.168.67.140] (92.40.204.37.threembb.co.uk. [92.40.204.37]) by smtp.gmail.com with ESMTPSA id a11-20020a05600c2d4b00b00405c33a9a12sm1481939wmg.0.2023.11.02.11.40.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Nov 2023 11:40:59 -0700 (PDT) Message-ID: Date: Thu, 2 Nov 2023 18:40:57 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/8] dt-bindings: usb: qcom,dwc3: Add bindings to enable runtime Content-Language: en-US To: Krishna Kurapati PSSNV , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski Cc: quic_wcheng@quicinc.com, linux-usb@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Philipp Zabel , Rob Herring , Greg Kroah-Hartman , devicetree@vger.kernel.org, quic_ppratap@quicinc.com, quic_jackp@quicinc.com References: <20231017131851.8299-1-quic_kriskura@quicinc.com> <20231017131851.8299-2-quic_kriskura@quicinc.com> <272a9764-1cae-4d86-88b1-00175de83333@linaro.org> <960101cc-78c0-49cf-ab62-90614eeb9ee2@quicinc.com> From: Caleb Connolly In-Reply-To: <960101cc-78c0-49cf-ab62-90614eeb9ee2@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit > Hi Caleb, > >   There are two types of platforms, some use extcon and some use > role-switch to deliver vbus/id notifications. Extcon targets already > have this qscratch modifications present today in vbus and id handlers. > But for role-switch based targets we don't have any way to get this > notification to dwc3-qcom. In this implementation, I wanted to get those > notications from core to glue and for this we implenented vendor hooks. > > The property added has been used to do two things: > > 1. Register glue's vendor hooks to core driver > 2. Do runtime_allow for glue (and by default for core as the dt is not > flattened) > > In case of extcon, we don't want to register vendor hooks as > notifications are not necessary. Could it just be enabled when role_switch is present then? > > For xhci, we opted to enable runtime from userspace. >>>         HS/FS/LS modes are supported. >>>       type: boolean >>> +  qcom,enable-rt: >>> +    description: >>> +      If present, register vendor hooks to facilitate runtime >>> suspend/resume >>> +    type: boolean >> >> A Krzysztof pointed out, properties should define the hardware >> behaviour, not tot the implementation details. For this case the >> hardware isn't wired up to vbus, so maybe something like "qcom,no-vbus"? >>> + > > On all targets, vbus is not routed to hardware. This vbus toggle > indication is given to controller via qscratch only. > > Regards, > Krishna, -- // Caleb (they/them)