From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42CE1C4332F for ; Thu, 22 Dec 2022 12:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235866AbiLVMDL (ORCPT ); Thu, 22 Dec 2022 07:03:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235878AbiLVMCs (ORCPT ); Thu, 22 Dec 2022 07:02:48 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9875B36C7D for ; Thu, 22 Dec 2022 03:54:55 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id b13so2400394lfo.3 for ; Thu, 22 Dec 2022 03:54:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tpAVb3+cVXQa1lG9/26ZmhtnuZCNmgaIflq0pQhJ+MI=; b=WMfKHcAIqLmzoW3u9ksF8dcVFMxOlA4FFCTklAZueBNiqdfZJxFULrasW0YNolRL+g l9jJDrVgFXPItkMc+8qNlt8q/YPFS5++54Bm0/0OI8of/bwkqlSkmzsmzKt7OsjaNydB SaqvlyDt9nOVrNT6g540uS3yNsE3He0u5hog7cxv1Yoq/o8dNjEvdiwyScVUi8v0kVus wZjM0eUwGZaLYbXorLZ2538sie1yaa2L0cKFZ16svZSc/0fVVc4sc/dZzbOdEE2EpdT8 A65vkWXlxfO7u1FaBJpolVnrLNVZPrxCkG95fXXxiOxUU7N4vmu9A3fE+w6WQybg1H1v kryg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tpAVb3+cVXQa1lG9/26ZmhtnuZCNmgaIflq0pQhJ+MI=; b=XAlrsIEI2m1P6l8ovjKrkSSywhwhmSsxtfE8TrjURqiKqqzhD7SV1TxAuT+uh/o3HQ Lh7UoI3o4vgmdTdvMPLDv2nx58DZs5UN9G30L6rWct9VrLFo+rch4frsP7wtckWz1LY0 E1iK//SmorW5KjdeXyBK6a7PU4mSLfipvipoCS9qr/yGl1E3BcCmaM0d3BcN90RgSqJA G8iZDAc+i6Ij4BrKoPeer96+KBCp09Y67pOCO1W2FjZNpvfH/J4DrrGQrt2qta3H9hw1 3zhzltZuCnOCGxPnpKlIfwIqOPTeR8zaV5heyO5dWawgjlNoBa+VDy12Et3+zPYp8ONu L4SQ== X-Gm-Message-State: AFqh2krPpJ3S8XqF8U2EZdG7UuOBzqNZAN3C7/Kw3Jrt/1hTk8rxso9w DdkVw6TSfwdR3q49a7+nHB4EFg== X-Google-Smtp-Source: AMrXdXtON0Zmt7ZIsbCnFjMaae522gN6PEYbg49HK+urLOAHDo4Cg/TkyZaKta1OtYFRq6DDHDoIaA== X-Received: by 2002:ac2:5318:0:b0:4b5:7720:5fe4 with SMTP id c24-20020ac25318000000b004b577205fe4mr1728513lfh.67.1671710094036; Thu, 22 Dec 2022 03:54:54 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id e2-20020a05651236c200b004b55f60c65asm44401lfs.284.2022.12.22.03.54.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Dec 2022 03:54:53 -0800 (PST) Message-ID: Date: Thu, 22 Dec 2022 12:54:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v5 08/21] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Content-Language: en-US To: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, dianders@chromium.org, david@ixit.cz, krzysztof.kozlowski+dt@linaro.org, swboyd@chromium.org, konrad.dybcio@somainline.org, agross@kernel.org, andersson@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221220123634.382970-1-bryan.odonoghue@linaro.org> <20221220123634.382970-9-bryan.odonoghue@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221220123634.382970-9-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/12/2022 13:36, Bryan O'Donoghue wrote: > When converting from .txt to .yaml we didn't include descriptions for the > existing regulator supplies. > > - vdd > - vdda > - vddio > > Add those descriptions into the yaml now as they were prior to the > conversion. In the .txt description we marked these regulators as required, > however, that requirement appears to have been in error. > > Taking the example of sc7180-trogdor-wormdingler.dtsi. The avdd and avee > come from GPIO controlled external regulators, not the SoC and in this case > there's no need for vddio to power an I/O bus. Similarly the regulators for > the LCD are controlled by the panel driver not by the dsi-ctrl driver. > > It would be possible to connect a different type of panel to the DSI bus > here in which case we may or may not want to make use of vdd, vdda or > vddio. > > This is also the case for older chipsets like apq8064, msm8916 etc the vdd* > regulators in the dsi-ctrl block are helpers not dependencies. > > Add the description of vdd, vdda and vddio back in for the existing > upstream dts where vdd, vdda or vddio are already declared but, don't > declare those regulators required - they are not SoC requirements. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") > Signed-off-by: Bryan O'Donoghue You got here ack, didn't you? Best regards, Krzysztof