* [PATCH 1/1] dt-bindings: input: convert lpc32xx-key.txt to yaml format
@ 2025-06-24 20:06 Frank Li
2025-06-27 20:30 ` Rob Herring
2025-06-28 1:05 ` Vladimir Zapolskiy
0 siblings, 2 replies; 3+ messages in thread
From: Frank Li @ 2025-06-24 20:06 UTC (permalink / raw)
To: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vladimir Zapolskiy, Piotr Wojtaszczyk,
open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/LPC32XX SOC SUPPORT, open list
Cc: imx
Convert lpc32xx-key.txt to yaml format.
Additional changes:
- set maximum of key-row(column) to 4.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
.../devicetree/bindings/input/lpc32xx-key.txt | 34 ----------
.../bindings/input/nxp,lpc3220-key.yaml | 66 +++++++++++++++++++
2 files changed, 66 insertions(+), 34 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/input/lpc32xx-key.txt
create mode 100644 Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml
diff --git a/Documentation/devicetree/bindings/input/lpc32xx-key.txt b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
deleted file mode 100644
index 2b075a080d303..0000000000000
--- a/Documentation/devicetree/bindings/input/lpc32xx-key.txt
+++ /dev/null
@@ -1,34 +0,0 @@
-NXP LPC32xx Key Scan Interface
-
-This binding is based on the matrix-keymap binding with the following
-changes:
-
-Required Properties:
-- compatible: Should be "nxp,lpc3220-key"
-- reg: Physical base address of the controller and length of memory mapped
- region.
-- interrupts: The interrupt number to the cpu.
-- clocks: phandle to clock controller plus clock-specifier pair
-- nxp,debounce-delay-ms: Debounce delay in ms
-- nxp,scan-delay-ms: Repeated scan period in ms
-- linux,keymap: the key-code to be reported when the key is pressed
- and released, see also
- Documentation/devicetree/bindings/input/matrix-keymap.txt
-
-Note: keypad,num-rows and keypad,num-columns are required, and must be equal
-since LPC32xx only supports square matrices
-
-Example:
-
- key@40050000 {
- compatible = "nxp,lpc3220-key";
- reg = <0x40050000 0x1000>;
- clocks = <&clk LPC32XX_CLK_KEY>;
- interrupt-parent = <&sic1>;
- interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
- keypad,num-rows = <1>;
- keypad,num-columns = <1>;
- nxp,debounce-delay-ms = <3>;
- nxp,scan-delay-ms = <34>;
- linux,keymap = <0x00000002>;
- };
diff --git a/Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml b/Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml
new file mode 100644
index 0000000000000..5ab6cefd35fa3
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/nxp,lpc3220-key.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP LPC32xx Key Scan Interface
+
+maintainers:
+ - Frank Li <Frank.Li@nxp.com>
+
+properties:
+ compatible:
+ const: nxp,lpc3220-key
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ keypad,num-rows:
+ maximum: 4
+
+ keypad,num-columns:
+ maximum: 4
+
+ nxp,debounce-delay-ms:
+ description: Debounce delay in ms
+
+ nxp,scan-delay-ms:
+ description: Repeated scan period in ms
+
+ linux,keymap: true
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - nxp,debounce-delay-ms
+ - nxp,scan-delay-ms
+ - linux,keymap
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/clock/lpc32xx-clock.h>
+
+ key@40050000 {
+ compatible = "nxp,lpc3220-key";
+ reg = <0x40050000 0x1000>;
+ clocks = <&clk LPC32XX_CLK_KEY>;
+ interrupt-parent = <&sic1>;
+ interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
+ keypad,num-rows = <1>;
+ keypad,num-columns = <1>;
+ nxp,debounce-delay-ms = <3>;
+ nxp,scan-delay-ms = <34>;
+ linux,keymap = <0x00000002>;
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dt-bindings: input: convert lpc32xx-key.txt to yaml format
2025-06-24 20:06 [PATCH 1/1] dt-bindings: input: convert lpc32xx-key.txt to yaml format Frank Li
@ 2025-06-27 20:30 ` Rob Herring
2025-06-28 1:05 ` Vladimir Zapolskiy
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2025-06-27 20:30 UTC (permalink / raw)
To: Frank Li
Cc: Dmitry Torokhov, Krzysztof Kozlowski, Conor Dooley,
Vladimir Zapolskiy, Piotr Wojtaszczyk,
open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/LPC32XX SOC SUPPORT, open list, imx
On Tue, Jun 24, 2025 at 04:06:58PM -0400, Frank Li wrote:
> Convert lpc32xx-key.txt to yaml format.
>
> Additional changes:
> - set maximum of key-row(column) to 4.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../devicetree/bindings/input/lpc32xx-key.txt | 34 ----------
> .../bindings/input/nxp,lpc3220-key.yaml | 66 +++++++++++++++++++
> 2 files changed, 66 insertions(+), 34 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/input/lpc32xx-key.txt
> create mode 100644 Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/lpc32xx-key.txt b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> deleted file mode 100644
> index 2b075a080d303..0000000000000
> --- a/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -NXP LPC32xx Key Scan Interface
> -
> -This binding is based on the matrix-keymap binding with the following
> -changes:
> -
> -Required Properties:
> -- compatible: Should be "nxp,lpc3220-key"
> -- reg: Physical base address of the controller and length of memory mapped
> - region.
> -- interrupts: The interrupt number to the cpu.
> -- clocks: phandle to clock controller plus clock-specifier pair
> -- nxp,debounce-delay-ms: Debounce delay in ms
> -- nxp,scan-delay-ms: Repeated scan period in ms
> -- linux,keymap: the key-code to be reported when the key is pressed
> - and released, see also
> - Documentation/devicetree/bindings/input/matrix-keymap.txt
> -
> -Note: keypad,num-rows and keypad,num-columns are required, and must be equal
> -since LPC32xx only supports square matrices
> -
> -Example:
> -
> - key@40050000 {
> - compatible = "nxp,lpc3220-key";
> - reg = <0x40050000 0x1000>;
> - clocks = <&clk LPC32XX_CLK_KEY>;
> - interrupt-parent = <&sic1>;
> - interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> - keypad,num-rows = <1>;
> - keypad,num-columns = <1>;
> - nxp,debounce-delay-ms = <3>;
> - nxp,scan-delay-ms = <34>;
> - linux,keymap = <0x00000002>;
> - };
> diff --git a/Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml b/Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml
> new file mode 100644
> index 0000000000000..5ab6cefd35fa3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/nxp,lpc3220-key.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP LPC32xx Key Scan Interface
> +
> +maintainers:
> + - Frank Li <Frank.Li@nxp.com>
You need a $ref to matrix-keymap.yaml
> +
> +properties:
> + compatible:
> + const: nxp,lpc3220-key
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + keypad,num-rows:
> + maximum: 4
> +
> + keypad,num-columns:
> + maximum: 4
> +
> + nxp,debounce-delay-ms:
> + description: Debounce delay in ms
> +
> + nxp,scan-delay-ms:
> + description: Repeated scan period in ms
> +
> + linux,keymap: true
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - nxp,debounce-delay-ms
> + - nxp,scan-delay-ms
> + - linux,keymap
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/clock/lpc32xx-clock.h>
> +
> + key@40050000 {
> + compatible = "nxp,lpc3220-key";
> + reg = <0x40050000 0x1000>;
> + clocks = <&clk LPC32XX_CLK_KEY>;
> + interrupt-parent = <&sic1>;
> + interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> + keypad,num-rows = <1>;
> + keypad,num-columns = <1>;
> + nxp,debounce-delay-ms = <3>;
> + nxp,scan-delay-ms = <34>;
> + linux,keymap = <0x00000002>;
> + };
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dt-bindings: input: convert lpc32xx-key.txt to yaml format
2025-06-24 20:06 [PATCH 1/1] dt-bindings: input: convert lpc32xx-key.txt to yaml format Frank Li
2025-06-27 20:30 ` Rob Herring
@ 2025-06-28 1:05 ` Vladimir Zapolskiy
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Zapolskiy @ 2025-06-28 1:05 UTC (permalink / raw)
To: Frank Li, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Piotr Wojtaszczyk,
open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/LPC32XX SOC SUPPORT, open list
Cc: imx
On 6/24/25 23:06, Frank Li wrote:
> Convert lpc32xx-key.txt to yaml format.
>
> Additional changes:
> - set maximum of key-row(column) to 4.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
<snip>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-28 1:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-24 20:06 [PATCH 1/1] dt-bindings: input: convert lpc32xx-key.txt to yaml format Frank Li
2025-06-27 20:30 ` Rob Herring
2025-06-28 1:05 ` Vladimir Zapolskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).