From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 560EE1C2A3 for ; Tue, 18 Jun 2024 12:08:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718712520; cv=none; b=cbyGiEgjBiqxV9JGIX/3q/8UYU+lTegCmvj+rBTXX8V8cAvXF3Epc+g1DGCUffHd/pj5wOVPI1rxBfI48u8I/QIrvNJ5MuK5nVko4MTvXzbhuIyZWUr+DyUYSPdZv5ts4WLwq2RxuarM/o3sL4PDOfdfOhE4/Fh+TV9I94cux4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718712520; c=relaxed/simple; bh=Yckx3myiIKBg0+WTmA44vy1MYQpPyh6BkmCRseR89ec=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hGORwmXmaZJt0qU0jr1IT6jQdwKy7j653EB/GL/mXDbHAxbXS3v6ulm2FqC6vOUoK/hoYsNTLtoPfzCWDuCVoKtC+BSWaGMjPG1BtDJjjTDDBXZGp+KAqVaZOJ8dt/7CJlBhI2+CQRuAiu5XNeXJa7VvEnvw0Jiu0whiCgOBKvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=j/rTMOoD; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="j/rTMOoD" X-Envelope-To: angelogioacchino.delregno@collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718712516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yaKJZwFY6wd1XllaZI8jJVrOqSqeE2cUrM2G+oq1sR8=; b=j/rTMOoDPWYTSlPp2VdJOuT37Q5uAFN8Tsg2EsV4sQIiUaqK5GIq+iAvEYNMRfLEBFuDbP LlqVT/U0m+nFky/pdYKC+SbgxAKwWl3f41XmPGY67FTxWMB4Lu+6+7yUqjrK8WTXY4OUj3 UpgZf3YfifUlrEGqe1S6OLCQ/0McQeM= X-Envelope-To: chunkuang.hu@kernel.org X-Envelope-To: robh@kernel.org X-Envelope-To: krzysztof.kozlowski+dt@linaro.org X-Envelope-To: conor+dt@kernel.org X-Envelope-To: p.zabel@pengutronix.de X-Envelope-To: airlied@gmail.com X-Envelope-To: daniel@ffwll.ch X-Envelope-To: maarten.lankhorst@linux.intel.com X-Envelope-To: mripard@kernel.org X-Envelope-To: tzimmermann@suse.de X-Envelope-To: matthias.bgg@gmail.com X-Envelope-To: shawn.sung@mediatek.com X-Envelope-To: yu-chang.lee@mediatek.com X-Envelope-To: ck.hu@mediatek.com X-Envelope-To: jitao.shi@mediatek.com X-Envelope-To: devicetree@vger.kernel.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: dri-devel@lists.freedesktop.org X-Envelope-To: linux-mediatek@lists.infradead.org X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: wenst@chromium.org X-Envelope-To: kernel@collabora.com X-Envelope-To: michael@walle.cc X-Envelope-To: amergnat@baylibre.com Message-ID: Date: Tue, 18 Jun 2024 20:08:25 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v8 3/3] drm/mediatek: Implement OF graphs support for display paths To: AngeloGioacchino Del Regno , chunkuang.hu@kernel.org Cc: robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, matthias.bgg@gmail.com, shawn.sung@mediatek.com, yu-chang.lee@mediatek.com, ck.hu@mediatek.com, jitao.shi@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, wenst@chromium.org, kernel@collabora.com, michael@walle.cc, Alexandre Mergnat References: <20240618101726.110416-1-angelogioacchino.delregno@collabora.com> <20240618101726.110416-4-angelogioacchino.delregno@collabora.com> Content-Language: en-US, en-AU X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <20240618101726.110416-4-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Hi, On 6/18/24 18:17, AngeloGioacchino Del Regno wrote: > It is impossible to add each and every possible DDP path combination > for each and every possible combination of SoC and board: right now, > this driver hardcodes configuration for 10 SoCs and this is going to > grow larger and larger, and with new hacks like the introduction of > mtk_drm_route which is anyway not enough for all final routes as the > DSI cannot be connected to MERGE if it's not a dual-DSI, or enabling > DSC preventively doesn't work if the display doesn't support it, or > others. > > Since practically all display IPs in MediaTek SoCs support being > interconnected with different instances of other, or the same, IPs > or with different IPs and in different combinations, the final DDP > pipeline is effectively a board specific configuration. > > Implement OF graphs support to the mediatek-drm drivers, allowing to > stop hardcoding the paths, and preventing this driver to get a huge > amount of arrays for each board and SoC combination, also paving the > way to share the same mtk_mmsys_driver_data between multiple SoCs, > making it more straightforward to add support for new chips. > > Reviewed-by: Alexandre Mergnat > Tested-by: Alexandre Mergnat > Signed-off-by: AngeloGioacchino Del Regno Acked-by: Sui Jingfeng