From: "Vokáč Michal" <Michal.Vokac@ysoft.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards
Date: Tue, 11 Dec 2018 13:46:30 +0000 [thread overview]
Message-ID: <dc1db0e2-b9a6-8624-4be5-8b3719d99f4b@ysoft.com> (raw)
In-Reply-To: <20181211123640.GC4632@lunn.ch>
On 11.12.2018 13:36, Andrew Lunn wrote:
>>> Hi Rob, gentle ping on this.
>>>
>>> I would like to be sure how to proceed with this. Do you really want me
>>> to move *all* nodes that are disabled in this common dtsi into the per
>>> board dts?
>>>
>>> All the boards use identical PCB. Anything that is disabled here is not
>>> present on at least one of the boards. It means it is routed on the
>>> board and the SoC has the capability but the parts are not populated.
>>>
>>> So it is not only about the LED controller. What about the LCD, OLED,
>>> backlight, USB..?
>>
>> Can anybody advice how to split these dts/dtsi files, please?
>> I am not sure what should reside in the common dtsi and what should
>> be moved into the per board dts in case my current solution is not
>> appropriate.
>
> The kirkwood-synology.dtsi might be of interest? There are a lot of
> Synology NAS boxes which share a lot in common. So all the common
> parts are in that .dtsi. The .dbs file for each individual model then
> enables the parts its needs.
That is a great example Andrew, thank you! That is exactly what I am
doing. Everything that is supported by the PCB/platform is specified
in the common file. Only parts that are populated on all products are
enabled there, the other stuff is disabled. The .dts files then enable
additional stuff they need.
To me it seems reasonable to do it that way and maybe I only
misunderstood what Rob actually meant by his comment? I still do not
have his reply to that though.
> Although you have one PCB, or the different population options
> considered different products, each with there own name?
Yes, each of the three population options can be considered a different
product with different name. That is still the same as the Synology
NAS boxes, right?
Michal
next prev parent reply other threads:[~2018-12-11 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 15:43 [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards Vokáč Michal
2018-11-12 16:41 ` Rob Herring
2018-11-19 14:35 ` Vokáč Michal
2018-11-27 12:19 ` Vokáč Michal
2018-12-11 9:27 ` Vokáč Michal
2018-12-11 12:36 ` Andrew Lunn
2018-12-11 13:46 ` Vokáč Michal [this message]
2018-11-28 2:39 ` Shawn Guo
2018-11-28 8:23 ` Vokáč Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc1db0e2-b9a6-8624-4be5-8b3719d99f4b@ysoft.com \
--to=michal.vokac@ysoft.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).