From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B589FC433EF for ; Tue, 12 Jul 2022 16:32:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231273AbiGLQc1 (ORCPT ); Tue, 12 Jul 2022 12:32:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbiGLQc0 (ORCPT ); Tue, 12 Jul 2022 12:32:26 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4180CCB476 for ; Tue, 12 Jul 2022 09:32:25 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id y11so8313986lfs.6 for ; Tue, 12 Jul 2022 09:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=bGU0yXesemRThSvHGP4URgc+lQcVUG1tVloK/aCPF+s=; b=LdcYHBSVEo9pFeFsLsb9svxhl3ksXrKn+bSRtdCJl93S3DP0k0R8a0GFyUqvmz5AGT uqG+zDUzzlNas8knMHcjbFRnOaV6boVSZlpgcaJln37yQDV6KM8iDejLaQ4OaiTRCy+g mz3Ck76y1aNFzPlFFAqNQNP+RdudRMK5noFDSC93yPsckPhCD/+PEJvwahdxSOn9N6pn CtKYt3u6x7gbkw6+mwHGkUrqPOQNRD/N+FwL62oMLQ3sAuh1JkGudJWWY11wzyvntHSP F18sz9j3dRL0rY90cfHXt5n0wqQE2qxKi8MbEdsY2lyglIObO1B65sn0f1OlOxVqDa5K UC3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bGU0yXesemRThSvHGP4URgc+lQcVUG1tVloK/aCPF+s=; b=hSbu6HrO2hya7vX+wiz/VI9wRh8h4C2O1d+VXoQ6i4eBFC5LGGPdMKp+B5MNwf+x73 wUNw4fFo+aD32w0oNihe+T50ei7YzC8XNO0cbs54Kwf3Bk9OOlfrygQriIembsRjiIXh kNrh4j9Rh60mu6ezm6bDDTuzXw1YsGxKoRQlaJ18vxcJhLo577n+5/lpfgab4HDxXTYm plCEA6c1rZpi1lQk7+2gZ6oj0Khn7gREakW4dzM8F2gX7ekz9uaPrxBPbHJRvCEHJHJ2 9o1LD4Ym6JYwhMfO9smrKMP/GEElfvvPiFDfz4ojjhL7cr5aVu3/ANcyibGEgpDhq9rJ eErw== X-Gm-Message-State: AJIora8wuAMsLmlhWCT6xkU2uo/gnT644tsnLj3+eah0GQZJ6kgmRXSL Pn/MWbCz5y8wMOJSO8iN5eglRQ== X-Google-Smtp-Source: AGRyM1tRmrglXSwIf2mjhymrTfdr0BxGH2TkYY7cXGNmj1tK75CzEIgDKoisOCiHoVLqaoQr58IZdg== X-Received: by 2002:a05:6512:2254:b0:489:d168:20cf with SMTP id i20-20020a056512225400b00489d16820cfmr9867374lfu.97.1657643543577; Tue, 12 Jul 2022 09:32:23 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id p21-20020a056512235500b0047255d210easm2273054lfu.25.2022.07.12.09.32.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 09:32:22 -0700 (PDT) Message-ID: Date: Tue, 12 Jul 2022 18:32:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] spi: dt-bindings: atmel,at91rm9200-spi: convert to json-schema Content-Language: en-US To: Sergiu Moga , broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kavyasree.Kotagiri@microchip.com, UNGLinuxDriver@microchip.com, tudor.ambarus@microchip.com References: <20220712162554.148741-1-sergiu.moga@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20220712162554.148741-1-sergiu.moga@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/07/2022 18:25, Sergiu Moga wrote: > Convert SPI DT binding for Atmel/Microchip SoCs to json-schema. > > Signed-off-by: Sergiu Moga > Reviewed-by: Krzysztof Kozlowski > --- > > v1 -> v2: > - change subject headline prefix from "dt-bindings: spi" to "spi: atmel" > - change maintainer > - kept the compatbile as items (instead of switching to enums) and at91rm9200 > as fallback for sam9x60, since the evolution of IP's is incremental. > - removed unnecessay "cs-gpios" property and descriptions > - added min/max for fifo-size property. > > > v2 -> v3: > - change subject headline prefix from "spi: atmel" to > "spi: dt-bindings: atmel,at91rm9200-spi: convert to json-schema" > - use enum instead of a range for "atmel,fifo-size" > > > .../bindings/spi/atmel,at91rm9200-spi.yaml | 76 +++++++++++++++++++ > .../devicetree/bindings/spi/spi_atmel.txt | 36 --------- > 2 files changed, 76 insertions(+), 36 deletions(-) > create mode 100644 Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > delete mode 100644 Documentation/devicetree/bindings/spi/spi_atmel.txt > > diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > new file mode 100644 > index 000000000000..084897cc8f66 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/atmel,spi.yaml# You need to test the bindings. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel SPI device > + > +maintainers: > + - Tudor Ambarus > + > +allOf: > + - $ref: spi-controller.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: I missed that part - this is one item, so no "items". Best regards, Krzysztof