From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61232C71153 for ; Tue, 29 Aug 2023 17:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236747AbjH2RlP (ORCPT ); Tue, 29 Aug 2023 13:41:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238083AbjH2Rky (ORCPT ); Tue, 29 Aug 2023 13:40:54 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4949311B for ; Tue, 29 Aug 2023 10:40:51 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-99c136ee106so610171166b.1 for ; Tue, 29 Aug 2023 10:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693330850; x=1693935650; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2YNG7LD4K4KMxQp5UZSaL2MeLl8EFjm+UQ/TTjynihU=; b=KmEE7T5sialkQHA7uBm2PpWGs/ZGGqTq02s3Yw33ntN7nH7hF0rgTi6bhJcVRe0gUe n+7sXgY6R0X4sM3t9RrhSbtnj1wj7FIQhMmE+9XbqiOINprzleLlQnHZZBesnITHn/JB pvbJMvr+iOoS1qtKvP5amQio1ol8/VZSIUFHmJha+u/9YBBRjtawNb1iBqmCZTAI9U+6 /EGo39TLk1NruxXYkr9na91s/mrhZkDa+aQcVrmEyH+0M/gX2m6YCGUWPJwRwuTNSud8 Bh8WoteBLNLZbk9XMXJiCy0flgPIvNhFeKY9LCrheun1P9+mVwI9w0rCyGS3G9dzmVcQ dW+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693330850; x=1693935650; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2YNG7LD4K4KMxQp5UZSaL2MeLl8EFjm+UQ/TTjynihU=; b=bBbDRqTgs43IwWa8tuohh4h9XAVvL8Tng6N6OqPndTd9sQ61rQb0bFrpi1B0TeKLic FNkKmq47TtshvkC9gG+/1oCcGzz2WqrefCOkX0lCkPAXO4ZOH6leQBZZHPF+pABlgvHy tgnN0ayF1bhnmF4L2DUNlkuzS7oTEKYU6gT8oMLoJRctL31vb12bLc1CKKS6fu78S90b +KEDojcjGVh4NndPxxFeKRsb+jl9i/Hw37Q9c44k9v+MhUeT6eKz8J4aot4Y36jygMy6 g8OFYcb/upKvZZpVL1pqCv9zgUsN7ahpY3zKYm3mV6y+8iTrMGVwqGIDhtHYeZ3fY4VO xSdw== X-Gm-Message-State: AOJu0YxqWeHs0zjKd7UagcOdtQw8LsVtpPtEmFxhcTu0Y2Oq4XsyYCn0 bfp5e93NputML6E8zcC5IcTWVQ== X-Google-Smtp-Source: AGHT+IEitwmwVk9+KoKIBEHpiME/Abb3aHzRC9tehqbQ93vUndcYPbpMcUZcdG971B60lRyMIL5+mA== X-Received: by 2002:a17:906:256:b0:9a1:cccb:5429 with SMTP id 22-20020a170906025600b009a1cccb5429mr17132480ejl.15.1693330849791; Tue, 29 Aug 2023 10:40:49 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.196]) by smtp.gmail.com with ESMTPSA id f17-20020a17090624d100b0099cb0a7098dsm6285502ejb.19.2023.08.29.10.40.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Aug 2023 10:40:49 -0700 (PDT) Message-ID: Date: Tue, 29 Aug 2023 19:40:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 05/31] clk: rockchip: rk3128: Fix aclk_peri_src parent Content-Language: en-US To: Alex Bee , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Airlie , Daniel Vetter , Lee Jones , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Vinod Koul , Kishon Vijay Abraham I Cc: Elaine Zhang , Johan Jonker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org, linux-clk@vger.kernel.org, linux-phy@lists.infradead.org, Finley Xiao References: <20230829171647.187787-1-knaerzche@gmail.com> <20230829171647.187787-6-knaerzche@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230829171647.187787-6-knaerzche@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/08/2023 19:16, Alex Bee wrote: > From: Finley Xiao > > According to the TRM there are no specific cpll_peri, gpll_div2_peri or > gpll_div3_peri gates, but a single clk_peri_src gate and the peri mux > directly connects to the plls respectivly the pll divider clocks. > Fix this by creating a single gated composite. > > Also rename all occurrences of "aclk_peri_src*" to clk_peri_src, since it > is the parent for both peri aclks and hclks and that also matches the > naming in the TRM. > > Fixes: f6022e88faca ("clk: rockchip: add clock controller for rk3128") > Signed-off-by: Finley Xiao > [renamed aclk_peri_src -> clk_peri_src and added commit message] > Signed-off-by: Alex Bee Please send fixes as separate patchset. Don't mix it with other work and definitely it should not be in the middle of the patchset. Best regards, Krzysztof