From: Yixun Lan <yixun.lan@amlogic.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
Kevin Hilman <khilman@baylibre.com>
Cc: yixun.lan@amlogic.com, Jerome Brunet <jbrunet@baylibre.com>,
Carlo Caione <carlo@caione.org>, Jian Hu <jian.hu@amlogic.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: i2c: update documentation for the Meson-AXG
Date: Fri, 17 Nov 2017 21:47:14 +0800 [thread overview]
Message-ID: <dc339e2a-d8ab-7412-0c9e-bf4d052fc17e@amlogic.com> (raw)
In-Reply-To: <03c9ea24-5f8d-f5dd-6e96-f53f56db530c@baylibre.com>
Hi Neil
On 11/17/17 21:02, Neil Armstrong wrote:
> On 17/11/2017 09:02, Yixun Lan wrote:
>> From: Jian Hu <jian.hu@amlogic.com>
>>
>> Update the doc to explicitly add Meson-AXG to support list
>>
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
>> ---
>> Documentation/devicetree/bindings/i2c/i2c-meson.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-meson.txt b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
>> index 611b934c7e10..3097d2b44dad 100644
>> --- a/Documentation/devicetree/bindings/i2c/i2c-meson.txt
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
>> @@ -2,6 +2,7 @@ Amlogic Meson I2C controller
>>
>> Required properties:
>> - compatible: must be "amlogic,meson6-i2c" or "amlogic,meson-gxbb-i2c"
>> + "amlogic,meson-axg-i2c"
>
> Hi Yixun, Jian,
>
> Maybe you should reformat by using :
> - compatible: must be :
> "amlogic,meson6-i2c" for Meson8 and compatible SoCs
> "amlogic,meson-gxbb-i2c" for GXBB and compatible SoCs
> "amlogic,meson-axg-i2c"for AXG and compatible SoCs
>
> Neil
>
sure, we can do this.
thanks for the review
>> - reg: physical address and length of the device registers
>> - interrupts: a single interrupt specifier
>> - clocks: clock for the device
>>
>
> .
>
next prev parent reply other threads:[~2017-11-17 13:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 8:02 [PATCH 0/5] i2c: meson-axg: add I2C controller driver Yixun Lan
2017-11-17 8:02 ` [PATCH 1/5] dt-bindings: i2c: update documentation for the Meson-AXG Yixun Lan
2017-11-17 13:02 ` Neil Armstrong
2017-11-17 13:47 ` Yixun Lan [this message]
2017-11-17 8:02 ` [PATCH 2/5] i2c: meson: add configurable divider factors Yixun Lan
2017-11-17 13:02 ` Neil Armstrong
2017-11-17 20:32 ` Martin Blumenstingl
2017-11-17 8:02 ` [PATCH 3/5] ARM64: dts: meson-axg: add I2C DT info for Meson-AXG SoC Yixun Lan
2017-11-17 13:05 ` Neil Armstrong
[not found] ` <96dc68e3-c394-70c4-eabe-f59d4c36150e-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-11-17 14:02 ` Yixun Lan
2017-11-17 8:02 ` [PATCH 4/5] ARM64: dts: meson-axg: describe pin DT info for I2C controller Yixun Lan
2017-11-17 13:06 ` Neil Armstrong
2017-11-17 8:02 ` [PATCH 5/5] ARM64: dts: meson-axg: enable I2C Master-1 for the audio speaker Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc339e2a-d8ab-7412-0c9e-bf4d052fc17e@amlogic.com \
--to=yixun.lan@amlogic.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).