From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH] arm: dts: mt7623: enable all four available UARTs on bananapi-r2 Date: Sat, 23 Dec 2017 08:52:02 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 12/22/2017 07:06 AM, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > From: Sean Wang > > On bpi-r2 board, totally there're four uarts which we usually called > uart[0-3] helpful to extend slow I/O devices. Among those ones, uart2 has > dedicated pin slot which is used to conolse log. uart[0-1] appear at the > 40-pins connector and uart3 has no pinout, but just has test points (TP47 > for TX and TP48 for RX, respectively) nearby uart2. Also, some missing > pinctrl is being complemented for those devices. > > Signed-off-by: Sean Wang > --- > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > index 7bf5aa2..64bf5db 100644 > --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > @@ -409,6 +409,20 @@ > ; > }; > }; > + > + uart2_pins_a: uart@2 { > + pins_dat { > + pinmux = , > + ; > + }; > + }; > + > + uart3_pins_a: uart@3 { > + pins_dat { > + pinmux = , > + ; > + }; > + }; > }; > > &pwm { > @@ -454,16 +468,24 @@ > &uart0 { > pinctrl-names = "default"; > pinctrl-0 = <&uart0_pins_a>; > - status = "disabled"; > + status = "okay"; > }; > > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&uart1_pins_a>; > - status = "disabled"; > + status = "okay"; > }; > > &uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart2_pins_a>; > + status = "okay"; > +}; > + > +&uart3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart3_pins_a>; > status = "okay"; > }; > Why do we want to enable uart3 when there are only test points? It is not very useful, or do I oversee something? Regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html