From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E820C3DA78 for ; Sun, 15 Jan 2023 15:13:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230327AbjAOPNr (ORCPT ); Sun, 15 Jan 2023 10:13:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231197AbjAOPNq (ORCPT ); Sun, 15 Jan 2023 10:13:46 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24B50CDE6 for ; Sun, 15 Jan 2023 07:13:44 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id qx13so4340616ejb.13 for ; Sun, 15 Jan 2023 07:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aFcwOmEFlKwz+PgBDJg3oPEza0ShiNrJoHvCTAjQ6D0=; b=u5MeUGD1SllOGGSGeF0Ev6qqHPNz8QOA87zzGYt0CikM0TX9RbBDUdxzGXGov+KrSz /sAWYXqTulK7wz3AHsnsxRrUAtt9Czrg/Uio30iZp3W6q2f9Q/UDxS1n1wWn0nq0efoI TVXOiWyEPV4CdpJvDJnaDnqEHWhay/21Fk4TS57l2L7ai2BZACO71+ztpRj5Xrh/SdU5 fHnOV9N+YJZAGCA3+5I7h/Xrzn4W9IYiG1VvX5lmeLQXILvOFSYq1M0cSvK9NOBDx0U8 A3+XXIkZpuLFZxlGDs9JxLvHFbU80lA0NxoEGmXIOaKN7yeraJnRcn7YTNVxk3HPKGQX wyng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aFcwOmEFlKwz+PgBDJg3oPEza0ShiNrJoHvCTAjQ6D0=; b=frSr1+BFU7Y/yE86TihQ48gCyFULMxuRJ6UL4RbsahbKKoKCv3Qe34PbeItZ+Yg2Aw +c9lIrxZX/0hh/x0siwI2mVdbDMlhrsUcG7QawEbqaW6xFqR1jo0Q7fQPzmP27Lu1zwM MwyG+onQKd8X/svQknxjWlLyWybSGtP7VVgpsKl7lf8aRwJQFCpCCLLAenpf2U9fyss/ X3eWIPSfnugsqz7lG3IyobAGbXrVfxaNxNeNh/dL0XQU5X3NZbkOwGXNyZvg3vyNbxhj frIrjBZ1zvIR69myp/+KaPLStqhMi/ZEf+cKCnhFh15qBhzUBJ6ERQxMNOPnf1g9rnXY 3j6w== X-Gm-Message-State: AFqh2kqPz3T99zc8m7jj0UtuUCXQv3xEfhNZvU6Lch3S7TpfK29ddeDM ODjIb0EJ4iQstsYUqPZTT2qfVQ== X-Google-Smtp-Source: AMrXdXu/F/jtw1O3KaRZM9kWFq1sZIWwFot/ex8kGfpUsTUc8dsdAEHIVbOCwskmw4xisrO7ttRaGQ== X-Received: by 2002:a17:906:6881:b0:84d:4d6c:a462 with SMTP id n1-20020a170906688100b0084d4d6ca462mr21181417ejr.25.1673795622740; Sun, 15 Jan 2023 07:13:42 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id e2-20020a170906314200b007c08439161dsm10694392eje.50.2023.01.15.07.13.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Jan 2023 07:13:42 -0800 (PST) Message-ID: Date: Sun, 15 Jan 2023 16:13:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sc7280: Add cpu and llcc BWMON (=> interconnect issue) Content-Language: en-US To: Matthias Kaehlcke , Rajendra Nayak , Georgi Djakov Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Douglas Anderson , Stephen Boyd References: <20220902043511.17130-1-quic_rjendra@quicinc.com> <20220902043511.17130-5-quic_rjendra@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/01/2023 19:18, Matthias Kaehlcke wrote: > Hi, > > On Fri, Sep 02, 2022 at 10:05:11AM +0530, Rajendra Nayak wrote: >> Add cpu and llcc BWMON nodes and their corresponding >> OPP tables for sc7280 SoC. >> >> Signed-off-by: Rajendra Nayak >> Reviewed-by: Krzysztof Kozlowski > > I found that with a v6.1 kernel AOSS on sc7280 doesn't reach it's low > power state during system. This can be observed on herobrine based > boards on which the AP_SUSPEND signal should transition to 1 during > system suspend. If it doesn't the Embedded Controller (EC) notices > it and wakes the system up again. > > Bisection points to this patch, the issue only occurs when > CONFIG_QCOM_ICC_BWMON is *not* set. One might think the patch shouldn't > have any impact at all when the driver is not enabled, but it does. > > Debugging shows that the issue is interconnect related. A bare platform > device is created for each bwmon devices, which results in the average > and peak bandwidth of the interconnect link to be set 'initially' to > INT_MAX. The driver is supposed to call icc_sync_state() during probe, This is for interconnect providers, not consumers. > which would set the initially bandwidths to 0 and determine the actually > needed bandwidth. But since the driver isn't probed the initial > bandwidths stay at INT_MAX. > > This isn't actually an issue with this patch, but how the interconnect > framework deals with devices that are registered on the bus, but aren't > probed (yet). Not sure how this would be best fixed. Georgi, do you have > any ideas? Why the device is not probed (yet)? If it is registered, it will come soon during boot up. Best regards, Krzysztof