From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8132C4332F for ; Thu, 3 Nov 2022 17:53:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231168AbiKCRxf (ORCPT ); Thu, 3 Nov 2022 13:53:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbiKCRxd (ORCPT ); Thu, 3 Nov 2022 13:53:33 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E6761A05F for ; Thu, 3 Nov 2022 10:53:33 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id y13so2310054pfp.7 for ; Thu, 03 Nov 2022 10:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Gh4tHwGdYqiA6FfBVtb4eaTZECdeDr+dtEfH6mIg700=; b=WiDvzWb07Nd95ou0RXLpYHaRo0kqVVVo4n0ExPUJKESfL6TOqXt408h6C23wWmKp30 y53OsxEJOr2nNl1zjx+MOeonIGReZVmncVdT3AKaX4T6VpduRz0TcpNeGPdLMLAcc8ZJ lYAGFpMAvDJnVY3BpApDarK+s8PlKyvls1lTwv4JzGXxExA2TERW6nphT5UI8TuNNMYP pLC4P26Jt+2epBkG4bCuqbsG5jospL06fhiTw4JmaCpPJ80cIFRXmw2bCJVbdb5H1W9E hHt7GfPG4A4Myu29eLDVDtCCi3OmiQaW5ZyqRjv3BpAzuKQXeDQi/XEOrn7jGfVtDo9k b9MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gh4tHwGdYqiA6FfBVtb4eaTZECdeDr+dtEfH6mIg700=; b=rfYdeqVJZYdfNQFI2wCgpD9R6gYRFlSubHTCwhVG8VGuu93NNuBcX7yjylMcej4Ujb VSvOzkw01weAOIjKoVTivzISU4jGpaI3Ot9TaQoCKwmHtjsgDhdamqvQ81nio9ugulq7 EKS0QCiRCZMfwFdLK4qucX7Pt9nDI6MbZT04j5pS3FfLx4+b2jRi6QWOKbBo/7X7uNZL JHhSubz9jJsUpZjfrqyXZlFAgdtfrKgJ6IkzAms9qkQwOUvcR2WNm/GVlhGgN/WTTTM9 bSily+Mt0Dw5J6r7f1ydo9vgIps1f3KRlzQCPt4I6yi7nAGhvFVDoPGNKqhMnH3ulh41 fG6g== X-Gm-Message-State: ACrzQf3qRMnTQWynMfKlliTQ4mfcfS8XOZOCAiHbshTdCl7F4YF/YDn8 5gIVQftIpntSFktWphSvwcC7ZQ== X-Google-Smtp-Source: AMsMyM4ulepeXPsIA0hp3ORHkqmjCQ+/YpaBJ+3a+Y7uY7qnn6UlIRDNR9vuLc2PYRku4Evi49vFsg== X-Received: by 2002:a63:f50e:0:b0:470:274b:53a2 with SMTP id w14-20020a63f50e000000b00470274b53a2mr2355814pgh.524.1667498012612; Thu, 03 Nov 2022 10:53:32 -0700 (PDT) Received: from ?IPV6:2405:201:d02f:da6a:d4a2:1253:adfc:370? ([2405:201:d02f:da6a:d4a2:1253:adfc:370]) by smtp.gmail.com with ESMTPSA id o12-20020a170902d4cc00b00180cf894b67sm972393plg.130.2022.11.03.10.53.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 10:53:32 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 23:23:28 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 1/2] dt-bindings: mfd: Add bindings for MAX5970 and MAX5978 To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Lee Jones , Rob Herring , Krzysztof Kozlowski , Patrick Rudolph Cc: Marcello Sylvester Bauer References: <20221103080545.1400424-1-Naresh.Solanki@9elements.com> <20221103080545.1400424-2-Naresh.Solanki@9elements.com> <0c23e569-61e1-3eba-f9fc-4b42ed228b52@linaro.org> Content-Language: en-US From: Naresh Solanki In-Reply-To: <0c23e569-61e1-3eba-f9fc-4b42ed228b52@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On 03-11-2022 06:43 pm, Krzysztof Kozlowski wrote: >> +examples: >> + - | >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + regulator@3a { >> + compatible = "maxim,max5978"; >> + reg = <0x3a>; >> + vss1-supply = <&p3v3>; >> + >> + regulators { >> + sw0_ref_0: SW0 { > No improvements here. I've addressed 4 space indentation, bindings are matched, compatible is moved to first, then reg then the rest.