From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>, Rob Herring <robh@kernel.org>
Cc: mturquette@baylibre.com, sboyd@kernel.org,
krzysztof.kozlowski+dt@linaro.org, tali.perry1@gmail.com,
joel@jms.id.au, venture@google.com, yuenn@google.com,
benjaminfair@google.com, openbmc@lists.ozlabs.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v22 1/8] dt-bindings: clock: npcm845: Add reference 25m clock property
Date: Wed, 10 Jan 2024 21:54:14 +0100 [thread overview]
Message-ID: <dc739435-d955-44f7-b5ee-9de4d5336725@linaro.org> (raw)
In-Reply-To: <CAP6Zq1jCHVrFfRa6c3DZ4t2aaJTkWukeEkia0AqhzppC0mjbfg@mail.gmail.com>
On 10/01/2024 14:47, Tomer Maimon wrote:
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: refclk
>>> +
>>> '#clock-cells':
>>> const: 1
>>> description:
>>> @@ -30,12 +38,20 @@ properties:
>>> required:
>>> - compatible
>>> - reg
>>> + - clocks
>>> + - clock-names
>>
>> New required properties are an ABI break. That's fine if you explain why
>> that's okay in the commit msg.
> What do you mean?
I think it was clear. Which part is not clear?
> Could I add the new required properties to the required list?
You just did, didn't you? And received feedback that you are breaking
the ABI.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-10 20:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 13:54 [PATCH v22 0/8] Introduce Nuvoton Arbel NPCM8XX BMC SoC Tomer Maimon
2024-01-08 13:54 ` [PATCH v22 1/8] dt-bindings: clock: npcm845: Add reference 25m clock property Tomer Maimon
2024-01-08 21:09 ` Rob Herring
2024-01-09 6:45 ` Tomer Maimon
2024-01-09 17:08 ` Rob Herring
2024-01-10 13:47 ` Tomer Maimon
2024-01-10 20:54 ` Krzysztof Kozlowski [this message]
2024-01-10 21:45 ` Stephen Boyd
2024-01-16 15:21 ` Tomer Maimon
2024-01-08 13:54 ` [PATCH v22 2/8] arm64: dts: nuvoton: npcm8xx: add refernace clock Tomer Maimon
2024-01-08 13:54 ` [PATCH v22 3/8] arm: dts: nuvoton: npcm7xx: modify rst syscon node Tomer Maimon
2024-01-10 21:01 ` Krzysztof Kozlowski
2024-01-16 19:51 ` Tomer Maimon
2024-01-16 20:33 ` Krzysztof Kozlowski
2024-01-08 13:54 ` [PATCH v22 4/8] dt-bindings: soc: nuvoton: add binding for clock and reset registers Tomer Maimon
2024-01-10 20:59 ` Krzysztof Kozlowski
2024-01-16 19:02 ` Tomer Maimon
2024-01-16 20:37 ` Krzysztof Kozlowski
2024-01-22 17:14 ` Tomer Maimon
2024-01-24 14:21 ` Tomer Maimon
2024-01-08 13:54 ` [PATCH v22 5/8] arm64: dts: nuvoton: npcm8xx: add clock reset syscon node Tomer Maimon
2024-01-10 21:01 ` Krzysztof Kozlowski
2024-01-16 19:03 ` Tomer Maimon
2024-01-08 13:54 ` [PATCH v22 6/8] dt-bindings: clock: npcm845: replace reg with syscon property Tomer Maimon
2024-01-10 20:59 ` Krzysztof Kozlowski
2024-01-16 19:37 ` Tomer Maimon
2024-01-16 20:40 ` Krzysztof Kozlowski
2024-01-22 17:26 ` Tomer Maimon
2024-01-23 7:44 ` Krzysztof Kozlowski
2024-01-08 13:54 ` [PATCH v22 7/8] arm64: dts: nuvoton: npcm8xx: " Tomer Maimon
2024-01-10 20:59 ` Krzysztof Kozlowski
2024-01-16 19:39 ` Tomer Maimon
2024-01-16 20:41 ` Krzysztof Kozlowski
2024-01-08 13:54 ` [PATCH v22 8/8] clk: npcm8xx: add clock controller Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc739435-d955-44f7-b5ee-9de4d5336725@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).