From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCAF6C19F29 for ; Wed, 3 Aug 2022 06:11:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235733AbiHCGLJ (ORCPT ); Wed, 3 Aug 2022 02:11:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233832AbiHCGLI (ORCPT ); Wed, 3 Aug 2022 02:11:08 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 476341FCE5 for ; Tue, 2 Aug 2022 23:11:07 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id r14so17886113ljp.2 for ; Tue, 02 Aug 2022 23:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=QoMJEDXqR4eIF4IASWXdOokQ+55n5mDMby1kRaG/HSM=; b=OhJcdZq9zDydApto3QxFuxa9FqLO7pJWxzKfN2DV0yGhlBLC9EFrB9hSwYRUHyWfz7 OSsjTc8Hn9m5eZQzG8cI0MnIcVg9eyNhajmfcXpgfxDbwEB1T3rMFElhaIjQoHSo/WTJ NFYOzHs0Z67TWBlUGJxOgpSHxplYLxJtOb0N8iU8iNsHMmtFgL2IWq+mZusa3hzU49K6 nlf/maCe1y6OHkSX/p9UFzB1TVrAbINL2Wr1sFL0ulmHLMDdBQvfYBft2p/frxLNw9zA UHGyuZmaHaF39CAT4K+ZAyG9QsQCfeyHZH9CIGcvnG5N6fBAkhsv6KJt22GPRzoKXoBy GS6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=QoMJEDXqR4eIF4IASWXdOokQ+55n5mDMby1kRaG/HSM=; b=N5pBc2eE/7jPJQU1FPK/6vrSJUcBQh62ycAVKTcxn9ejcteCln45JkFfamqRC08ImG r8eJxWZ4WJ0AUJQl37QRvR+zTtFH5kTxEsxy9G6gpW/dlLh+A3ZVvmkx+1D7F61slZ2g +JSjyCk9dyk380d09fHPNi2BSZ1as3QXBIQXEo5CCSmkNEIYGusV9BxxRghsCcLJv8R/ 0utdNO5ks/AWN0S+6/bzf5X4atk0/CzqnGueuP3JOGQv6HBwMe26CpfKeBP1BLGC36lC zKo/oOAYglnFgQ5cgqzxfQor8LqPpxyRkz67UVM1O7E29HQIwDreGKhZP5DyV29M5WVN B21A== X-Gm-Message-State: AJIora/X5TPZc5wqTv3R3/3QZTI47AhGLubU2m6kFoDryBGEaurn+/eP EZ60LIxnoVxp/a9R53RnDX3+CeRoI8W2ZSOV X-Google-Smtp-Source: AGRyM1vW8N/9hORhsm1kN8Q9PDUfMzZ2mGXeJpVq9yj72rbi1OLc/w3tUsYZ84ZlhLAxUACT1oT/2g== X-Received: by 2002:a05:651c:1992:b0:25e:68d:e757 with SMTP id bx18-20020a05651c199200b0025e068de757mr7245754ljb.309.1659507065652; Tue, 02 Aug 2022 23:11:05 -0700 (PDT) Received: from [192.168.1.6] ([213.161.169.44]) by smtp.gmail.com with ESMTPSA id o18-20020ac25e32000000b00489f0c8bddesm455144lfg.207.2022.08.02.23.11.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 23:11:04 -0700 (PDT) Message-ID: Date: Wed, 3 Aug 2022 08:11:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/2] spi: dt-binding: add Microchip CoreQSPI compatible Content-Language: en-US To: Mark Brown Cc: Naga Sureshkumar Relli , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor.dooley@microchip.com, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220801094255.664548-1-nagasuresh.relli@microchip.com> <20220801094255.664548-2-nagasuresh.relli@microchip.com> <6d36b192-9e63-ec13-5583-22b81c99c18b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/08/2022 15:13, Mark Brown wrote: > On Tue, Aug 02, 2022 at 10:52:25AM +0200, Krzysztof Kozlowski wrote: >> On 01/08/2022 11:42, Naga Sureshkumar Relli wrote: > >>> - enum: >>> - - microchip,mpfs-spi >>> - - microchip,mpfs-qspi >>> + oneOf: >>> + - description: Microchip's Polarfire SoC SPI controller. >>> + const: microchip,mpfs-spi >>> + - description: Microchip's Polarfire SoC QSPI controller. > >> Useless descriptions - they repeat compatible. Just keep it as enum and >> skip descriptions. What value do they bring? > > Someone not familiar with the full Microchip product line might not be > aware of the expansion of mpfs, it's not blindingly obvious. Then it should be explained in title/description of the binding, not in compatible. This is the usual way of providing some text description, not for each compatible by repeating the compatible text. Best regards, Krzysztof