[PATCH 0/4] arm64: dts: arduino-imola: add support for sound

[PATCH 0/4] arm64: dts: arduino-imola: add support for sound

[Srinivas Kandagatla]

This patchset adds support for audio on Arduino-Imola platform which is
based on Agatti SoC. As part of series a some of the patches worked by
Alexey are reworked and sent as per previous comments, mainly on the
dt-bindings part.

Other base soc level dtsi change is picked up from 
https://git.codelinaro.org/alexey.klimov/linux_next_tracking/-/commits/rb1_audio_wip_v3?ref_type=HEADS

Along with these changes, add sound nodes for the Imola alongi with
defconfig changes.

It made more sense to carry the previously sent v5 version of dt-bindings
patch into this series as the dts changes have dependency on this
binding change. If this is not okay, am happy to send the dt-bindings patch
seperately.

thanks,
Srini
 
Alexey Klimov (2):
  dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec
  arm64: dts: qcom: agatti: add LPASS devices

Srinivas Kandagatla (2):
  arm64: dts: arduino-imola: add support for sound
  arm64: defconfig: Enable Agatti audio drivers

 .../bindings/mfd/qcom,spmi-pmic.yaml          |   6 +-
 arch/arm64/boot/dts/qcom/agatti.dtsi          | 189 ++++++++++++++++++
 .../boot/dts/qcom/qrb2210-arduino-imola.dts   | 137 +++++++++++++
 arch/arm64/configs/defconfig                  |   2 +
 4 files changed, 333 insertions(+), 1 deletion(-)

-- 
2.47.3

[PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec

[Srinivas Kandagatla]

From: Alexey Klimov <alexey.klimov@linaro.org>

Qualcomm Agatti SoC has PM4125 PMIC, which includes audio codec.
Audio codec has TX and RX soundwire slave devices to connect to on-chip
soundwire master.

Add missing qcom,pm4125-codec compatible to pattern of audio-codec node
properties in mfd qcom,spmi-pmic schema to complete the audio codec support.

Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
[Srini: reworked the patch]
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index e5931d18d998..f58a85562c26 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -145,7 +145,11 @@ patternProperties:
 
   "^audio-codec@[0-9a-f]+$":
     type: object
-    $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#
+    oneOf:
+      - $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#
+      - properties:
+          compatible:
+            const: qcom,pm4125-codec
 
   "^battery@[0-9a-f]+$":
     type: object
-- 
2.47.3

[PATCH 2/4] arm64: dts: qcom: agatti: add LPASS devices

[Srinivas Kandagatla]

From: Alexey Klimov <alexey.klimov@linaro.org>

The rxmacro, txmacro, vamacro, soundwire nodes, lpass clock
controllers are required to support audio playback and
audio capture on sm6115 and its derivatives.

Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/agatti.dtsi | 189 +++++++++++++++++++++++++++
 1 file changed, 189 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
index 76b93b7bd50f..79cd8bb8e02c 100644
--- a/arch/arm64/boot/dts/qcom/agatti.dtsi
+++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
@@ -758,6 +758,42 @@ data-pins {
 					drive-strength = <8>;
 				};
 			};
+
+			lpass_tx_swr_active: lpass-tx-swr-active-state {
+				clk-pins {
+					pins = "gpio0";
+					function = "swr_tx_clk";
+					drive-strength = <10>;
+					slew-rate = <3>;
+					bias-disable;
+				};
+
+				data-pins {
+					pins = "gpio1", "gpio2";
+					function = "swr_tx_data";
+					drive-strength = <10>;
+					slew-rate = <3>;
+					bias-bus-hold;
+				};
+			};
+
+			lpass_rx_swr_active: lpass-rx-swr-active-state {
+				clk-pins {
+					pins = "gpio3";
+					function = "swr_rx_clk";
+					drive-strength = <10>;
+					slew-rate = <3>;
+					bias-disable;
+				};
+
+				data-pins {
+					pins = "gpio4", "gpio5";
+					function = "swr_rx_data";
+					drive-strength = <10>;
+					slew-rate = <3>;
+					bias-bus-hold;
+				};
+			};
 		};
 
 		gcc: clock-controller@1400000 {
@@ -2188,6 +2224,159 @@ glink-edge {
 			};
 		};
 
+		rxmacro: codec@a600000 {
+			compatible = "qcom,sm6115-lpass-rx-macro";
+			reg = <0x0 0xa600000 0x0 0x1000>;
+
+			clocks = <&q6afecc LPASS_CLK_ID_RX_CORE_MCLK
+				LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+				 <&q6afecc LPASS_CLK_ID_RX_CORE_NPL_MCLK
+				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+				 <&q6afecc LPASS_HW_DCODEC_VOTE
+				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+				 <&vamacro>;
+			clock-names = "mclk",
+				      "npl",
+				      "dcodec",
+				      "fsgen";
+			assigned-clocks = <&q6afecc LPASS_CLK_ID_RX_CORE_MCLK
+					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+					  <&q6afecc LPASS_CLK_ID_RX_CORE_NPL_MCLK
+					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
+			assigned-clock-rates = <22579200>,
+					       <22579200>;
+			#clock-cells = <0>;
+			clock-output-names = "mclk";
+			#sound-dai-cells = <1>;
+		};
+
+		swr1: soundwire@a610000 {
+			compatible = "qcom,soundwire-v1.6.0";
+			reg = <0x0 0x0a610000 0x0 0x2000>;
+			interrupts = <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>;
+
+			clocks = <&rxmacro>;
+			clock-names = "iface";
+
+			resets = <&lpass_audiocc 0>;
+			reset-names = "swr_audio_cgcr";
+
+			label = "RX";
+			qcom,din-ports = <0>;
+			qcom,dout-ports = <5>;
+
+			qcom,ports-sinterval-low =	/bits/ 8 <0x03 0x1f 0x1f 0x07 0x00>;
+			qcom,ports-offset1 =		/bits/ 8 <0x00 0x00 0x0b 0x01 0x00>;
+			qcom,ports-offset2 =		/bits/ 8 <0x00 0x00 0x0b 0x00 0x00>;
+			qcom,ports-hstart =		/bits/ 8 <0xff 0x03 0xff 0xff 0xff>;
+			qcom,ports-hstop =		/bits/ 8 <0xff 0x06 0xff 0xff 0xff>;
+			qcom,ports-word-length =	/bits/ 8 <0x01 0x07 0x04 0xff 0xff>;
+			qcom,ports-block-pack-mode =	/bits/ 8 <0xff 0x00 0x01 0xff 0xff>;
+			qcom,ports-block-group-count =	/bits/ 8 <0xff 0xff 0xff 0xff 0x00>;
+			qcom,ports-lane-control =	/bits/ 8 <0x01 0x00 0x00 0x00 0x00>;
+
+			status = "disabled";
+
+			#sound-dai-cells = <1>;
+			#address-cells = <2>;
+			#size-cells = <0>;
+		};
+
+
+		txmacro: codec@a620000 {
+			compatible = "qcom,sm6115-lpass-tx-macro";
+			reg = <0x0 0x0a620000 0x0 0x1000>;
+
+			clocks = <&q6afecc LPASS_CLK_ID_TX_CORE_MCLK
+				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+				 <&q6afecc LPASS_CLK_ID_TX_CORE_NPL_MCLK
+				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+				 <&q6afecc LPASS_HW_DCODEC_VOTE
+				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+				 <&vamacro>;
+			clock-names = "mclk",
+				      "npl",
+				      "dcodec",
+				      "fsgen";
+			assigned-clocks = <&q6afecc LPASS_CLK_ID_TX_CORE_MCLK
+					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+					  <&q6afecc LPASS_CLK_ID_TX_CORE_NPL_MCLK
+					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
+			assigned-clock-rates = <19200000>,
+					       <19200000>;
+			#clock-cells = <0>;
+			clock-output-names = "mclk";
+			#sound-dai-cells = <1>;
+		};
+
+		lpass_audiocc: clock-controller@a6a9000 {
+			compatible = "qcom,sm6115-lpassaudiocc";
+			reg = <0x0 0x0a6a9000 0x0 0x1000>;
+			#reset-cells = <1>;
+		};
+
+		vamacro: codec@a730000 {
+			compatible = "qcom,sm6115-lpass-va-macro";
+			reg = <0x0 0x0a730000 0x0 0x1000>;
+
+			clocks = <&q6afecc LPASS_CLK_ID_TX_CORE_MCLK
+				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+				 <&q6afecc LPASS_HW_DCODEC_VOTE
+				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+				 <&q6afecc LPASS_CLK_ID_TX_CORE_NPL_MCLK
+				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
+			clock-names = "mclk",
+				      "dcodec",
+				      "npl";
+			assigned-clocks = <&q6afecc LPASS_CLK_ID_TX_CORE_MCLK
+					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+					  <&q6afecc LPASS_CLK_ID_TX_CORE_NPL_MCLK
+					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
+			assigned-clock-rates = <19200000>,
+					       <19200000>;
+			#clock-cells = <0>;
+			clock-output-names = "fsgen";
+			#sound-dai-cells = <1>;
+		};
+
+		swr0: soundwire@a740000 {
+			compatible = "qcom,soundwire-v1.6.0";
+			reg = <0x0 0x0a740000 0x0 0x2000>;
+			interrupts = <GIC_SPI 296 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&txmacro>;
+			clock-names = "iface";
+
+			resets = <&lpasscc 0>;
+			reset-names = "swr_audio_cgcr";
+
+			label = "VA_TX";
+			qcom,din-ports = <3>;
+			qcom,dout-ports = <0>;
+
+			qcom,ports-sinterval-low =	/bits/ 8 <0x03 0x03 0x03>;
+			qcom,ports-offset1 =		/bits/ 8 <0x01 0x02 0x01>;
+			qcom,ports-offset2 =		/bits/ 8 <0x00 0x00 0x00>;
+			qcom,ports-hstart =		/bits/ 8 <0xff 0xff 0xff>;
+			qcom,ports-hstop =		/bits/ 8 <0xff 0xff 0xff>;
+			qcom,ports-word-length =	/bits/ 8 <0xff 0xff 0xff>;
+			qcom,ports-block-pack-mode =	/bits/ 8 <0xff 0xff 0xff>;
+			qcom,ports-block-group-count =	/bits/ 8 <0xff 0xff 0xff>;
+			qcom,ports-lane-control =	/bits/ 8 <0x00 0x00 0x00>;
+
+			status = "disabled";
+
+			#sound-dai-cells = <1>;
+			#address-cells = <2>;
+			#size-cells = <0>;
+		};
+
+		lpasscc: clock-controller@a7ec000 {
+			compatible = "qcom,sm6115-lpasscc";
+			reg = <0x0 0x0a7ec000 0x0 0x1000>;
+			#reset-cells = <1>;
+		};
+
 		remoteproc_adsp: remoteproc@ab00000 {
 			compatible = "qcom,qcm2290-adsp-pas", "qcom,sm6115-adsp-pas";
 			reg = <0x0 0x0ab00000 0x0 0x100>;
-- 
2.47.3

[PATCH 3/4] arm64: dts: arduino-imola: add support for sound

[Srinivas Kandagatla]

Add support for sound on Arduino UNO Q board, which includes
- Headset playback and record.
- Lineout

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
---
 .../boot/dts/qcom/qrb2210-arduino-imola.dts   | 137 ++++++++++++++++++
 1 file changed, 137 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
index 197ab6eb1666..f36f7ff96252 100644
--- a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
+++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
@@ -109,6 +109,98 @@ multi-led {
 		leds = <&ledr>, <&ledg>, <&ledb>;
 	};
 
+	sound {
+		compatible = "qcom,qrb2210-sndcard";
+		model = "Arduino-Imola-HPH-LOUT";
+		audio-routing =	"IN1_HPHL", "HPHL_OUT",
+				"IN2_HPHR", "HPHR_OUT",
+				"AMIC2", "MIC BIAS2";
+
+		mm1-dai-link {
+			link-name = "MultiMedia1";
+
+			cpu {
+				sound-dai = <&q6asmdai MSM_FRONTEND_DAI_MULTIMEDIA1>;
+			};
+		};
+
+		mm2-dai-link {
+			link-name = "MultiMedia2";
+
+			cpu {
+				sound-dai = <&q6asmdai MSM_FRONTEND_DAI_MULTIMEDIA2>;
+			};
+		};
+
+		mm3-dai-link {
+			link-name = "MultiMedia3";
+
+			cpu {
+				sound-dai = <&q6asmdai  MSM_FRONTEND_DAI_MULTIMEDIA3>;
+			};
+		};
+
+		hph-playback-dai-link {
+			link-name = "HPH Playback";
+			cpu {
+				sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>;
+			};
+
+			platform {
+				sound-dai = <&q6routing>;
+			};
+
+			codec {
+				sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>;
+			};
+		};
+
+		lo-playback-dai-link {
+			link-name = "LO Playback";
+			cpu {
+				sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>;
+			};
+
+			platform {
+				sound-dai = <&q6routing>;
+			};
+
+			codec {
+				sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>;
+			};
+		};
+
+		ear-playback-dai-link {
+			link-name = "Ear Playback";
+			cpu {
+				sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>;
+			};
+
+			platform {
+				sound-dai = <&q6routing>;
+			};
+
+			codec {
+				sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>;
+			};
+		};
+
+		hph-capture-dai-link {
+			link-name = "HP Capture";
+			cpu {
+				sound-dai = <&q6afedai TX_CODEC_DMA_TX_3>;
+			};
+
+			platform {
+				sound-dai = <&q6routing>;
+			};
+
+			codec {
+				sound-dai = <&pmic4125_codec 1>, <&swr0 0>, <&txmacro 0>;
+			};
+		};
+	};
+
 	/* PM4125 charger out, supplied by VBAT */
 	vph_pwr: regulator-vph-pwr {
 		compatible = "regulator-fixed";
@@ -333,6 +425,51 @@ spidev@0 {
 	};
 };
 
+&spmi_bus {
+	pmic@0 {
+		pmic4125_codec: audio-codec@f000{
+			compatible = "qcom,pm4125-codec";
+			reg =<0xf000>;
+			vdd-io-supply = <&pm4125_l15>;
+			vdd-cp-supply = <&pm4125_s4>;
+			vdd-pa-vpos-supply = <&pm4125_s4>;
+
+			vdd-mic-bias-supply = <&pm4125_l22>;
+			qcom,micbias1-microvolt = <1800000>;
+			qcom,micbias2-microvolt = <1800000>;
+			qcom,micbias3-microvolt = <1800000>;
+
+			qcom,rx-device = <&pm4125_rx>;
+			qcom,tx-device = <&pm4125_tx>;
+			#sound-dai-cells = <1>;
+		};
+	};
+};
+
+&swr0 {
+	pinctrl-0 = <&lpass_tx_swr_active>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	pm4125_tx: codec@0,3 {
+		compatible = "sdw20217010c00";
+		reg = <0 3>;
+		qcom,tx-port-mapping = <1 1 2 3>;
+	};
+};
+
+&swr1 {
+	pinctrl-0 = <&lpass_rx_swr_active>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	pm4125_rx: codec@0,4 {
+		compatible = "sdw20217010c00";
+		reg = <0 4>;
+		qcom,rx-port-mapping = <1 2 3 4 5>;
+	};
+};
+
 &tlmm {
 	spidev_cs: spidev-cs-state {
 		pins = "gpio17";
-- 
2.47.3

[PATCH 4/4] arm64: defconfig: Enable Agatti audio drivers

[Srinivas Kandagatla]

Enable reset controller and pm4125 audio codec driver that are required
to enable audio support on Qualcomm Agatti SoC based platforms.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index b67d5b1fc45b..6db35c1605a0 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1146,6 +1146,7 @@ CONFIG_SND_SOC_ES8328_I2C=m
 CONFIG_SND_SOC_GTM601=m
 CONFIG_SND_SOC_MSM8916_WCD_ANALOG=m
 CONFIG_SND_SOC_MSM8916_WCD_DIGITAL=m
+CONFIG_SND_SOC_PM4125_SDW=m
 CONFIG_SND_SOC_PCM3168A_I2C=m
 CONFIG_SND_SOC_RK3308=m
 CONFIG_SND_SOC_RK817=m
@@ -1550,6 +1551,7 @@ CONFIG_SM_GPUCC_8350=m
 CONFIG_SM_GPUCC_8450=m
 CONFIG_SM_GPUCC_8550=m
 CONFIG_SM_GPUCC_8650=m
+CONFIG_SM_LPASSCC_6115=m
 CONFIG_SM_TCSRCC_8550=y
 CONFIG_SM_TCSRCC_8650=y
 CONFIG_SM_TCSRCC_8750=m
-- 
2.47.3

Re: [PATCH 4/4] arm64: defconfig: Enable Agatti audio drivers

[Dmitry Baryshkov]

On Mon, Feb 09, 2026 at 02:24:28PM +0000, Srinivas Kandagatla wrote:
> Enable reset controller and pm4125 audio codec driver that are required
> to enable audio support on Qualcomm Agatti SoC based platforms.

defconfig usually is described in terms of a board rather than
platforms.

> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---
>  arch/arm64/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index b67d5b1fc45b..6db35c1605a0 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1146,6 +1146,7 @@ CONFIG_SND_SOC_ES8328_I2C=m
>  CONFIG_SND_SOC_GTM601=m
>  CONFIG_SND_SOC_MSM8916_WCD_ANALOG=m
>  CONFIG_SND_SOC_MSM8916_WCD_DIGITAL=m
> +CONFIG_SND_SOC_PM4125_SDW=m
>  CONFIG_SND_SOC_PCM3168A_I2C=m
>  CONFIG_SND_SOC_RK3308=m
>  CONFIG_SND_SOC_RK817=m
> @@ -1550,6 +1551,7 @@ CONFIG_SM_GPUCC_8350=m
>  CONFIG_SM_GPUCC_8450=m
>  CONFIG_SM_GPUCC_8550=m
>  CONFIG_SM_GPUCC_8650=m
> +CONFIG_SM_LPASSCC_6115=m
>  CONFIG_SM_TCSRCC_8550=y
>  CONFIG_SM_TCSRCC_8650=y
>  CONFIG_SM_TCSRCC_8750=m
> -- 
> 2.47.3
> 

-- 
With best wishes
Dmitry

Re: [PATCH 2/4] arm64: dts: qcom: agatti: add LPASS devices

[Dmitry Baryshkov]

On Mon, Feb 09, 2026 at 02:24:26PM +0000, Srinivas Kandagatla wrote:
> From: Alexey Klimov <alexey.klimov@linaro.org>
> 
> The rxmacro, txmacro, vamacro, soundwire nodes, lpass clock
> controllers are required to support audio playback and
> audio capture on sm6115 and its derivatives.
> 
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/agatti.dtsi | 189 +++++++++++++++++++++++++++
>  1 file changed, 189 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
> index 76b93b7bd50f..79cd8bb8e02c 100644
> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi
> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
> @@ -758,6 +758,42 @@ data-pins {
>  					drive-strength = <8>;
>  				};
>  			};
> +
> +			lpass_tx_swr_active: lpass-tx-swr-active-state {
> +				clk-pins {
> +					pins = "gpio0";
> +					function = "swr_tx_clk";
> +					drive-strength = <10>;
> +					slew-rate = <3>;
> +					bias-disable;
> +				};
> +
> +				data-pins {
> +					pins = "gpio1", "gpio2";
> +					function = "swr_tx_data";
> +					drive-strength = <10>;
> +					slew-rate = <3>;
> +					bias-bus-hold;
> +				};
> +			};
> +
> +			lpass_rx_swr_active: lpass-rx-swr-active-state {
> +				clk-pins {
> +					pins = "gpio3";
> +					function = "swr_rx_clk";
> +					drive-strength = <10>;
> +					slew-rate = <3>;
> +					bias-disable;
> +				};
> +
> +				data-pins {
> +					pins = "gpio4", "gpio5";
> +					function = "swr_rx_data";
> +					drive-strength = <10>;
> +					slew-rate = <3>;
> +					bias-bus-hold;
> +				};
> +			};
>  		};
>  
>  		gcc: clock-controller@1400000 {
> @@ -2188,6 +2224,159 @@ glink-edge {
>  			};
>  		};
>  
> +		rxmacro: codec@a600000 {
> +			compatible = "qcom,sm6115-lpass-rx-macro";
> +			reg = <0x0 0xa600000 0x0 0x1000>;
> +
> +			clocks = <&q6afecc LPASS_CLK_ID_RX_CORE_MCLK
> +				LPASS_CLK_ATTRIBUTE_COUPLE_NO>,

Plesae correct the indentation (or just use single line for each entry).

> +				 <&q6afecc LPASS_CLK_ID_RX_CORE_NPL_MCLK
> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&q6afecc LPASS_HW_DCODEC_VOTE
> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&vamacro>;

The rest LGTM.

-- 
With best wishes
Dmitry

Re: [PATCH 2/4] arm64: dts: qcom: agatti: add LPASS devices

[Srinivas Kandagatla]

On 2/9/26 3:28 PM, Dmitry Baryshkov wrote:
> On Mon, Feb 09, 2026 at 02:24:26PM +0000, Srinivas Kandagatla wrote:
>> From: Alexey Klimov <alexey.klimov@linaro.org>
>>
>> The rxmacro, txmacro, vamacro, soundwire nodes, lpass clock
>> controllers are required to support audio playback and
>> audio capture on sm6115 and its derivatives.
>>
>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/agatti.dtsi | 189 +++++++++++++++++++++++++++
>>  1 file changed, 189 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
>> index 76b93b7bd50f..79cd8bb8e02c 100644
>> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
>> @@ -758,6 +758,42 @@ data-pins {
>>  					drive-strength = <8>;
>>  				};
>>  			};
>> +
>> +			lpass_tx_swr_active: lpass-tx-swr-active-state {
>> +				clk-pins {
>> +					pins = "gpio0";
>> +					function = "swr_tx_clk";
>> +					drive-strength = <10>;
>> +					slew-rate = <3>;
>> +					bias-disable;
>> +				};
>> +
>> +				data-pins {
>> +					pins = "gpio1", "gpio2";
>> +					function = "swr_tx_data";
>> +					drive-strength = <10>;
>> +					slew-rate = <3>;
>> +					bias-bus-hold;
>> +				};
>> +			};
>> +
>> +			lpass_rx_swr_active: lpass-rx-swr-active-state {
>> +				clk-pins {
>> +					pins = "gpio3";
>> +					function = "swr_rx_clk";
>> +					drive-strength = <10>;
>> +					slew-rate = <3>;
>> +					bias-disable;
>> +				};
>> +
>> +				data-pins {
>> +					pins = "gpio4", "gpio5";
>> +					function = "swr_rx_data";
>> +					drive-strength = <10>;
>> +					slew-rate = <3>;
>> +					bias-bus-hold;
>> +				};
>> +			};
>>  		};
>>  
>>  		gcc: clock-controller@1400000 {
>> @@ -2188,6 +2224,159 @@ glink-edge {
>>  			};
>>  		};
>>  
>> +		rxmacro: codec@a600000 {
>> +			compatible = "qcom,sm6115-lpass-rx-macro";
>> +			reg = <0x0 0xa600000 0x0 0x1000>;
>> +
>> +			clocks = <&q6afecc LPASS_CLK_ID_RX_CORE_MCLK
>> +				LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> 
> Plesae correct the indentation (or just use single line for each entry).
Checkpatch was not happy with more than 100 chars, which is why I folded
this out, I will fix the indent in next spin.

--srini
> 
>> +				 <&q6afecc LPASS_CLK_ID_RX_CORE_NPL_MCLK
>> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> +				 <&q6afecc LPASS_HW_DCODEC_VOTE
>> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> +				 <&vamacro>;
> 
> The rest LGTM.
> 

Re: [PATCH 4/4] arm64: defconfig: Enable Agatti audio drivers

[Srinivas Kandagatla]

On 2/9/26 3:26 PM, Dmitry Baryshkov wrote:
> On Mon, Feb 09, 2026 at 02:24:28PM +0000, Srinivas Kandagatla wrote:
>> Enable reset controller and pm4125 audio codec driver that are required
>> to enable audio support on Qualcomm Agatti SoC based platforms.
> 
> defconfig usually is described in terms of a board rather than
> platforms.
> 
Will reword this to imola in next spin

--srini
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>> ---
>>  arch/arm64/configs/defconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index b67d5b1fc45b..6db35c1605a0 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -1146,6 +1146,7 @@ CONFIG_SND_SOC_ES8328_I2C=m
>>  CONFIG_SND_SOC_GTM601=m
>>  CONFIG_SND_SOC_MSM8916_WCD_ANALOG=m
>>  CONFIG_SND_SOC_MSM8916_WCD_DIGITAL=m
>> +CONFIG_SND_SOC_PM4125_SDW=m
>>  CONFIG_SND_SOC_PCM3168A_I2C=m
>>  CONFIG_SND_SOC_RK3308=m
>>  CONFIG_SND_SOC_RK817=m
>> @@ -1550,6 +1551,7 @@ CONFIG_SM_GPUCC_8350=m
>>  CONFIG_SM_GPUCC_8450=m
>>  CONFIG_SM_GPUCC_8550=m
>>  CONFIG_SM_GPUCC_8650=m
>> +CONFIG_SM_LPASSCC_6115=m
>>  CONFIG_SM_TCSRCC_8550=y
>>  CONFIG_SM_TCSRCC_8650=y
>>  CONFIG_SM_TCSRCC_8750=m
>> -- 
>> 2.47.3
>>
> 

Re: [PATCH 2/4] arm64: dts: qcom: agatti: add LPASS devices

[Dmitry Baryshkov]

On Mon, Feb 09, 2026 at 05:12:51PM +0000, Srinivas Kandagatla wrote:
> On 2/9/26 3:28 PM, Dmitry Baryshkov wrote:
> > On Mon, Feb 09, 2026 at 02:24:26PM +0000, Srinivas Kandagatla wrote:
> >> From: Alexey Klimov <alexey.klimov@linaro.org>
> >>
> >> The rxmacro, txmacro, vamacro, soundwire nodes, lpass clock
> >> controllers are required to support audio playback and
> >> audio capture on sm6115 and its derivatives.
> >>
> >> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> >> ---
> >>  arch/arm64/boot/dts/qcom/agatti.dtsi | 189 +++++++++++++++++++++++++++
> >>  1 file changed, 189 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
> >> index 76b93b7bd50f..79cd8bb8e02c 100644
> >> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
> >> @@ -758,6 +758,42 @@ data-pins {
> >>  					drive-strength = <8>;
> >>  				};
> >>  			};
> >> +
> >> +			lpass_tx_swr_active: lpass-tx-swr-active-state {
> >> +				clk-pins {
> >> +					pins = "gpio0";
> >> +					function = "swr_tx_clk";
> >> +					drive-strength = <10>;
> >> +					slew-rate = <3>;
> >> +					bias-disable;
> >> +				};
> >> +
> >> +				data-pins {
> >> +					pins = "gpio1", "gpio2";
> >> +					function = "swr_tx_data";
> >> +					drive-strength = <10>;
> >> +					slew-rate = <3>;
> >> +					bias-bus-hold;
> >> +				};
> >> +			};
> >> +
> >> +			lpass_rx_swr_active: lpass-rx-swr-active-state {
> >> +				clk-pins {
> >> +					pins = "gpio3";
> >> +					function = "swr_rx_clk";
> >> +					drive-strength = <10>;
> >> +					slew-rate = <3>;
> >> +					bias-disable;
> >> +				};
> >> +
> >> +				data-pins {
> >> +					pins = "gpio4", "gpio5";
> >> +					function = "swr_rx_data";
> >> +					drive-strength = <10>;
> >> +					slew-rate = <3>;
> >> +					bias-bus-hold;
> >> +				};
> >> +			};
> >>  		};
> >>  
> >>  		gcc: clock-controller@1400000 {
> >> @@ -2188,6 +2224,159 @@ glink-edge {
> >>  			};
> >>  		};
> >>  
> >> +		rxmacro: codec@a600000 {
> >> +			compatible = "qcom,sm6115-lpass-rx-macro";
> >> +			reg = <0x0 0xa600000 0x0 0x1000>;
> >> +
> >> +			clocks = <&q6afecc LPASS_CLK_ID_RX_CORE_MCLK
> >> +				LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > 
> > Plesae correct the indentation (or just use single line for each entry).
> Checkpatch was not happy with more than 100 chars, which is why I folded
> this out, I will fix the indent in next spin.

Well, the first thing that caught my eye was the LPASS_ being slightly
out (this one is misaligned with the rest of the the lines). So, if you
don't want to over the 100-chars limit, then please consider aligning
past the angle bracket.

-- 
With best wishes
Dmitry

Re: [PATCH 3/4] arm64: dts: arduino-imola: add support for sound

[Konrad Dybcio]

On 2/9/26 3:24 PM, Srinivas Kandagatla wrote:
> Add support for sound on Arduino UNO Q board, which includes
> - Headset playback and record.
> - Lineout

Looking at the images, I can't see a speaker there..

And looking at https://docs.arduino.cc/resources/pinouts/ABX00162-full-pinout.pdf
I *thiiink* there's no I2S out (which is a little surprising)

[...]

> +		hph-playback-dai-link {
> +			link-name = "HPH Playback";
> +			cpu {
> +				sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>;
> +			};
> +
> +			platform {
> +				sound-dai = <&q6routing>;
> +			};
> +
> +			codec {
> +				sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>;
> +			};
> +		};
> +
> +		lo-playback-dai-link {
> +			link-name = "LO Playback";

"Line Out", "Headphones", etc.? I know if it's user-visible..

> +			cpu {
> +				sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>;
> +			};
> +
> +			platform {
> +				sound-dai = <&q6routing>;
> +			};
> +
> +			codec {
> +				sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>;
> +			};
> +		};
> +
> +		ear-playback-dai-link {
> +			link-name = "Ear Playback";
> +			cpu {

Let's uniformly keep a newline between the last property and the following
subnodes, and let's sort all these nodes alphabetically (i.e. both under
/sound and codec/cpu/platform within them)

[...]

> +&spmi_bus {
> +	pmic@0 {
> +		pmic4125_codec: audio-codec@f000{

This definition should definitely live in pm4125.dtsi!

missing space before '{'

> +			compatible = "qcom,pm4125-codec";
> +			reg =<0xf000>;

missing space after '='

> +			vdd-io-supply = <&pm4125_l15>;
> +			vdd-cp-supply = <&pm4125_s4>;
> +			vdd-pa-vpos-supply = <&pm4125_s4>;
> +
> +			vdd-mic-bias-supply = <&pm4125_l22>;
> +			qcom,micbias1-microvolt = <1800000>;
> +			qcom,micbias2-microvolt = <1800000>;
> +			qcom,micbias3-microvolt = <1800000>;
> +
> +			qcom,rx-device = <&pm4125_rx>;
> +			qcom,tx-device = <&pm4125_tx>;
> +			#sound-dai-cells = <1>;
> +		};
> +	};
> +};
> +
> +&swr0 {
> +	pinctrl-0 = <&lpass_tx_swr_active>;
> +	pinctrl-names = "default";
> +	status = "okay";

Please add a \n before status

otherwise this looks ok

Konrad

Re: [PATCH 2/4] arm64: dts: qcom: agatti: add LPASS devices

[Konrad Dybcio]

On 2/9/26 3:24 PM, Srinivas Kandagatla wrote:
> From: Alexey Klimov <alexey.klimov@linaro.org>
> 
> The rxmacro, txmacro, vamacro, soundwire nodes, lpass clock
> controllers are required to support audio playback and
> audio capture on sm6115 and its derivatives.
> 
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---

[...]

> +		rxmacro: codec@a600000 {
> +			compatible = "qcom,sm6115-lpass-rx-macro";
> +			reg = <0x0 0xa600000 0x0 0x1000>;
> +
> +			clocks = <&q6afecc LPASS_CLK_ID_RX_CORE_MCLK
> +				LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&q6afecc LPASS_CLK_ID_RX_CORE_NPL_MCLK
> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&q6afecc LPASS_HW_DCODEC_VOTE
> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&vamacro>;
> +			clock-names = "mclk",
> +				      "npl",
> +				      "dcodec",
> +				      "fsgen";
> +			assigned-clocks = <&q6afecc LPASS_CLK_ID_RX_CORE_MCLK
> +					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +					  <&q6afecc LPASS_CLK_ID_RX_CORE_NPL_MCLK
> +					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> +			assigned-clock-rates = <22579200>,
> +					       <22579200>;

Is this necessary?

> +			#clock-cells = <0>;
> +			clock-output-names = "mclk";
> +			#sound-dai-cells = <1>;
> +		};
> +
> +		swr1: soundwire@a610000 {
> +			compatible = "qcom,soundwire-v1.6.0";
> +			reg = <0x0 0x0a610000 0x0 0x2000>;

Let's set size=0x10_000 (it's got that much reserved for it)

> +			interrupts = <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			clocks = <&rxmacro>;
> +			clock-names = "iface";
> +
> +			resets = <&lpass_audiocc 0>;
> +			reset-names = "swr_audio_cgcr";
> +
> +			label = "RX";
> +			qcom,din-ports = <0>;
> +			qcom,dout-ports = <5>;
> +
> +			qcom,ports-sinterval-low =	/bits/ 8 <0x03 0x1f 0x1f 0x07 0x00>;
> +			qcom,ports-offset1 =		/bits/ 8 <0x00 0x00 0x0b 0x01 0x00>;
> +			qcom,ports-offset2 =		/bits/ 8 <0x00 0x00 0x0b 0x00 0x00>;
> +			qcom,ports-hstart =		/bits/ 8 <0xff 0x03 0xff 0xff 0xff>;
> +			qcom,ports-hstop =		/bits/ 8 <0xff 0x06 0xff 0xff 0xff>;
> +			qcom,ports-word-length =	/bits/ 8 <0x01 0x07 0x04 0xff 0xff>;
> +			qcom,ports-block-pack-mode =	/bits/ 8 <0xff 0x00 0x01 0xff 0xff>;
> +			qcom,ports-block-group-count =	/bits/ 8 <0xff 0xff 0xff 0xff 0x00>;
> +			qcom,ports-lane-control =	/bits/ 8 <0x01 0x00 0x00 0x00 0x00>;
> +
> +			status = "disabled";

No need to disable, I think

> +
> +			#sound-dai-cells = <1>;
> +			#address-cells = <2>;
> +			#size-cells = <0>;
> +		};
> +
> +
> +		txmacro: codec@a620000 {
> +			compatible = "qcom,sm6115-lpass-tx-macro";
> +			reg = <0x0 0x0a620000 0x0 0x1000>;
> +
> +			clocks = <&q6afecc LPASS_CLK_ID_TX_CORE_MCLK
> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&q6afecc LPASS_CLK_ID_TX_CORE_NPL_MCLK
> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&q6afecc LPASS_HW_DCODEC_VOTE
> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&vamacro>;
> +			clock-names = "mclk",
> +				      "npl",
> +				      "dcodec",
> +				      "fsgen";
> +			assigned-clocks = <&q6afecc LPASS_CLK_ID_TX_CORE_MCLK
> +					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +					  <&q6afecc LPASS_CLK_ID_TX_CORE_NPL_MCLK
> +					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> +			assigned-clock-rates = <19200000>,
> +					       <19200000>;

Is this necessary?

> +			#clock-cells = <0>;
> +			clock-output-names = "mclk";
> +			#sound-dai-cells = <1>;
> +		};
> +
> +		lpass_audiocc: clock-controller@a6a9000 {
> +			compatible = "qcom,sm6115-lpassaudiocc";
> +			reg = <0x0 0x0a6a9000 0x0 0x1000>;

This region is called 'LPASS_AUDIO_CSR' with the correct size and length


> +			#reset-cells = <1>;
> +		};
> +
> +		vamacro: codec@a730000 {
> +			compatible = "qcom,sm6115-lpass-va-macro";
> +			reg = <0x0 0x0a730000 0x0 0x1000>;
> +
> +			clocks = <&q6afecc LPASS_CLK_ID_TX_CORE_MCLK
> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&q6afecc LPASS_HW_DCODEC_VOTE
> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&q6afecc LPASS_CLK_ID_TX_CORE_NPL_MCLK
> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> +			clock-names = "mclk",
> +				      "dcodec",
> +				      "npl";
> +			assigned-clocks = <&q6afecc LPASS_CLK_ID_TX_CORE_MCLK
> +					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +					  <&q6afecc LPASS_CLK_ID_TX_CORE_NPL_MCLK
> +					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> +			assigned-clock-rates = <19200000>,
> +					       <19200000>;


Is this necessary?


> +			#clock-cells = <0>;
> +			clock-output-names = "fsgen";
> +			#sound-dai-cells = <1>;
> +		};
> +
> +		swr0: soundwire@a740000 {
> +			compatible = "qcom,soundwire-v1.6.0";
> +			reg = <0x0 0x0a740000 0x0 0x2000>;

sz=0x10_000

> +			interrupts = <GIC_SPI 296 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&txmacro>;
> +			clock-names = "iface";
> +
> +			resets = <&lpasscc 0>;
> +			reset-names = "swr_audio_cgcr";
> +
> +			label = "VA_TX";
> +			qcom,din-ports = <3>;
> +			qcom,dout-ports = <0>;
> +
> +			qcom,ports-sinterval-low =	/bits/ 8 <0x03 0x03 0x03>;
> +			qcom,ports-offset1 =		/bits/ 8 <0x01 0x02 0x01>;
> +			qcom,ports-offset2 =		/bits/ 8 <0x00 0x00 0x00>;
> +			qcom,ports-hstart =		/bits/ 8 <0xff 0xff 0xff>;
> +			qcom,ports-hstop =		/bits/ 8 <0xff 0xff 0xff>;
> +			qcom,ports-word-length =	/bits/ 8 <0xff 0xff 0xff>;
> +			qcom,ports-block-pack-mode =	/bits/ 8 <0xff 0xff 0xff>;
> +			qcom,ports-block-group-count =	/bits/ 8 <0xff 0xff 0xff>;
> +			qcom,ports-lane-control =	/bits/ 8 <0x00 0x00 0x00>;
> +
> +			status = "disabled";

No need

> +
> +			#sound-dai-cells = <1>;
> +			#address-cells = <2>;
> +			#size-cells = <0>;
> +		};
> +
> +		lpasscc: clock-controller@a7ec000 {
> +			compatible = "qcom,sm6115-lpasscc";
> +			reg = <0x0 0x0a7ec000 0x0 0x1000>;

This isn't quite right.. it's at LPASS_TCSR (0xa7e0000) + 0xc000

Not sure if we're gonna need the rest of it in the future, but it may
be smart to describe the whole thing.. Too bad I didn't know about it
when I first submitted that driver...

Konrad

Re: [PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec

[Krzysztof Kozlowski]

On Mon, Feb 09, 2026 at 02:24:25PM +0000, Srinivas Kandagatla wrote:
> From: Alexey Klimov <alexey.klimov@linaro.org>
> 
> Qualcomm Agatti SoC has PM4125 PMIC, which includes audio codec.
> Audio codec has TX and RX soundwire slave devices to connect to on-chip
> soundwire master.
> 
> Add missing qcom,pm4125-codec compatible to pattern of audio-codec node
> properties in mfd qcom,spmi-pmic schema to complete the audio codec support.
> 

That's v6, not v1.

> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> [Srini: reworked the patch]

Why? The v5 version was what we wanted. Why changing it?

Anyway, same feedback.

Best regards,
Krzysztof

Re: [PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec

[Krzysztof Kozlowski]

On 11/02/2026 07:43, Krzysztof Kozlowski wrote:
> On Mon, Feb 09, 2026 at 02:24:25PM +0000, Srinivas Kandagatla wrote:
>> From: Alexey Klimov <alexey.klimov@linaro.org>
>>
>> Qualcomm Agatti SoC has PM4125 PMIC, which includes audio codec.
>> Audio codec has TX and RX soundwire slave devices to connect to on-chip
>> soundwire master.
>>
>> Add missing qcom,pm4125-codec compatible to pattern of audio-codec node
>> properties in mfd qcom,spmi-pmic schema to complete the audio codec support.
>>
> 
> That's v6, not v1.
> 
>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>> [Srini: reworked the patch]
> 
> Why? The v5 version was what we wanted. Why changing it?
> 
> Anyway, same feedback.
> 

Just a note: this will conflict with Richard Acayan's PM660L, though.

Best regards,
Krzysztof

Re: [PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec

[Srinivas Kandagatla]

On 2/11/26 6:43 AM, Krzysztof Kozlowski wrote:
> On Mon, Feb 09, 2026 at 02:24:25PM +0000, Srinivas Kandagatla wrote:
>> From: Alexey Klimov <alexey.klimov@linaro.org>
>>
>> Qualcomm Agatti SoC has PM4125 PMIC, which includes audio codec.
>> Audio codec has TX and RX soundwire slave devices to connect to on-chip
>> soundwire master.
>>
>> Add missing qcom,pm4125-codec compatible to pattern of audio-codec node
>> properties in mfd qcom,spmi-pmic schema to complete the audio codec support.
>>
> 
> That's v6, not v1.
Thanks Krzysztof, I was skeptical about it before sending however it
made more sense to include that binding into this series which had 3 new
patches,which is why I started of with v1 again. Which can be easy for
review and dtb checks to not fail for the dts patches in this series.

Am happy to send it as v7 next time as a single patch if that is what is
prefered.



> 
>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>> [Srini: reworked the patch]
> 
> Why? The v5 version was what we wanted. Why changing it?
> 
I looked at all the versions of this patch before sending out this one,
it sounded that you were not okay with the patch itself, may be that is
not true, you just wanted a clear commit log changed. I can send a new
version with updated comments as you requested. May be I miss
interpreted it your review on v5.

TBH, there are multiple ways to add this new child node bindings into
spmi bus.

Just from my understanding, why listing compatibles is preferred over
listing ref to child bindings?, while both serve the same purpose.

thanks,
Srini


> Anyway, same feedback.
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec

[Krzysztof Kozlowski]

On 11/02/2026 11:00, Srinivas Kandagatla wrote:
> On 2/11/26 6:43 AM, Krzysztof Kozlowski wrote:
>> On Mon, Feb 09, 2026 at 02:24:25PM +0000, Srinivas Kandagatla wrote:
>>> From: Alexey Klimov <alexey.klimov@linaro.org>
>>>
>>> Qualcomm Agatti SoC has PM4125 PMIC, which includes audio codec.
>>> Audio codec has TX and RX soundwire slave devices to connect to on-chip
>>> soundwire master.
>>>
>>> Add missing qcom,pm4125-codec compatible to pattern of audio-codec node
>>> properties in mfd qcom,spmi-pmic schema to complete the audio codec support.
>>>
>>
>> That's v6, not v1.
> Thanks Krzysztof, I was skeptical about it before sending however it
> made more sense to include that binding into this series which had 3 new
> patches,which is why I started of with v1 again. Which can be easy for
> review and dtb checks to not fail for the dts patches in this series.
> 
> Am happy to send it as v7 next time as a single patch if that is what is
> prefered.
> 
> 
> 
>>
>>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>>> [Srini: reworked the patch]
>>
>> Why? The v5 version was what we wanted. Why changing it?
>>
> I looked at all the versions of this patch before sending out this one,
> it sounded that you were not okay with the patch itself, may be that is
> not true, you just wanted a clear commit log changed. I can send a new
> version with updated comments as you requested. May be I miss
> interpreted it your review on v5.
> 
> TBH, there are multiple ways to add this new child node bindings into
> spmi bus.
> 
> Just from my understanding, why listing compatibles is preferred over
> listing ref to child bindings?, while both serve the same purpose.
> 

Both ways can be done here, but I proposed to keep it consistent, so
when adding a compatible, let's switch entire oneOf part (not entire
binding) to compatibles.

Later today I found conflicting patches, so maybe original approach is
actually easier - no conflicts, no rebases - let's go with it then:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>


Best regards,
Krzysztof

Re: [PATCH 2/4] arm64: dts: qcom: agatti: add LPASS devices

[Srinivas Kandagatla]

On 2/10/26 10:16 AM, Konrad Dybcio wrote:
> On 2/9/26 3:24 PM, Srinivas Kandagatla wrote:
>> From: Alexey Klimov <alexey.klimov@linaro.org>
>>
>> The rxmacro, txmacro, vamacro, soundwire nodes, lpass clock
>> controllers are required to support audio playback and
>> audio capture on sm6115 and its derivatives.
>>
>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>> ---
> 
> [...]
> 
>> +		rxmacro: codec@a600000 {
>> +			compatible = "qcom,sm6115-lpass-rx-macro";
>> +			reg = <0x0 0xa600000 0x0 0x1000>;
>> +
>> +			clocks = <&q6afecc LPASS_CLK_ID_RX_CORE_MCLK
>> +				LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> +				 <&q6afecc LPASS_CLK_ID_RX_CORE_NPL_MCLK
>> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> +				 <&q6afecc LPASS_HW_DCODEC_VOTE
>> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> +				 <&vamacro>;
>> +			clock-names = "mclk",
>> +				      "npl",
>> +				      "dcodec",
>> +				      "fsgen";
>> +			assigned-clocks = <&q6afecc LPASS_CLK_ID_RX_CORE_MCLK
>> +					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> +					  <&q6afecc LPASS_CLK_ID_RX_CORE_NPL_MCLK
>> +					  LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
>> +			assigned-clock-rates = <22579200>,
>> +					       <22579200>;
> 
> Is this necessary?
Not required tbh.
> 
>> +			#clock-cells = <0>;
>> +			clock-output-names = "mclk";
>> +			#sound-dai-cells = <1>;
>> +		};
>> +
>> +		swr1: soundwire@a610000 {
>> +			compatible = "qcom,soundwire-v1.6.0";
>> +			reg = <0x0 0x0a610000 0x0 0x2000>;
> 
> Let's set size=0x10_000 (it's got that much reserved for it)
> 
make;s sense
>> +			interrupts = <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>;
>> +
>> +			clocks = <&rxmacro>;
>> +			clock-names = "iface";
>> +
>> +			resets = <&lpass_audiocc 0>;
>> +			reset-names = "swr_audio_cgcr";
>> +
>> +			label = "RX";
>> +			qcom,din-ports = <0>;
>> +			qcom,dout-ports = <5>;
>> +
>> +			qcom,ports-sinterval-low =	/bits/ 8 <0x03 0x1f 0x1f 0x07 0x00>;
>> +			qcom,ports-offset1 =		/bits/ 8 <0x00 0x00 0x0b 0x01 0x00>;
>> +			qcom,ports-offset2 =		/bits/ 8 <0x00 0x00 0x0b 0x00 0x00>;
>> +			qcom,ports-hstart =		/bits/ 8 <0xff 0x03 0xff 0xff 0xff>;
>> +			qcom,ports-hstop =		/bits/ 8 <0xff 0x06 0xff 0xff 0xff>;
>> +			qcom,ports-word-length =	/bits/ 8 <0x01 0x07 0x04 0xff 0xff>;
>> +			qcom,ports-block-pack-mode =	/bits/ 8 <0xff 0x00 0x01 0xff 0xff>;
>> +			qcom,ports-block-group-count =	/bits/ 8 <0xff 0xff 0xff 0xff 0x00>;
>> +			qcom,ports-lane-control =	/bits/ 8 <0x01 0x00 0x00 0x00 0x00>;
>> +
>> +			status = "disabled";
> 
> No need to disable, I think
Ok
> 
>> +
>> +			#sound-dai-cells = <1>;
>> +			#address-cells = <2>;
>> +			#size-cells = <0>;
>> +		};
>> +
>> +
>> +		txmacro: codec@a620000 {
>> +			compatible = "qcom,sm6115-lpass-tx-macro";
>> +			reg = <0x0 0x0a620000 0x0 0x1000>;
>> +
>> +			clocks = <&q6afecc LPASS_CLK_ID_TX_CORE_MCLK
>> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> +				 <&q6afecc LPASS_CLK_ID_TX_CORE_NPL_MCLK
>> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> +				 <&q6afecc LPASS_HW_DCODEC_VOTE
>> +				 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
>> +				 <&vamacro>;..
> 
>> +			#clock-cells = <0>;
>> +			clock-output-names = "mclk";
>> +			#sound-dai-cells = <1>;
>> +		};
>> +
>> +		lpass_audiocc: clock-controller@a6a9000 {
>> +			compatible = "qcom,sm6115-lpassaudiocc";
>> +			reg = <0x0 0x0a6a9000 0x0 0x1000>;
> 
> This region is called 'LPASS_AUDIO_CSR' with the correct size and length
we should.

> 
> 
>> +			#reset-cells = <1>;
>> +		};
>> +
>> +
>> +		swr0: soundwire@a740000 {
>> +			compatible = "qcom,soundwire-v1.6.0";
>> +			reg = <0x0 0x0a740000 0x0 0x2000>;
> 
> sz=0x10_000
Yes, we can add full range.
> 
>> +			interrupts = <GIC_SPI 296 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&txmacro>;
>> +			clock-names = "iface";
>> +
>> +			resets = <&lpasscc 0>;
>> +			reset-names = "swr_audio_cgcr";
>> +
>> +			label = "VA_TX";
>> +			qcom,din-ports = <3>;
>> +			qcom,dout-ports = <0>;
>> +
>> +			qcoze-cells = <0>;
>> +		};
>> +
>> +		lpasscc: clock-controller@a7ec000 {
>> +			compatible = "qcom,sm6115-lpasscc";
>> +			reg = <0x0 0x0a7ec000 0x0 0x1000>;
> 
> This isn't quite right.. it's at LPASS_TCSR (0xa7e0000) + 0xc000
> 
> Not sure if we're gonna need the rest of it in the future, but it may
> be smart to describe the whole thing.. Too bad I didn't know about it
> when I first submitted that driver...
Yes, the driver needs fixing, we do it correctly for sc8280xp

--srini
> 
> Konrad

Re: [PATCH 3/4] arm64: dts: arduino-imola: add support for sound

[Srinivas Kandagatla]

On 2/10/26 10:07 AM, Konrad Dybcio wrote:
> On 2/9/26 3:24 PM, Srinivas Kandagatla wrote:
>> Add support for sound on Arduino UNO Q board, which includes
>> - Headset playback and record.
>> - Lineout
> 
> Looking at the images, I can't see a speaker there..
> 
> And looking at https://docs.arduino.cc/resources/pinouts/ABX00162-full-pinout.pdf
> I *thiiink* there's no I2S out (which is a little surprising)

there isn't, there is only Ear, LIne, HP and MIc.
> 
> [...]
> 
>> +		hph-playback-dai-link {
>> +			link-name = "HPH Playback";
>> +			cpu {
>> +				sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>;
>> +			};
>> +
>> +			platform {
>> +				sound-dai = <&q6routing>;
>> +			};
>> +
>> +			codec {
>> +				sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>;
>> +			};
>> +		};
>> +
>> +		lo-playback-dai-link {
>> +			link-name = "LO Playback";
> 
> "Line Out", "Headphones", etc.? I know if it's user-visible..
It will be via UCM.

> 
>> +			cpu {
>> +				sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>;
>> +			};
>> +
>> +			platform {
>> +				sound-dai = <&q6routing>;
>> +			};
>> +
>> +			codec {
>> +				sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>;
>> +			};
>> +		};
>> +
>> +		ear-playback-dai-link {
>> +			link-name = "Ear Playback";
>> +			cpu {
> 
> Let's uniformly keep a newline between the last property and the following
> subnodes, and let's sort all these nodes alphabetically (i.e. both under
> /sound and codec/cpu/platform within them)
sure.

> 
> [...]
> 
>> +&spmi_bus {
>> +	pmic@0 {
>> +		pmic4125_codec: audio-codec@f000{
> 
> This definition should definitely live in pm4125.dtsi!

agreed.

> 
> missing space before '{'
> 
>> +			compatible = "qcom,pm4125-codec";
>> +			reg =<0xf000>;
> 
> missing space after '='
> 
>> +			vdd-io-supply = <&pm4125_l15>;
>> +			vdd-cp-supply = <&pm4125_s4>;
>> +			vdd-pa-vpos-supply = <&pm4125_s4>;
>> +
>> +			vdd-mic-bias-supply = <&pm4125_l22>;
>> +			qcom,micbias1-microvolt = <1800000>;
>> +			qcom,micbias2-microvolt = <1800000>;
>> +			qcom,micbias3-microvolt = <1800000>;
>> +
>> +			qcom,rx-device = <&pm4125_rx>;
>> +			qcom,tx-device = <&pm4125_tx>;
>> +			#sound-dai-cells = <1>;
>> +		};
>> +	};
>> +};
>> +
>> +&swr0 {
>> +	pinctrl-0 = <&lpass_tx_swr_active>;
>> +	pinctrl-names = "default";
>> +	status = "okay";
> 
> Please add a \n before status
> 
> otherwise this looks ok
> 
> Konrad