Re: [PATCH v2] arm64: dts: ti: k3-j722s-main: Add E5010 JPEG Encoder

[devarsh <devarsht@ti.com>]

Hi Brandon,

Thanks for the patch.
On 04/08/25 23:31, Brandon Brnich wrote:
> This adds node for E5010 JPEG Encoder which is a stateful JPEG Encoder
> present in J722s SoC, supporting baseline encoding of semiplanar based
> YUV420 and YUV422 raw video formats to JPEG encoding, with resolutions
> supported from 64x64 to 8kx8k.
> 
> Signed-off-by: Brandon Brnich <b-brnich@ti.com>
> ---
> 
> Changes in v2:
>   - remove invalid clock-names attribute
> 
>  arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> index 5cfa7bf36641..fb24c14614b4 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> @@ -385,6 +385,16 @@ c7x_1: dsp@7e200000 {
>  		ti,sci-proc-ids = <0x31 0xff>;
>  		status = "disabled";
>  	};
> +
> +	e5010: e5010@fd20000 {
> +		compatible = "img,e5010-jpeg-enc";

This is missing ti specific compatible. As we don't use the IP block
directly but there is a wrapper used to integrate with TI platform, so
it is better to use TI specific compatible too to account for the future
compatibility as discussed here [1]. You can refer AM62A device-tree [2]
for references on this.

[1]:
https://lore.kernel.org/all/50d97c30-4926-0bbf-1209-dfd25043e359@ti.com/
[2] :
https://gitlab.com/linux-kernel/linux-next/-/blob/master/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi?ref_type=heads#L1150

Regards
Devarsh