From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yangfl <mmyangfl@gmail.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: clock: Add gate-clock
Date: Sun, 16 Apr 2023 20:31:05 +0200 [thread overview]
Message-ID: <dcaf82c5-8fc6-68fd-c087-8d55def90ea0@linaro.org> (raw)
In-Reply-To: <CAAXyoMPcmbUGDpM6YAyJqGaXvgg2rQOCSdGGnaVQoGd5OE4OwA@mail.gmail.com>
On 16/04/2023 20:28, Yangfl wrote:
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 于2023年4月17日周一 01:41写道：
>>
>> Did you test the changes?
>
> I don't know what "test" is here. make dt_binding_check passed and it
> can work with the driver.
I don't think so. If you tested it, for sure you would see warnings like
"node has a unit name, but no reg or ranges property".
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-16 18:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 17:32 [PATCH v2 0/4] clk: Add basic register clock controller David Yang
2023-04-16 17:32 ` [PATCH v2 1/4] dt-bindings: clock: Add simple-clock-controller David Yang
2023-04-16 17:38 ` Krzysztof Kozlowski
2023-04-16 18:22 ` Yangfl
2023-04-16 18:27 ` Krzysztof Kozlowski
2023-04-17 18:08 ` Yangfl
2023-04-16 17:32 ` [PATCH v2 2/4] clk: Add simple clock controller David Yang
2023-04-16 17:33 ` [PATCH v2 3/4] dt-bindings: clock: Add gate-clock David Yang
2023-04-16 17:41 ` Krzysztof Kozlowski
2023-04-16 18:28 ` Yangfl
2023-04-16 18:31 ` Krzysztof Kozlowski [this message]
2023-04-16 17:33 ` [PATCH v2 4/4] clk: gate: Add DT binding David Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcaf82c5-8fc6-68fd-c087-8d55def90ea0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox