From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45C22568E for ; Mon, 23 Oct 2023 06:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="V2Q+v1m9" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CDF6D67; Sun, 22 Oct 2023 23:12:08 -0700 (PDT) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39N5VU27013178; Mon, 23 Oct 2023 06:11:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=Mdf9dnhXPEH3/y6zMHnys+MtYBluYp2HKByvtJVfWDU=; b=V2Q+v1m982sjMsARXbdhSg2S9eYXLsMP7yb7ix6vy17yXBtbQ3b520T1ccUDJIUaaxMm RSmG+I/6GhX7pqesVaHi2vt575QYv6WsMJkr5JKkze6Cmp6GV4hD/A3blVrqcApbX+fF HgzfEhL7LyntMPK5R2rcRr2DSsSv8i+VYZmxR7387k6pcoqbZWsyxsU6fSQgnrSnuUxx hWTVdlRwJOei63org9iKupPEbc0o40/yn73AvgOBUZ58bgdu9vKwRbhacbC4el8UJn7M krpXsw1vHPpLpTtTemVHwlMCKoOcrSunG3Bn9Fz4mxbzPAd3DiGRQIrEl9CU2pUhZz/v 7Q== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tv7dq3juy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Oct 2023 06:11:38 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 39N6BbJo008482 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Oct 2023 06:11:37 GMT Received: from [10.216.48.174] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Sun, 22 Oct 2023 23:11:25 -0700 Message-ID: Date: Mon, 23 Oct 2023 11:41:21 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 04/11] iio: adc: Update bindings to remove support for ADC7 name used on QCOM PMICs Content-Language: en-US To: Krzysztof Kozlowski , , , , , , , , , , , , , , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , "Rafael J. Wysocki" , "Daniel Lezcano" , Amit Kucheria , "Zhang Rui" , Luca Weiss , , , CC: References: <20230708072835.3035398-1-quic_jprakash@quicinc.com> <20230708072835.3035398-5-quic_jprakash@quicinc.com> From: Jishnu Prakash In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 533T7FuYQLeMU9amL1-42xbwz6oir0dJ X-Proofpoint-GUID: 533T7FuYQLeMU9amL1-42xbwz6oir0dJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-23_03,2023-10-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999 mlxscore=0 clxscore=1015 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001 definitions=main-2310230054 Hi Krzysztof, On 7/9/2023 10:49 PM, Krzysztof Kozlowski wrote: > On 08/07/2023 09:28, Jishnu Prakash wrote: >> Now that usage of "ADC7" name has been replaced with usage of "ADC5 >> Gen2" name everywhere, remove all support for "ADC7" name. > Why? The idea is to replace usage of the name "ADC7" with "ADC5 Gen2" everywhere possible, to match our internal convention and align better with the "ADC5 Gen3" support I'm adding in this patch series - is it better if I just update documentation and dtbindings directly in one patch for ADC5 Gen2 and update devicetree in one patch after that for the corresponding macro changes? > > >> @@ -26,7 +26,6 @@ properties: >> - qcom,spmi-vadc >> - qcom,spmi-adc5 >> - qcom,spmi-adc-rev2 >> - - qcom,spmi-adc7 > NAK. You did not explained why dropping existing compatible is correct, > expected and okay. > > Also: > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. > > > > Best regards, > Krzysztof Yes, I'll avoid dropping the compatible, I'll just mark it deprecated as Jonathan suggested, in a single bindings patch without having separate patches for adding and removing support. Will make sure to check subject prefixes too. Thanks, Jishnu