From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 513AB25392A for ; Thu, 7 Aug 2025 12:37:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754570245; cv=none; b=ShXVXZ5kDDnV79Q52mq7u7sz1kkLWsTP4x7xBECrx8t6k2WJsFRJz3IBv70QdfKwmO8T1iczmZOo4Unf6a9bThEPPqSDQ17psnRg8n0Lp11TLDbX5WYoCCvhbzSXEaCdtpHTowmtdXBpiZZyMh32VGD17whz0E3niJjJVGKWijU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754570245; c=relaxed/simple; bh=0HJeJ81F/fe85KKd6Kapj27WSnTdBWo7pAlxPgJ+W+8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j6c7jCDO/tJfuShCLNotL02TsqPWKT2i8AjiFLE9ZXcowld0FluWTLov2AGPdi+zCgWvPoahXTe74kmEbm/fAPz1NE6t62dLVLtmzdxh4CJG0bM7pq6EdfKoeVBDEsEv4q3N4WiMBGRJvriZLoCH4skhyIRc/WAUnzLB+444OzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V+KcYBcm; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V+KcYBcm" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-459e210bd2dso7019745e9.1 for ; Thu, 07 Aug 2025 05:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754570241; x=1755175041; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SssdXwaRmyli//zxIcsg2m9oDnPDhQ01niz7e6EkH/Y=; b=V+KcYBcm6vor/TLEdzELJDMbBpcx4fn4qeRyde73qXR311YugSs+lgKZudvQlCSDyr ONP8fn0i6y7u2MJvdxoK4zn6ks+y74Yj4EfC2f9P1RHd5AuJZb8hbF9usmaH5lianoFg b5J5Qobjc9FtpHjS814twCjD3O9y/C/oFxRXpyGGTcoRJdmx5HgGlyLA88dLWzqkMohn A5Jod/JCd5jLuHvYelCbIJpNX7m53nlFv6ycjw+d0mo8ctxR4N+maP5Rg6K/htP0pYJk YGQof2W1e8Q+80zZH1irv7r7TxEiWWZv5djNIZq9Xje8m1/5dAKTwLnJa3ZW76bsgS1B YR1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754570241; x=1755175041; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SssdXwaRmyli//zxIcsg2m9oDnPDhQ01niz7e6EkH/Y=; b=Qud2wvFmYTGRYLMGvnfA4JIet+MNT2ouRY6zSpH+d5okS6bHvzRf2sUg89v3uhGKl+ CsFKRBBEALZqaUatzvQ9jHAxnjVDrYl1vKapi/RxQcKt2OnbZVbv0vhWSwZx/QwMLNcl ORm6e+Tgq2nSi8pLVo4YbBus+R8XCFcx4EE0iXQRns/rPTQsyRIYpXp7UXf3HzPuQxTJ re/hnc/GJ2uY/VNSDlTO/iDHnW0m8Y6N8I8ZASJwkJTzGMcnRfiKtxXs6767uL3GQPgl w8sljx+EgnLT9wC+pCuwbTUWouTEnU/0WC0njirczzURGREdOiLua3tCvjh/hExCEX2v mCVA== X-Forwarded-Encrypted: i=1; AJvYcCUKVBQ8DlyG6tZVpqa8yA13WO3kfRY67nqdirK8GussPHe98YbM94TKy/Km9xnrCcpfmv0Te8lXt9pI@vger.kernel.org X-Gm-Message-State: AOJu0YzIinIqhN2fwD4xqcQRFyOUcjxZjzROOqmhSDHK6pu3JpBWRgNn QUwV6cqBxOJ8sfe2M4du3xl2odniOaH9FhSHxGZh67CphQk783BVF/1bGWb93d6nDq0= X-Gm-Gg: ASbGncvzr6BbQcQnKm8KX8GYealn1sncU3SIeApNLHluaYh1+67o98cb0QaXoeaVTg+ YuQv3BvA4DLZTsL42SwC80mpmaT23A8ywebtXECE7qO8Jhqjz49OwJR9nPbzyorAqzshpY7GEi6 S26CspG2s6o43D5bEN/41SbAPutYZ19iLdrLc8vLFuhIcwp6y994Yju62j4Jz4nN9jC6mmMV05c F7KS+Ot8Mz7QvUUCc05YeMmCfhzwYMQv0KhQxflwx7CJc1xGk9+PIJ3L5mcYEJwueXOCinN2awZ HiMtxRp4xrjDshbbYdyTd2ZQcIyncmy5zhtyCuXsA4gn1ypYU8FpoSH4sWNNFa8vYkRXNSCV6Ds N+8h8HDK0qJ5NwQX6HoAYVg/Ajj2YDBT+2crSCVCzftCpMQ1Ut8uG2ggSPBAxXx4= X-Google-Smtp-Source: AGHT+IFOEsRG8ebIvvAsL7B/AJ9oBvQYifwwUwKVZY3a9oI94ficILiwiXeFUjcUVB8C/IvgBehkEw== X-Received: by 2002:a05:6000:310b:b0:3b8:de54:6e64 with SMTP id ffacd0b85a97d-3b8f97e6e52mr3149326f8f.26.1754570240565; Thu, 07 Aug 2025 05:37:20 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c4532c4sm26483493f8f.36.2025.08.07.05.37.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Aug 2025 05:37:20 -0700 (PDT) Message-ID: Date: Thu, 7 Aug 2025 13:37:18 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/10] [RFT] arm64: dts: qcom: sm8250: extend CAMSS with new CSIPHY subdevices To: Vladimir Zapolskiy , Krzysztof Kozlowski , Rob Herring , Bjorn Andersson , Konrad Dybcio Cc: Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Neil Armstrong , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org References: <20250612011531.2923701-1-vladimir.zapolskiy@linaro.org> <20250612011531.2923701-10-vladimir.zapolskiy@linaro.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250612011531.2923701-10-vladimir.zapolskiy@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/06/2025 02:15, Vladimir Zapolskiy wrote: > Following the new device tree bindings for CAMSS IPs introduce csiphy2 > device tree node under SM8250 CAMSS, which allows to perform camera > tests of the model on an RB5 board with an attached vision mezzanine. > > Note that the optional 'phys' property is deliberately not added. > > Signed-off-by: Vladimir Zapolskiy > --- > For testing only, do not merge. > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index f0d18fd37aaf..401a32679580 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -4613,6 +4613,10 @@ camss: camss@ac6a000 { > "cam_sf_0_mnoc", > "cam_sf_icp_mnoc"; > > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > ports { > #address-cells = <1>; > #size-cells = <0>; > @@ -4641,6 +4645,16 @@ port@5 { > reg = <5>; > }; > }; > + > + csiphy2: phy@ac6e000 { > + compatible = "qcom,csiphy"; > + reg = <0 0x0ac6e000 0 0x1000>; > + clocks = <&camcc CAM_CC_CSIPHY2_CLK>, > + <&camcc CAM_CC_CSI2PHYTIMER_CLK>; > + clock-names = "csiphy", "csiphy_timer"; > + interrupts = ; > + #phy-cells = <0>; > + }; > }; > I don't think we should make this change, for CAMSS in general and specifically for sm8250. Instead I think we should go this way: https://lore.kernel.org/linux-media/20250710-x1e-csi2-phy-v1-1-74acbb5b162b@linaro.org/ With separate standalone nodes, and reuse of the upstream PHY API. I believe you have a series for the 8650, please rebase on https://lore.kernel.org/linux-media/20250710-x1e-csi2-phy-v1-1-74acbb5b162b@linaro.org/ and https://lore.kernel.org/linux-media/20250711-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v7-0-0bc5da82f526@linaro.org V2 of the CSIPHY above will incorporate feedback from Neil and yourself on adding endpoint@ to the PHY however I think we need to have a conversation about standards compliance at attaching two sensors to one CSIPHY without VCs or TDM. --- bod