From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7796C433F5 for ; Sat, 2 Apr 2022 18:24:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233981AbiDBS0W (ORCPT ); Sat, 2 Apr 2022 14:26:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbiDBS0V (ORCPT ); Sat, 2 Apr 2022 14:26:21 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12218DBD03 for ; Sat, 2 Apr 2022 11:24:29 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id r13so8538960wrr.9 for ; Sat, 02 Apr 2022 11:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=MpP5tMzlVT97DCsXRGEb24iOg+E3Ct/YpLQmX1mvqMo=; b=HgXWNE/hFd3yEXhfRAlqQosWSph7ZcBbIdzrEVWa5k88aYzA5NqgBw6PTdAQqTvE3r pnsBONHYxFPRbcQ0EOhq5j7K/ulf/jL0nljM1dHaVgiu8unnZ3avcCLKbhpHiUk3NKt1 n66ncWS7ZnJrbfgtqNV6d6p3G3mUG23ECU1artSWceXo3sRRQ7OY7OZiwSVKUM5e8h5g v+OOOQT9WrLTAA3HWgYcnTlxUn7c5MjU06EzJrHUyvEaR1bAShlGNw2F0C5d72kY0Rpi 5+dDq4Co2/43+xlj1Q/cZJvOlkXyQu7cik71r2xzWKOe+FtVwFYshUBvCnzC/pwpUfS9 MKzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=MpP5tMzlVT97DCsXRGEb24iOg+E3Ct/YpLQmX1mvqMo=; b=SyA3nnthd9Dr5Pk85PRbAqtTZA3CB2nVQiiPbYfu8rlj6reVGMDEsqiSoaEewXnZst K5BPso+fKEV7W4tQIH7aYX2vEMiGdylM1+Vk3MGqZo4svTtuWxXFzQ1fDqpZWfF0lby4 Opnc8I9i29uiuegrQPmt8Dv8OGOV6laOQpJxmpW0E7hTaXNJmCI9K2cFydCk2IreJTDV P1/7yzAfYg/qX1pp/psYRF/8lB+/UnE1SkUiO59gW3cvSe5LHGnmen5/rhbvlD7RIVhf QInKSdVO5GexWut/Ob2UIk89xPytqO/rGq/W1pdISkRCeS6BlDMAkzy8JVD6pLObwCtS 8YyQ== X-Gm-Message-State: AOAM532ZIbV3QikdcakAisg/lCBixgHskkffM2R0hb3zHhOx9ri0NxV9 +euismZ0LV/7FjYbnrEJYGY+6A== X-Google-Smtp-Source: ABdhPJxwj6OiIV5XsBWzlet7KuFQwDDTn3qzeMv3EQDAImRrUp/htKknULpYtWY9PjbEo8tdtAShIw== X-Received: by 2002:a5d:4c82:0:b0:204:d78:7635 with SMTP id z2-20020a5d4c82000000b002040d787635mr11827185wrs.318.1648923867619; Sat, 02 Apr 2022 11:24:27 -0700 (PDT) Received: from [192.168.0.171] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id z5-20020a05600c0a0500b0037fa93193a8sm5899277wmp.44.2022.04.02.11.24.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Apr 2022 11:24:27 -0700 (PDT) Message-ID: Date: Sat, 2 Apr 2022 20:24:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/5] dt-bindings: i2c: Add Qualcomm Geni based QUP i2c bindings Content-Language: en-US To: Kuldeep Singh , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org References: <20220402051206.6115-1-singh.kuldeep87k@gmail.com> <20220402051206.6115-2-singh.kuldeep87k@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220402051206.6115-2-singh.kuldeep87k@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/04/2022 07:12, Kuldeep Singh wrote: > GENI(generic interface) based Qualcomm Universal Peripheral controller > can support multiple serial interfaces like spi,uart and i2c. > Few more comments. (...) > + > + clock-frequency: > + description: Desired I2C bus clock frequency in Hz Skip description, it's common for I2C controllers. > + default: 100000 > + > + interconnects: > + maxItems: 3 > + > + interconnect-names: > + items: > + - const: qup-core > + - const: qup-config > + - const: qup-memory > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + required-opps: > + maxItems: 1 > + > + dmas: > + maxItems: 2 > + > + dma-names: > + items: > + - const: tx > + - const: rx > + > + pinctrl-0: true > + pinctrl-1: true > + > + pinctrl-names: > + minItems: 1 > + items: > + - const: default > + - const: sleep > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 These are not needed, they come from schema. Best regards, Krzysztof